[SSSD] [sssd PR#379][comment] CI: Enable pep8 check

URL: https://github.com/SSSD/sssd/pull/379 Title: #379: CI: Enable pep8 check lslebodn commented: """ cigarette """ See the full comment at https://github.com/SSSD/sssd/pull/379#issuecomment-351685924 ___ sssd-devel mailing list --

[SSSD] [sssd PR#379][comment] CI: Enable pep8 check

URL: https://github.com/SSSD/sssd/pull/379 Title: #379: CI: Enable pep8 check lslebodn commented: """ cigarette """ See the full comment at https://github.com/SSSD/sssd/pull/379#issuecomment-351685924 ___ sssd-devel mailing list --

[SSSD] [sssd PR#379][comment] CI: Enable pep8 check

URL: https://github.com/SSSD/sssd/pull/379 Title: #379: CI: Enable pep8 check fidencio commented: """ Well, when a PR is not reviewed and the comments come with: "Coding style was never a priority and I cannot see a reason why core developer need to sped a time with fixing coding style issues

[SSSD] [sssd PR#379][comment] CI: Enable pep8 check

URL: https://github.com/SSSD/sssd/pull/379 Title: #379: CI: Enable pep8 check lslebodn commented: """ On (14/12/17 10:08), fidencio wrote: >As per @lslebodn's comments I understand that SSSD project has **no** interest >on this PR at the moment. > Please do not put words to my mouth. I have

[SSSD] [sssd PR#379][comment] CI: Enable pep8 check

URL: https://github.com/SSSD/sssd/pull/379 Title: #379: CI: Enable pep8 check tiran commented: """ As a software developer with over 20 years of coding experience and involved in lots of Open Source projects written in C, Go and Python, I have to disagree with you. A consistent code style and

[SSSD] [sssd PR#379][comment] CI: Enable pep8 check

URL: https://github.com/SSSD/sssd/pull/379 Title: #379: CI: Enable pep8 check fidencio commented: """ As per @lslebodn's comments I understand that SSSD project has **no** interest on this PR at the moment. I've opened https://pagure.io/SSSD/sssd/issue/3605 and I'm closing this PR. """ See

[SSSD] [sssd PR#379][comment] CI: Enable pep8 check

URL: https://github.com/SSSD/sssd/pull/379 Title: #379: CI: Enable pep8 check lslebodn commented: """ On (14/12/17 08:47), fidencio wrote: >We **really** have to have a better way to handle PRs as it's not the first >time it happens ... > pep8 is only about coding style it does not make code

[SSSD] [sssd PR#379][comment] CI: Enable pep8 check

URL: https://github.com/SSSD/sssd/pull/379 Title: #379: CI: Enable pep8 check fidencio commented: """ Hmm. And seems that I will have to re-work these patches as more new issues have been added meanwhile this patch was stuck. :-/ We **really** have to have a better way to handle PRs as it's

[SSSD] [sssd PR#379][comment] CI: Enable pep8 check

URL: https://github.com/SSSD/sssd/pull/379 Title: #379: CI: Enable pep8 check fidencio commented: """ I have updated the patch set and fired a CI build. I'd really appreciate if we can have this one pushed as soon as our internal CI passes and then avoid having to fix pep8 issues in the

[SSSD] [sssd PR#379][comment] CI: Enable pep8 check

URL: https://github.com/SSSD/sssd/pull/379 Title: #379: CI: Enable pep8 check fidencio commented: """ Man, that you have some serious problems with language is quite clear ... but, unfortunately, seems you also have some really serious problems with reading. Let me copy a comment made a few

[SSSD] [sssd PR#379][comment] CI: Enable pep8 check

URL: https://github.com/SSSD/sssd/pull/379 Title: #379: CI: Enable pep8 check lslebodn commented: """ We do not have a tracking ticket for enforcing pep8 check therefore I cannot set ticket https://pagure.io/SSSD/sssd/issue/3463 as a blocker for enforcing pep8. Therefore label "Changes

[SSSD] [sssd PR#379][comment] CI: Enable pep8 check

URL: https://github.com/SSSD/sssd/pull/379 Title: #379: CI: Enable pep8 check lslebodn commented: """ Reverting "intg: Disable add_remove tests" and adding it back is not nice. Much better would be to fix https://pagure.io/SSSD/sssd/issue/3463 and it would be much better spent time of core

[SSSD] [sssd PR#379][comment] CI: Enable pep8 check

URL: https://github.com/SSSD/sssd/pull/379 Title: #379: CI: Enable pep8 check fidencio commented: """ CI: http://vm-058-233.${abc}/logs/job/77/70/summary.html """ See the full comment at https://github.com/SSSD/sssd/pull/379#issuecomment-330652762

[SSSD] [sssd PR#379][comment] CI: Enable pep8 check

URL: https://github.com/SSSD/sssd/pull/379 Title: #379: CI: Enable pep8 check fidencio commented: """ I have updated the patch set. This new version has the each issue fixed explained and also the ones found just on this or that distro also explained where they were found. CI is already

[SSSD] [sssd PR#379][comment] CI: Enable pep8 check

URL: https://github.com/SSSD/sssd/pull/379 Title: #379: CI: Enable pep8 check fidencio commented: """ @lslebodn, @jhrozek: I'll follow a different approach in case you guys are fine. Basically what I'm going to do is combine all the ignored by default warnings in all our supported systems

[SSSD] [sssd PR#379][comment] CI: Enable pep8 check

URL: https://github.com/SSSD/sssd/pull/379 Title: #379: CI: Enable pep8 check fidencio commented: """ CI: http://vm-058-233.${abc}/logs/job/77/61/summary.html """ See the full comment at https://github.com/SSSD/sssd/pull/379#issuecomment-330502831

[SSSD] [sssd PR#379][comment] CI: Enable pep8 check

URL: https://github.com/SSSD/sssd/pull/379 Title: #379: CI: Enable pep8 check fidencio commented: """ I have provided a workaround for the issues pointed out in one of my comments. That may be a way to go ... """ See the full comment at

[SSSD] [sssd PR#379][comment] CI: Enable pep8 check

URL: https://github.com/SSSD/sssd/pull/379 Title: #379: CI: Enable pep8 check jhrozek commented: """ cc @tiran """ See the full comment at https://github.com/SSSD/sssd/pull/379#issuecomment-329418574 ___ sssd-devel mailing list --

[SSSD] [sssd PR#379][comment] CI: Enable pep8 check

URL: https://github.com/SSSD/sssd/pull/379 Title: #379: CI: Enable pep8 check jhrozek commented: """ I suspect Debian uses a different Python version that carries a different pep8 check. I wonder if any of the Python developers from the IPA team can help us. Can you check with them? """ See

[SSSD] [sssd PR#379][comment] CI: Enable pep8 check

URL: https://github.com/SSSD/sssd/pull/379 Title: #379: CI: Enable pep8 check fidencio commented: """ Okay. I still have some issues with debian and those I'm not exactly sure how to solve, thus I'd appreciate if I can get some help from someone who's either a little bit more familiar with

[SSSD] [sssd PR#379][comment] CI: Enable pep8 check

URL: https://github.com/SSSD/sssd/pull/379 Title: #379: CI: Enable pep8 check fidencio commented: """ Seems that I broke one of the integration tests and there are more issues on debian. """ See the full comment at https://github.com/SSSD/sssd/pull/379#issuecomment-329378299

[SSSD] [sssd PR#379][comment] CI: Enable pep8 check

URL: https://github.com/SSSD/sssd/pull/379 Title: #379: CI: Enable pep8 check fidencio commented: """ retest this, please """ See the full comment at https://github.com/SSSD/sssd/pull/379#issuecomment-329287584 ___ sssd-devel mailing list --

[SSSD] [sssd PR#379][comment] CI: Enable pep8 check

URL: https://github.com/SSSD/sssd/pull/379 Title: #379: CI: Enable pep8 check lslebodn commented: """ Thank you very for writing this test. Boring checks is better to automatize :-) """ See the full comment at https://github.com/SSSD/sssd/pull/379#issuecomment-329096965

[SSSD] [sssd PR#379][comment] CI: Enable pep8 check

URL: https://github.com/SSSD/sssd/pull/379 Title: #379: CI: Enable pep8 check fidencio commented: """ On Wednesday, September 13, 2017, lslebodn wrote: > *@lslebodn* commented on this pull request. > -- > > In contrib/ci/run >

[SSSD] [sssd PR#379][comment] CI: Enable pep8 check

URL: https://github.com/SSSD/sssd/pull/379 Title: #379: CI: Enable pep8 check fidencio commented: """ On Tue, Sep 12, 2017 at 10:49 PM, Jakub Hrozek wrote: > Well, yeah, all our python code should conform to pep8. I sent a PR some > time ago that tried to reformat

[SSSD] [sssd PR#379][comment] CI: Enable pep8 check

URL: https://github.com/SSSD/sssd/pull/379 Title: #379: CI: Enable pep8 check jhrozek commented: """ Well, yeah, all our python code should conform to pep8. I sent a PR some time ago that tried to reformat the tests but I don't have any time to rework it or check for other issues in other

[SSSD] [sssd PR#379][comment] CI: Enable pep8 check

URL: https://github.com/SSSD/sssd/pull/379 Title: #379: CI: Enable pep8 check fidencio commented: """ It's not going to work, @jhrozek. We have .py files in a few different places than in our tests and those will have to be fixed as well in case this PR is desired. Another option would be to

[SSSD] [sssd PR#379][comment] CI: Enable pep8 check

URL: https://github.com/SSSD/sssd/pull/379 Title: #379: CI: Enable pep8 check jhrozek commented: """ Well, I applied the patch on top of the old pep8 PR and submitted to CI, let's see what results we get. """ See the full comment at

[SSSD] [sssd PR#379][comment] CI: Enable pep8 check

URL: https://github.com/SSSD/sssd/pull/379 Title: #379: CI: Enable pep8 check jhrozek commented: """ (Then it would make sense to resubmit both in the same PR) """ See the full comment at https://github.com/SSSD/sssd/pull/379#issuecomment-328801865

[SSSD] [sssd PR#379][comment] CI: Enable pep8 check

URL: https://github.com/SSSD/sssd/pull/379 Title: #379: CI: Enable pep8 check fidencio commented: """ Btw, CI obviously fails due to the pip8 check. """ See the full comment at https://github.com/SSSD/sssd/pull/379#issuecomment-328295582 ___