URL: https://github.com/SSSD/sssd/pull/412 Author: mzidek-rh Title: #412: Gpo contributed patches Action: edited
Changed field: body Original value: """ Hi, I am moving the patches from this PR: https://pagure.io/SSSD/sssd/pull-request/3320 Here on GH. The issue was stalled for a long time, and I do not think it is good idea to ask for changes in the patches after 7 months. So I decided to immediately change all the problems I found and squshed them into the patches in this PR. There were no big issues with the patches: - I rebased it on top of the current master - added missing include for toupper function - the debug message format was not the same as we use on other places (note that this change was difficult to squash for each patch, so not all patches are 'clean', because I squashed all the debug message issues to the GPO: Improve logging of GPO... patch, however the result after applying all patches is as expected) - I added some comments - there were some memory leaks (missing frees) Notice that I am not the author of the patches, only reviewer. The patches as they are in this PR LGTM. I tested them to check if something is broken (manually.. sigh) and now I am waiting for the CI results. There was one issue occuring when I tested these patches and I originally though the is caused by these patches, but now I know it is not. The issue is that I did not have GPOs distributed to all DCs and it looks like SSSD randomly picks one DC and contacts it (even though it was DC from subdomain) so it could not always find all the GPOs (it looked for them on wrong DCs, where they were not). Other then that I encountered no issues with the patches, so it is ACK from me (tentative). However since I am not native speaker and the last patch is MAN page change, I would appreciate second pair of eyes for that patch. Second pair of eyes for the rest of the patches would also be appreciated :) However if nobody raises any issues I will ACK it soon (given the tests will pass). """
_______________________________________________ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
