URL: https://github.com/SSSD/sssd/pull/488
Title: #488: Two fixes for certificates in idoverrides
lslebodn commented:
"""
>Yes, but one of the ssh patches was a dependency for 4300385 so I thought it's
>safer to just cleanly apply patches and have one less bug in sssd-1-13 at the
>same time.
URL: https://github.com/SSSD/sssd/pull/488
Title: #488: Two fixes for certificates in idoverrides
jhrozek commented:
"""
Yes, but one of the ssh patches was a dependency for 4300385 so I thought it's
safer to just cleanly apply patches and have one less bug in sssd-1-13 at the
same time. Of
URL: https://github.com/SSSD/sssd/pull/488
Title: #488: Two fixes for certificates in idoverrides
sumit-bose commented:
"""
Yes, only 'ipa: remove SYSDB_USER_CERT from sub-domain users' (4300385) needs
to be backported from this PR. The other two commit @jhrozek mentioned are for
ssh public
URL: https://github.com/SSSD/sssd/pull/488
Title: #488: Two fixes for certificates in idoverrides
lslebodn commented:
"""
@sumit-bose,
I think it should be enough to backport "ipa: remove SYSDB_USER_CERT from
sub-domain users".
At least just this patch was in #494. Is that correct?
"""
See
URL: https://github.com/SSSD/sssd/pull/488
Title: #488: Two fixes for certificates in idoverrides
fidencio commented:
"""
Just for the record: backported patches do look fine by me and I do believe
just having those 4 patches backported make sense.
I still would like to know whether it
URL: https://github.com/SSSD/sssd/pull/488
Title: #488: Two fixes for certificates in idoverrides
fidencio commented:
"""
@lslebodn, could you give your opinion/review here on the backported patches as
per https://github.com/SSSD/sssd/pull/488#issuecomment-367286098 ?
"""
See the full comment
URL: https://github.com/SSSD/sssd/pull/488
Title: #488: Two fixes for certificates in idoverrides
jhrozek commented:
"""
btw since I'll be afk tomorrow for most of the day and I don't dare to push the
patches myself at 10 PM my time without a discussion I created a backport here:
URL: https://github.com/SSSD/sssd/pull/488
Title: #488: Two fixes for certificates in idoverrides
jhrozek commented:
"""
I'm actually wondering whether we need to backport the patches or whether we
need to backport them both. I wonder if it enough to backport "ipa: remove
SYSDB_USER_CERT from
URL: https://github.com/SSSD/sssd/pull/488
Title: #488: Two fixes for certificates in idoverrides
jhrozek commented:
"""
I'm actually wondering whether we need to backport the patches or whether we
need to backport them both. I wonder if it enough to backport "ipa: remove
SYSDB_USER_CERT from
URL: https://github.com/SSSD/sssd/pull/488
Title: #488: Two fixes for certificates in idoverrides
jhrozek commented:
"""
I'm looking at what needs to be backported to sssd-1-13 before these two
patches before closing.
"""
See the full comment at
URL: https://github.com/SSSD/sssd/pull/488
Title: #488: Two fixes for certificates in idoverrides
jhrozek commented:
"""
* master:
* 5e04cbb8b6a10a794b698184fc84f9d359350253
URL: https://github.com/SSSD/sssd/pull/488
Title: #488: Two fixes for certificates in idoverrides
jhrozek commented:
"""
I don't really have any other comments, ACK
"""
See the full comment at
https://github.com/SSSD/sssd/pull/488#issuecomment-368555947
URL: https://github.com/SSSD/sssd/pull/488
Title: #488: Two fixes for certificates in idoverrides
jhrozek commented:
"""
I didn't re-test the patches yet, because I didn't realize it was urgent for
1.13. I'll try to do it on Monday to be sure but after reading the explanation,
I think
URL: https://github.com/SSSD/sssd/pull/488
Title: #488: Two fixes for certificates in idoverrides
fidencio commented:
"""
Code-wise the patches do look good.
@jhrozek, is there still some question pending from your side? How your tests
went?
"""
See the full comment at
URL: https://github.com/SSSD/sssd/pull/488
Title: #488: Two fixes for certificates in idoverrides
lslebodn commented:
"""
This PR is also required for stable branch (1.13) #494. Please do not forget to
push it also to older branches after pushing to master
"""
See the full comment at
URL: https://github.com/SSSD/sssd/pull/488
Title: #488: Two fixes for certificates in idoverrides
sumit-bose commented:
"""
Hi Jakub,
thank you for the review, I rebased the patches on top of the current master.
About userMappedCertificate, it is expected that it is not added on the client
URL: https://github.com/SSSD/sssd/pull/488
Title: #488: Two fixes for certificates in idoverrides
jhrozek commented:
"""
The patches need to be rebased but the rebase seems easy.
Can you help me check if I test the patches properly? I added a cert to default
trust view (that's the only view
17 matches
Mail list logo
