URL: https://github.com/SSSD/sssd/pull/500
Author: jhrozek
 Title: #500: SYSDB: Read the ldb_message from loop's index counter when 
reading subdomain UPNs
Action: opened

PR body:
"""
Related to: https://pagure.io/SSSD/sssd/issue/3431

There was a typo in code that read the UPN suffixes from the subdomain
ldb_message. As a result, the UPN suffixes from the first domain were
always consulted for all domains.
"""

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/500/head:pr500
git checkout pr500
From e8e1deb50aa62b485194000b06327c2d46a3c6fe Mon Sep 17 00:00:00 2001
From: Jakub Hrozek <jhro...@redhat.com>
Date: Tue, 23 Jan 2018 11:11:14 +0100
Subject: [PATCH] SYSDB: Read the ldb_message from loop's index counter when
 reading subdomain UPNs

Related to:
https://pagure.io/SSSD/sssd/issue/3431

There was a typo in code that read the UPN suffixes from the subdomain
ldb_message. As a result, the UPN suffixes from the first domain were
always consulted for all domains.
---
 src/db/sysdb_subdomains.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/db/sysdb_subdomains.c b/src/db/sysdb_subdomains.c
index 8964712b6..bdd5245f2 100644
--- a/src/db/sysdb_subdomains.c
+++ b/src/db/sysdb_subdomains.c
@@ -386,7 +386,7 @@ errno_t sysdb_update_subdomains(struct sss_domain_info *domain,
                                              SYSDB_SUBDOMAIN_FOREST, NULL);
 
         upn_suffixes = NULL;
-        tmp_el = ldb_msg_find_element(res->msgs[0], SYSDB_UPN_SUFFIXES);
+        tmp_el = ldb_msg_find_element(res->msgs[i], SYSDB_UPN_SUFFIXES);
         if (tmp_el != NULL) {
             upn_suffixes = sss_ldb_el_to_string_list(tmp_ctx, tmp_el);
             if (upn_suffixes == NULL) {
_______________________________________________
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

Reply via email to