[SSSD] [sssd PR#620][comment] Add pam_cert_pam_services option

2018-08-13 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/620 Title: #620: Add pam_cert_pam_services option fidencio commented: """ @lslebodn's patch has been merged, thus I'm closing this PR. """ See the full comment at https://github.com/SSSD/sssd/pull/620#issuecomment-412535140 ___

[SSSD] [sssd PR#620][comment] Add pam_cert_pam_services option

2018-08-09 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/620 Title: #620: Add pam_cert_pam_services option sumit-bose commented: """ @fidencio, yes, I'm currently reviewing @lslebodn patch. """ See the full comment at https://github.com/SSSD/sssd/pull/620#issuecomment-411987368 _

[SSSD] [sssd PR#620][comment] Add pam_cert_pam_services option

2018-08-09 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/620 Title: #620: Add pam_cert_pam_services option fidencio commented: """ @sumit-bose, shall we go for @lslebodn's patch instead? If so, I'd close this PR and push https://pagure.io/SSSD/sssd/pull-request/3799 Tomorrow. """ See the full comment at https:

[SSSD] [sssd PR#620][comment] Add pam_cert_pam_services option

2018-08-08 Thread abbra
URL: https://github.com/SSSD/sssd/pull/620 Title: #620: Add pam_cert_pam_services option abbra commented: """ I'm also fine with @lslebodn patch """ See the full comment at https://github.com/SSSD/sssd/pull/620#issuecomment-411374966 ___ sssd-devel m

[SSSD] [sssd PR#620][comment] Add pam_cert_pam_services option

2018-08-08 Thread abbra
URL: https://github.com/SSSD/sssd/pull/620 Title: #620: Add pam_cert_pam_services option abbra commented: """ I think +service style is better. Sorry for slow answers, I'm at the conference this week. """ See the full comment at https://github.com/SSSD/sssd/pull/620#issuecomment-411373283 ___

[SSSD] [sssd PR#620][comment] Add pam_cert_pam_services option

2018-08-08 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/620 Title: #620: Add pam_cert_pam_services option sumit-bose commented: """ @lslebodn created a PR with his old patch at https://pagure.io/SSSD/sssd/pull-request/3799. @abbra, would you agree that the +- style makes the configuration easier or do you see

[SSSD] [sssd PR#620][comment] Add pam_cert_pam_services option

2018-08-07 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/620 Title: #620: Add pam_cert_pam_services option sumit-bose commented: """ Hi Alexander, thank you for the patch. There is an old patch by @lslebodn which tries to solve the same issue at https://lists.fedoraproject.org/archives/list/sssd-devel@lists.fe

[SSSD] [sssd PR#620][comment] Add pam_cert_pam_services option

2018-07-20 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/620 Title: #620: Add pam_cert_pam_services option fidencio commented: """ @abbra, patch looks good to me. I'd also provide a scratch-build to Orion in order to be sure it works for him. In any case, if it's not urgent I'd also like to have either @jhrozek'

[SSSD] [sssd PR#620][comment] Add pam_cert_pam_services option

2018-07-20 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/620 Title: #620: Add pam_cert_pam_services option fidencio commented: """ ok to test """ See the full comment at https://github.com/SSSD/sssd/pull/620#issuecomment-406566714 ___ sssd-devel mailing list -- sssd-d

[SSSD] [sssd PR#620][comment] Add pam_cert_pam_services option

2018-07-20 Thread centos-ci
URL: https://github.com/SSSD/sssd/pull/620 Title: #620: Add pam_cert_pam_services option centos-ci commented: """ Can one of the admins verify this patch? """ See the full comment at https://github.com/SSSD/sssd/pull/620#issuecomment-406550777 ___ ss

[SSSD] [sssd PR#620][comment] Add pam_cert_pam_services option

2018-07-20 Thread centos-ci
URL: https://github.com/SSSD/sssd/pull/620 Title: #620: Add pam_cert_pam_services option centos-ci commented: """ Can one of the admins verify this patch? """ See the full comment at https://github.com/SSSD/sssd/pull/620#issuecomment-406550776 ___ ss