URL: https://github.com/SSSD/sssd/pull/631
Title: #631: nss: remove unused label
fidencio commented:
"""
master:
e8b417e
"""
See the full comment at
https://github.com/SSSD/sssd/pull/631#issuecomment-412120488
___
sssd-devel mailing list --
URL: https://github.com/SSSD/sssd/pull/631
Title: #631: nss: remove unused label
sumit-bose commented:
"""
Ok, CI passed with an unrealated issue. ACK.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/631#issuecomment-412110512
___
URL: https://github.com/SSSD/sssd/pull/631
Title: #631: nss: remove unused label
sumit-bose commented:
"""
Thanks, I've started a CI run.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/631#issuecomment-411987087
___
sssd-devel mailing
URL: https://github.com/SSSD/sssd/pull/631
Title: #631: nss: remove unused label
fidencio commented:
"""
@sumit-bose, I've changed my mind and fully adopted your suggestion in one
single patch.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/631#issuecomment-411858930
URL: https://github.com/SSSD/sssd/pull/631
Title: #631: nss: remove unused label
fidencio commented:
"""
I agree with your comment (but maybe I would prefer to have your suggestion as
a separate patch of this very same PR).
Would you mind pushing this as it is in order to fix the breakage
URL: https://github.com/SSSD/sssd/pull/631
Title: #631: nss: remove unused label
sumit-bose commented:
"""
I had a minor comment (see inline), please let me know if you agree or if you
think that it would be safer to keep this patch minimal.
"""
See the full comment at
