[SSSD] [sssd PR#81][comment] Please see the commit message, the fix is hopefully simple

2016-11-22 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/81 Title: #81: Please see the commit message, the fix is hopefully simple lslebodn commented: """ master: * 2927dc45b9bc810f4f55bce165bb96405129e693 sssd-1-14: * 495289cfa922b00278aa91d433489403e792304e sssd-1-13: *

[SSSD] [sssd PR#81][comment] Please see the commit message, the fix is hopefully simple

2016-11-22 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/81 Title: #81: Please see the commit message, the fix is hopefully simple fidencio commented: """ Acked-by: Fabiano FidĂȘncio """ See the full comment at https://github.com/SSSD/sssd/pull/81#issuecomment-262235759

[SSSD] [sssd PR#81][comment] Please see the commit message, the fix is hopefully simple

2016-11-22 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/81 Title: #81: Please see the commit message, the fix is hopefully simple jhrozek commented: """ Thanks for the review, I pushed a new version. I did test the patch (otherwise the conditional build of the files provider where I added AM_CONDITIONAL didn't

[SSSD] [sssd PR#81][comment] Please see the commit message, the fix is hopefully simple

2016-11-21 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/81 Title: #81: Please see the commit message, the fix is hopefully simple lslebodn commented: """ On (21/11/16 13:53), fidencio wrote: >For future interactions would be way simpler if the reviewer could just push >the patch with the simple fix and point

[SSSD] [sssd PR#81][comment] Please see the commit message, the fix is hopefully simple

2016-11-21 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/81 Title: #81: Please see the commit message, the fix is hopefully simple fidencio commented: """ So, AFAIU what's is missing is this small patch: ``` [ffidenci@cat x86_64]$ git diff diff --git a/src/external/inotify.m4 b/src/external/inotify.m4 index

[SSSD] [sssd PR#81][comment] Please see the commit message, the fix is hopefully simple

2016-11-18 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/81 Title: #81: Please see the commit message, the fix is hopefully simple lslebodn commented: """ This is only a problem with strict warning flags. which is usually a develer build. There is not a problem in downstream centos/fedora ->see