URL: https://github.com/SSSD/sssd/pull/820
Title: #820: ad: delete domains disabled through ad_enabled_domains from cache
sumit-bose commented:
"""
sssd-1-16:
- 0b6f144084ec3ed96eb2c60bed7bea5d6c15f15c
- 5605fa5f8adf79fa60286f5427aa2f989e663de0
- 3c6c9d4d939bb2f1f629421e347285bea9a59341
-
URL: https://github.com/SSSD/sssd/pull/820
Title: #820: ad: delete domains disabled through ad_enabled_domains from cache
sumit-bose commented:
"""
sssd-1-16:
-0b6f144084ec3ed96eb2c60bed7bea5d6c15f15c
- 5605fa5f8adf79fa60286f5427aa2f989e663de0
- 3c6c9d4d939bb2f1f629421e347285bea9a59341
-
URL: https://github.com/SSSD/sssd/pull/820
Title: #820: ad: delete domains disabled through ad_enabled_domains from cache
sumit-bose commented:
"""
Master:
- b3c3542188e50770b431942c0b603e6f2733cb33
- d0bdaabbc95bc9ee3253e1376d849e6a8bd6c6f0
- c7e6530d642f746982c5306cf3455608d1980d1f
-
URL: https://github.com/SSSD/sssd/pull/820
Title: #820: ad: delete domains disabled through ad_enabled_domains from cache
sumit-bose commented:
"""
Hi,
this version now works well in my tests and Coverity didn't find an issue. ACK.
bye,
Sumit
"""
See the full comment at
URL: https://github.com/SSSD/sssd/pull/820
Title: #820: ad: delete domains disabled through ad_enabled_domains from cache
pbrezina commented:
"""
Thank you. I just pushed to correct version.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/820#issuecomment-521941787
URL: https://github.com/SSSD/sssd/pull/820
Title: #820: ad: delete domains disabled through ad_enabled_domains from cache
sumit-bose commented:
"""
Hi Pavel,
please check if all patches are added there. It looks like 'sysdb: add
sysdb_list_subdomains()' and 'ad: remove all subdomains if only
URL: https://github.com/SSSD/sssd/pull/820
Title: #820: ad: delete domains disabled through ad_enabled_domains from cache
sumit-bose commented:
"""
> Perhaps `ad_subdomains.c:193`? All other interactions with the list that I
> foud is case insensitive.
>
> ```c
> is_ad_in_domains = false;
URL: https://github.com/SSSD/sssd/pull/820
Title: #820: ad: delete domains disabled through ad_enabled_domains from cache
pbrezina commented:
"""
Perhaps `ad_subdomains.c:193`? All other interactions with the list that I foud
is case insensitive.
```c
is_ad_in_domains = false;
for
URL: https://github.com/SSSD/sssd/pull/820
Title: #820: ad: delete domains disabled through ad_enabled_domains from cache
sumit-bose commented:
"""
Hi Pavel,
sorry for not being clear but your 3 points are exactly what I meant.
My tests went well. I had one issue where I'm not sure if should
URL: https://github.com/SSSD/sssd/pull/820
Title: #820: ad: delete domains disabled through ad_enabled_domains from cache
pbrezina commented:
"""
Thank you Sumit. Your answer was not clear so I chose to delete all subdomains
from cache in case when only master domain is enabled.
Now:
* If
URL: https://github.com/SSSD/sssd/pull/820
Title: #820: ad: delete domains disabled through ad_enabled_domains from cache
sumit-bose commented:
"""
> Ok, I managed to setup trust with the child domain (it was necessary to
> change client's hostname because it was already enrolled to the root
URL: https://github.com/SSSD/sssd/pull/820
Title: #820: ad: delete domains disabled through ad_enabled_domains from cache
pbrezina commented:
"""
Ok, I managed to setup trust with the child domain (it was necessary to change
client's hostname because it was already enrolled to the root domain)
URL: https://github.com/SSSD/sssd/pull/820
Title: #820: ad: delete domains disabled through ad_enabled_domains from cache
pbrezina commented:
"""
Pull request:
https://github.com/SSSD/sssd/pull/820
"""
See the full comment at
https://github.com/SSSD/sssd/pull/820#issuecomment-497295105
URL: https://github.com/SSSD/sssd/pull/820
Title: #820: ad: delete domains disabled through ad_enabled_domains from cache
pbrezina commented:
"""
I did not test the "root" domain case because I was not able to establish trust
with a non-root domain so far. But the pull request is
14 matches
Mail list logo
