URL: https://github.com/SSSD/sssd/pull/851
Title: #851: Update __init__.py.in
pbrezina commented:
"""
* `master`
* 05c078e60f87d0eae33f4d6ff34a413976075b8c - Update __init__.py.in
"""
See the full comment at
https://github.com/SSSD/sssd/pull/851#issuecomment-544474472
URL: https://github.com/SSSD/sssd/pull/851
Title: #851: Update __init__.py.in
alexal commented:
"""
@pbrezina sure, I do not mind. Thanks a lot.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/851#issuecomment-544469285
___
sssd-devel
URL: https://github.com/SSSD/sssd/pull/851
Title: #851: Update __init__.py.in
pbrezina commented:
"""
Thank you. Ack.
I'm going to squash the following change (which was requested in [this
comment](https://github.com/SSSD/sssd/pull/851#issuecomment-542156240)) before
pushing - unless you
URL: https://github.com/SSSD/sssd/pull/851
Title: #851: Update __init__.py.in
alexal commented:
"""
@pbrezina thanks! I've added ldap_sudo_include_regexp &
ldap_autofs_map_master_name options to the test. That should cover everything
described in the original ticket. I've run multiple tests
URL: https://github.com/SSSD/sssd/pull/851
Title: #851: Update __init__.py.in
pbrezina commented:
"""
Thank you. One more thing - then I will ack it. Can you add a test case for the
use case in ticket description? Perhaps as part of sssd-valid.conf tests.
"""
See the full comment at
URL: https://github.com/SSSD/sssd/pull/851
Title: #851: Update __init__.py.in
alexal commented:
"""
@pbrezina good catch, do not know how I missed that provider in the test. I no
longer have any failures on my machine:
Testsuite summary for sssd 2.2.3
TOTAL: 4
PASS: 4
SKIP: 0
XFAIL: 0
FAIL:
URL: https://github.com/SSSD/sssd/pull/851
Title: #851: Update __init__.py.in
alexal commented:
"""
@pbrezina good catch, do not know how I missed that provider in the test. I no
longer have any failures on my machine:
Testsuite summary for sssd 2.2.3
# TOTAL: 4
# PASS: 4
# SKIP: 0
# XFAIL:
URL: https://github.com/SSSD/sssd/pull/851
Title: #851: Update __init__.py.in
alexal commented:
"""
@pbrezina good catch, do not know how I missed that provider in the test. I no
longer have any failures on my machine:
URL: https://github.com/SSSD/sssd/pull/851
Title: #851: Update __init__.py.in
pbrezina commented:
"""
So basically, you want to move those unsupported providers into
`negative_domain_control_list` to make sure they are not set. And add
`chpass_provider` to `domain_control_list` to make sure
URL: https://github.com/SSSD/sssd/pull/851
Title: #851: Update __init__.py.in
pbrezina commented:
"""
No, the test fails because you are missing `chpass_provider` in
`domain_control_list`.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/851#issuecomment-542154975
URL: https://github.com/SSSD/sssd/pull/851
Title: #851: Update __init__.py.in
alexal commented:
"""
@pbrezina ,
Just wondering if you had a chance to review the code?
Thanks!
"""
See the full comment at
https://github.com/SSSD/sssd/pull/851#issuecomment-541138115
URL: https://github.com/SSSD/sssd/pull/851
Title: #851: Update __init__.py.in
alexal commented:
"""
@pbrezina ,
I've made changes to the code, all tests went fine except this:
> ==
> FAIL: testImportConfigNoVersion
URL: https://github.com/SSSD/sssd/pull/851
Title: #851: Update __init__.py.in
alexal commented:
"""
@pbrezina sure, let me make those changes.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/851#issuecomment-539500230
___
sssd-devel
URL: https://github.com/SSSD/sssd/pull/851
Title: #851: Update __init__.py.in
pbrezina commented:
"""
I also get the following error with the reproducer from the ticket description:
```bash
$ sudo ./sssdconfig.py
Traceback (most recent call last):
File "./sssdconfig.py", line 7, in
URL: https://github.com/SSSD/sssd/pull/851
Title: #851: Update __init__.py.in
alexal commented:
"""
@pbrezina ,
I apologize for the delay, I had a lot of things at work. I've modified the
code, but a few additional changes might be required, because I'm getting this
error for the following
URL: https://github.com/SSSD/sssd/pull/851
Title: #851: Update __init__.py.in
pbrezina commented:
"""
Yes, some providers are still not handled (session, chpass and access). Also
could you change the code to use dictionary and for loop instead of duplicating
the code? Additionally I think it
URL: https://github.com/SSSD/sssd/pull/851
Title: #851: Update __init__.py.in
alexal commented:
"""
@pbrezina do you have any additional requests for changes or everything looks
good?
"""
See the full comment at
https://github.com/SSSD/sssd/pull/851#issuecomment-523909076
URL: https://github.com/SSSD/sssd/pull/851
Title: #851: Update __init__.py.in
alexal commented:
"""
> When we are touching the code, I believe also `subdomains_provider` is
> missing. Also most of the providers defaults to `id_provider`, few have other
> defaults so I think it should be
URL: https://github.com/SSSD/sssd/pull/851
Title: #851: Update __init__.py.in
alexal commented:
"""
> @alexal Alex, can you please complete the patch by adding missing things per
> [this](https://github.com/SSSD/sssd/pull/851#issuecomment-516750056) comment?
> Thank you.
@pbrezina done. I
URL: https://github.com/SSSD/sssd/pull/851
Title: #851: Update __init__.py.in
pbrezina commented:
"""
Sure it would be better, but I'd say it is out of scope of this pull request.
Unless the author wants to do the extra job, of course.
@alexal Alex, can you please complete the patch by adding
URL: https://github.com/SSSD/sssd/pull/851
Title: #851: Update __init__.py.in
jhrozek commented:
"""
I don't know if it's easy or possible but wouldn't it be better to amend the
config API to internally synthetize the provider values, but does not write
them to the config file? Otherwise I'm
URL: https://github.com/SSSD/sssd/pull/851
Title: #851: Update __init__.py.in
pbrezina commented:
"""
When we are touching the code, I believe also `subdomains_provider` is missing.
Also most of the providers defaults to `id_provider`, few have other defaults
so I think it should be handled
URL: https://github.com/SSSD/sssd/pull/851
Title: #851: Update __init__.py.in
jhrozek commented:
"""
I thought @pbrezina might?
"""
See the full comment at
https://github.com/SSSD/sssd/pull/851#issuecomment-516357806
___
sssd-devel mailing list --
URL: https://github.com/SSSD/sssd/pull/851
Title: #851: Update __init__.py.in
alexal commented:
"""
Who will test these changes?
"""
See the full comment at
https://github.com/SSSD/sssd/pull/851#issuecomment-515435317
___
sssd-devel mailing list --
URL: https://github.com/SSSD/sssd/pull/851
Title: #851: Update __init__.py.in
alexey-tikhonov commented:
"""
> @alexey-tikhonov all the CI engines are green now. Unless you have more
> comments, would you mind adding the Accepted label so that we can push the PR?
I am sorry I didn't actually
URL: https://github.com/SSSD/sssd/pull/851
Title: #851: Update __init__.py.in
jhrozek commented:
"""
Oh and about the centos CI triggers. I added both Alexey and Tomas to the
centos CI whitelist so that the "OK to test" magic phrase would work for them.
Honestly I thought everyone was added
URL: https://github.com/SSSD/sssd/pull/851
Title: #851: Update __init__.py.in
jhrozek commented:
"""
@alexey-tikhonov all the CI engines are green now. Unless you have more
comments, would you mind adding the Accepted label so that we can push the PR?
"""
See the full comment at
URL: https://github.com/SSSD/sssd/pull/851
Title: #851: Update __init__.py.in
alexey-tikhonov commented:
"""
OK to test
"""
See the full comment at
https://github.com/SSSD/sssd/pull/851#issuecomment-512808215
___
sssd-devel mailing list --
URL: https://github.com/SSSD/sssd/pull/851
Title: #851: Update __init__.py.in
pbrezina commented:
"""
ok to test
"""
See the full comment at
https://github.com/SSSD/sssd/pull/851#issuecomment-512818844
___
sssd-devel mailing list --
URL: https://github.com/SSSD/sssd/pull/851
Title: #851: Update __init__.py.in
thalman commented:
"""
OK to test
"""
See the full comment at
https://github.com/SSSD/sssd/pull/851#issuecomment-512811541
___
sssd-devel mailing list --
URL: https://github.com/SSSD/sssd/pull/851
Title: #851: Update __init__.py.in
alexey-tikhonov commented:
"""
OK to test
"""
See the full comment at
https://github.com/SSSD/sssd/pull/851#issuecomment-512808215
___
sssd-devel mailing list --
URL: https://github.com/SSSD/sssd/pull/851
Title: #851: Update __init__.py.in
alexal commented:
"""
@alexey-tikhonov thanks for your help.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/851#issuecomment-512808110
___
sssd-devel
URL: https://github.com/SSSD/sssd/pull/851
Title: #851: Update __init__.py.in
alexey-tikhonov commented:
"""
> @alexey-tikhonov thanks for your suggestions. What about now? Looks better?
Much better. Thank you.
"""
See the full comment at
URL: https://github.com/SSSD/sssd/pull/851
Title: #851: Update __init__.py.in
alexal commented:
"""
@alexey-tikhonov thanks for your suggestions. What about now? Looks better?
"""
See the full comment at
https://github.com/SSSD/sssd/pull/851#issuecomment-512794563
URL: https://github.com/SSSD/sssd/pull/851
Title: #851: Update __init__.py.in
alexey-tikhonov commented:
"""
> @alexey-tikhonov done, sorry I didn't do that from the beginning.
But now there are 5 commits in the https://github.com/alexal/sssd/commits/dev
branch...
I am not sure what would be
URL: https://github.com/SSSD/sssd/pull/851
Title: #851: Update __init__.py.in
alexal commented:
"""
@alexey-tikhonov done, sorry I didn't do that from the beginning.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/851#issuecomment-512773893
URL: https://github.com/SSSD/sssd/pull/851
Title: #851: Update __init__.py.in
alexey-tikhonov commented:
"""
Actually it looks like it is better to have all three patches as single commit.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/851#issuecomment-512772037
URL: https://github.com/SSSD/sssd/pull/851
Title: #851: Update __init__.py.in
alexey-tikhonov commented:
"""
Hi @alexal,
Thank you for contribution.
Would you please merge two patches of `__init__.py.in` into one?
Or is there any reason to keep it separate?
"""
See the full comment at
URL: https://github.com/SSSD/sssd/pull/851
Title: #851: Update __init__.py.in
alexal commented:
"""
I do see only this error in fedora28/ci-mock-build.log
Mock Version: 1.4.15
INFO: Mock Version: 1.4.15
Start: dnf install
ERROR: Exception(rpmbuild/SRPMS/sssd-2.2.1-0.fc28.src.rpm)
URL: https://github.com/SSSD/sssd/pull/851
Title: #851: Update __init__.py.in
centos-ci commented:
"""
Can one of the admins verify this patch?
"""
See the full comment at
https://github.com/SSSD/sssd/pull/851#issuecomment-512504391
___
sssd-devel
40 matches
Mail list logo
