URL: https://github.com/SSSD/sssd/pull/912
Title: #912: Created a new sssd-ldap-attributes.5 man page
pbrezina commented:
"""
* `master`
* 83fb5c3557a8ec6c96a98ec75ff947685d3c07ea - Created a new
sssd-ldap-attributes.5 man page
"""
See the full comment at
URL: https://github.com/SSSD/sssd/pull/912
Title: #912: Created a new sssd-ldap-attributes.5 man page
pbrezina commented:
"""
Ack. Thank you.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/912#issuecomment-552823068
___
sssd-devel
URL: https://github.com/SSSD/sssd/pull/912
Title: #912: Created a new sssd-ldap-attributes.5 man page
alexal commented:
"""
@pbrezina I just wondering if you had a chance to review the last commit? Do
you have any further requests or everything looks good to you?
"""
See the full comment at
URL: https://github.com/SSSD/sssd/pull/912
Title: #912: Created a new sssd-ldap-attributes.5 man page
alexal commented:
"""
@pbrezina thanks, please see the updated commit with your patch.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/912#issuecomment-551077602
URL: https://github.com/SSSD/sssd/pull/912
Title: #912: Created a new sssd-ldap-attributes.5 man page
pbrezina commented:
"""
Here is a simple patch that makes the include file more seeming-less. Please
squash it to your patch and I will ack it. Thank you.
URL: https://github.com/SSSD/sssd/pull/912
Title: #912: Created a new sssd-ldap-attributes.5 man page
alexal commented:
"""
@pbrezina I appreciate your comments. Please see the updated commit with the
required changes. Does everything look good?
"""
See the full comment at
URL: https://github.com/SSSD/sssd/pull/912
Title: #912: Created a new sssd-ldap-attributes.5 man page
pbrezina commented:
"""
I still see `ldap_autofs_map_object_class` in `sssd-ldap` but it is an LDAP
attribute. I think it would be beneficial to keep autofs attributes options in
both
URL: https://github.com/SSSD/sssd/pull/912
Title: #912: Created a new sssd-ldap-attributes.5 man page
alexal commented:
"""
@pbrezina I've fixed a problem with the whitespace. Just wondering if you had a
chance to check the most recent changes to those two man pages? Do you have any
further
URL: https://github.com/SSSD/sssd/pull/912
Title: #912: Created a new sssd-ldap-attributes.5 man page
alexal commented:
"""
@pbrezina I've fixed the problem with the whitespace. Just wondering if you had
a chance to check the most recent changes to those two man pages? Do you have
any further
URL: https://github.com/SSSD/sssd/pull/912
Title: #912: Created a new sssd-ldap-attributes.5 man page
alexal commented:
"""
@pbrezina I appreciate your comments. I've made those changes, please see the
updated commit.
"""
See the full comment at
URL: https://github.com/SSSD/sssd/pull/912
Title: #912: Created a new sssd-ldap-attributes.5 man page
pbrezina commented:
"""
Thank you for your contribution Alex. You have resolved the mock-build problem,
although I would rather like to see the man page listed explicitly, i.e.:
```diff
URL: https://github.com/SSSD/sssd/pull/912
Title: #912: Created a new sssd-ldap-attributes.5 man page
alexal commented:
"""
@alexey-tikhonov , @thalman please take a look. It does appear I have resolved
a problem with mock-build step.
"""
See the full comment at
URL: https://github.com/SSSD/sssd/pull/912
Title: #912: Created a new sssd-ldap-attributes.5 man page
alexey-tikhonov commented:
"""
> @thalman I see that you have added a "Changes requested" label, may I ask
> what's needs to be changed?
I believe this is due to CI fails. `mock-build` step
URL: https://github.com/SSSD/sssd/pull/912
Title: #912: Created a new sssd-ldap-attributes.5 man page
alexal commented:
"""
@thalman I see that you have added a "Changes requested" label, may I ask
what's needs to be changed?
"""
See the full comment at
URL: https://github.com/SSSD/sssd/pull/912
Title: #912: Created a new sssd-ldap-attributes.5 man page
alexey-tikhonov commented:
"""
ok to test
"""
See the full comment at
https://github.com/SSSD/sssd/pull/912#issuecomment-545848268
___
sssd-devel
URL: https://github.com/SSSD/sssd/pull/912
Title: #912: Created a new sssd-ldap-attributes.5 man page
centos-ci commented:
"""
Can one of the admins verify this patch?
"""
See the full comment at
https://github.com/SSSD/sssd/pull/912#issuecomment-545203835
16 matches
Mail list logo
