URL: https://github.com/SSSD/sssd/pull/943
Title: #943: files_ops: Fix cached password remove
elkoniu commented:
"""
Rebased and minor bugs fixed. Status is still work in progress.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/943#issuecomment-564835434
URL: https://github.com/SSSD/sssd/pull/943
Title: #943: files_ops: Fix cached password remove
alexey-tikhonov commented:
"""
Hi @elkoniu,
Thank you for your patch.
Please see comments inline.
In regards of `sysdb_delete_recursive_with_filter()` those are mostly nitpicks.
There is only one
URL: https://github.com/SSSD/sssd/pull/943
Title: #943: files_ops: Fix cached password remove
alexey-tikhonov commented:
"""
Hi @elkoniu,
`test_multiple_files_created_after_startup` test fails at every CI machine. I
don't recall this test failing previously so probably this is not one of
URL: https://github.com/SSSD/sssd/pull/943
Title: #943: files_ops: Fix cached password remove
pbrezina commented:
"""
There is no need to keep a dead code. Please, remove them in separate patch.
This way it will not be in the code and we can always recover them if needed in
the future.
"""
URL: https://github.com/SSSD/sssd/pull/943
Title: #943: files_ops: Fix cached password remove
elkoniu commented:
"""
Commit rebased to latest master branch. Two functions in the code are unused
now. I leave them intentionally as someone may need them in future.
"""
See the full comment at
URL: https://github.com/SSSD/sssd/pull/943
Title: #943: files_ops: Fix cached password remove
alexey-tikhonov commented:
"""
Hi @elkoniu,
For some reason CI currently fails to compile your branch. I guess rebase is
required.
Would you please rebase your PR on current master?
"""
See the
URL: https://github.com/SSSD/sssd/pull/943
Title: #943: files_ops: Fix cached password remove
alexey-tikhonov commented:
"""
retest this please
"""
See the full comment at
https://github.com/SSSD/sssd/pull/943#issuecomment-559737650
___
sssd-devel
URL: https://github.com/SSSD/sssd/pull/943
Title: #943: files_ops: Fix cached password remove
alexey-tikhonov commented:
"""
retest this please
"""
See the full comment at
https://github.com/SSSD/sssd/pull/943#issuecomment-559733674
___
sssd-devel
URL: https://github.com/SSSD/sssd/pull/943
Title: #943: files_ops: Fix cached password remove
alexey-tikhonov commented:
"""
retest this please
"""
See the full comment at
https://github.com/SSSD/sssd/pull/943#issuecomment-559733674
___
sssd-devel
