[SSSD] Re: [PATCH] Do not crash if GetUserAttrs cannot be parsed

2016-05-10 Thread Pavel Březina
On 05/10/2016 12:34 PM, Jakub Hrozek wrote: On Tue, May 10, 2016 at 12:06:39PM +0200, Pavel Březina wrote: On 05/05/2016 11:38 AM, Jakub Hrozek wrote: On Wed, Apr 27, 2016 at 11:47:50AM +0200, Pavel Březina wrote: Can you also extend sbus_request_invoke_or_finish() to treat

[SSSD] Re: [PATCH] Do not crash if GetUserAttrs cannot be parsed

2016-05-10 Thread Jakub Hrozek
On Tue, May 10, 2016 at 12:06:39PM +0200, Pavel Březina wrote: > On 05/05/2016 11:38 AM, Jakub Hrozek wrote: > > On Wed, Apr 27, 2016 at 11:47:50AM +0200, Pavel Březina wrote: > > > >Can you also extend sbus_request_invoke_or_finish() to treat > > > >ERR_SBUS_REQUEST_HANDLED the same way as EOK?

[SSSD] Re: [PATCH] Do not crash if GetUserAttrs cannot be parsed

2016-05-10 Thread Pavel Březina
On 05/05/2016 11:38 AM, Jakub Hrozek wrote: On Wed, Apr 27, 2016 at 11:47:50AM +0200, Pavel Březina wrote: >Can you also extend sbus_request_invoke_or_finish() to treat >ERR_SBUS_REQUEST_HANDLED the same way as EOK? I.e. > >case EOK: >case ERR_SBUS_REQUEST_HANDLED: > return; > >This way you

[SSSD] Re: [PATCH] Do not crash if GetUserAttrs cannot be parsed

2016-05-05 Thread Jakub Hrozek
On Wed, Apr 27, 2016 at 11:47:50AM +0200, Pavel Březina wrote: > Can you also extend sbus_request_invoke_or_finish() to treat > ERR_SBUS_REQUEST_HANDLED the same way as EOK? I.e. > > case EOK: > case ERR_SBUS_REQUEST_HANDLED: > return; > > This way you don't have to translate the new error

[SSSD] Re: [PATCH] Do not crash if GetUserAttrs cannot be parsed

2016-04-27 Thread Pavel Březina
On 04/27/2016 11:13 AM, Jakub Hrozek wrote: On Wed, Apr 20, 2016 at 01:20:14PM +0200, Pavel Březina wrote: On 04/20/2016 11:56 AM, Jakub Hrozek wrote: Hi Pavel, can you check if this is the right thing to do for methods that parse arguments on their own? To reproduce, it was enough to run:

[SSSD] Re: [PATCH] Do not crash if GetUserAttrs cannot be parsed

2016-04-27 Thread Jakub Hrozek
On Wed, Apr 20, 2016 at 01:20:14PM +0200, Pavel Březina wrote: > On 04/20/2016 11:56 AM, Jakub Hrozek wrote: > > Hi Pavel, > > > > can you check if this is the right thing to do for methods that parse > > arguments on their own? > > > > To reproduce, it was enough to run: > > sudo dbus-send

[SSSD] Re: [PATCH] Do not crash if GetUserAttrs cannot be parsed

2016-04-20 Thread Pavel Březina
On 04/20/2016 11:56 AM, Jakub Hrozek wrote: Hi Pavel, can you check if this is the right thing to do for methods that parse arguments on their own? To reproduce, it was enough to run: sudo dbus-send --print-reply --system --dest=org.freedesktop.sssd.infopipe