[SSSD] Re: [PATCH] PAM: Export original user shell to tlog-rec

2016-05-30 Thread Nikolai Kondrashov
On 05/27/2016 04:24 PM, Sumit Bose wrote: On Fri, May 27, 2016 at 02:00:12PM +0300, Nikolai Kondrashov wrote: On 05/26/2016 12:36 PM, Sumit Bose wrote: On Mon, May 23, 2016 at 10:26:37PM +0300, Nikolai Kondrashov wrote: On 05/20/2016 02:50 PM, Sumit Bose wrote: On Fri, May 20, 2016 at

[SSSD] Re: [PATCH] PAM: Export original user shell to tlog-rec

2016-05-27 Thread Sumit Bose
On Fri, May 27, 2016 at 02:00:12PM +0300, Nikolai Kondrashov wrote: > On 05/26/2016 12:36 PM, Sumit Bose wrote: > > On Mon, May 23, 2016 at 10:26:37PM +0300, Nikolai Kondrashov wrote: > > > First of all, I assume you meant "shell" whenever you used "homedir" > > > > oops, sorry, yes

[SSSD] Re: [PATCH] PAM: Export original user shell to tlog-rec

2016-05-27 Thread Nikolai Kondrashov
On 05/26/2016 12:36 PM, Sumit Bose wrote: On Mon, May 23, 2016 at 10:26:37PM +0300, Nikolai Kondrashov wrote: First of all, I assume you meant "shell" whenever you used "homedir" oops, sorry, yes get_homedir_override() is just before get_shell_override() in nsssrv_cmd.c and I slipped into the

[SSSD] Re: [PATCH] PAM: Export original user shell to tlog-rec

2016-05-26 Thread Sumit Bose
On Mon, May 23, 2016 at 10:26:37PM +0300, Nikolai Kondrashov wrote: > Hi Sumit, > > Thank you for the reply! > > First of all, I assume you meant "shell" whenever you used "homedir" oops, sorry, yes get_homedir_override() is just before get_shell_override() in nsssrv_cmd.c and I slipped into

[SSSD] Re: [PATCH] PAM: Export original user shell to tlog-rec

2016-05-23 Thread Nikolai Kondrashov
Hi Sumit, Thank you for the reply! First of all, I assume you meant "shell" whenever you used "homedir" previously. Please see my further replies below. On 05/20/2016 02:50 PM, Sumit Bose wrote: On Fri, May 20, 2016 at 01:54:33PM +0300, Nikolai Kondrashov wrote: On 05/20/2016 01:39 PM, Sumit

[SSSD] Re: [PATCH] PAM: Export original user shell to tlog-rec

2016-05-20 Thread Sumit Bose
On Fri, May 20, 2016 at 01:54:33PM +0300, Nikolai Kondrashov wrote: > On 05/20/2016 01:39 PM, Sumit Bose wrote: > > On Fri, May 20, 2016 at 12:53:51PM +0300, Nikolai Kondrashov wrote: > > > On 05/19/2016 02:41 PM, Sumit Bose wrote: > > > > On Thu, May 12, 2016 at 04:29:07PM +0300, Nikolai

[SSSD] Re: [PATCH] PAM: Export original user shell to tlog-rec

2016-05-20 Thread Nikolai Kondrashov
On 05/20/2016 01:39 PM, Sumit Bose wrote: On Fri, May 20, 2016 at 12:53:51PM +0300, Nikolai Kondrashov wrote: On 05/19/2016 02:41 PM, Sumit Bose wrote: On Thu, May 12, 2016 at 04:29:07PM +0300, Nikolai Kondrashov wrote: On 04/26/2016 11:32 AM, Sumit Bose wrote: On Mon, Apr 25, 2016 at

[SSSD] Re: [PATCH] PAM: Export original user shell to tlog-rec

2016-05-20 Thread Sumit Bose
On Fri, May 20, 2016 at 12:53:51PM +0300, Nikolai Kondrashov wrote: > On 05/19/2016 02:41 PM, Sumit Bose wrote: > > On Thu, May 12, 2016 at 04:29:07PM +0300, Nikolai Kondrashov wrote: > > > On 04/26/2016 11:32 AM, Sumit Bose wrote: > > > > On Mon, Apr 25, 2016 at 09:16:22PM +0300, Nikolai

[SSSD] Re: [PATCH] PAM: Export original user shell to tlog-rec

2016-05-20 Thread Nikolai Kondrashov
On 05/19/2016 02:41 PM, Sumit Bose wrote: On Thu, May 12, 2016 at 04:29:07PM +0300, Nikolai Kondrashov wrote: On 04/26/2016 11:32 AM, Sumit Bose wrote: On Mon, Apr 25, 2016 at 09:16:22PM +0300, Nikolai Kondrashov wrote: On 04/11/2016 07:44 PM, Sumit Bose wrote: On Fri, Apr 08, 2016 at

[SSSD] Re: [PATCH] PAM: Export original user shell to tlog-rec

2016-05-19 Thread Sumit Bose
On Thu, May 12, 2016 at 04:29:07PM +0300, Nikolai Kondrashov wrote: > On 04/26/2016 11:32 AM, Sumit Bose wrote: > > On Mon, Apr 25, 2016 at 09:16:22PM +0300, Nikolai Kondrashov wrote: > > > On 04/11/2016 07:44 PM, Sumit Bose wrote: > > > > On Fri, Apr 08, 2016 at 07:31:59PM +0300, Nikolai

[SSSD] Re: [PATCH] PAM: Export original user shell to tlog-rec

2016-05-12 Thread Nikolai Kondrashov
On 04/26/2016 11:32 AM, Sumit Bose wrote: On Mon, Apr 25, 2016 at 09:16:22PM +0300, Nikolai Kondrashov wrote: On 04/11/2016 07:44 PM, Sumit Bose wrote: On Fri, Apr 08, 2016 at 07:31:59PM +0300, Nikolai Kondrashov wrote: On 04/06/2016 02:06 PM, Sumit Bose wrote: I wonder if it would makes

[SSSD] Re: [PATCH] PAM: Export original user shell to tlog-rec

2016-04-26 Thread Sumit Bose
On Mon, Apr 25, 2016 at 09:16:22PM +0300, Nikolai Kondrashov wrote: > On 04/11/2016 07:44 PM, Sumit Bose wrote: > >On Fri, Apr 08, 2016 at 07:31:59PM +0300, Nikolai Kondrashov wrote: > >>On 04/06/2016 02:06 PM, Sumit Bose wrote: > >>>I wonder if it would makes sense to add the cached user object

[SSSD] Re: [PATCH] PAM: Export original user shell to tlog-rec

2016-04-25 Thread Nikolai Kondrashov
On 04/11/2016 07:44 PM, Sumit Bose wrote: On Fri, Apr 08, 2016 at 07:31:59PM +0300, Nikolai Kondrashov wrote: On 04/06/2016 02:06 PM, Sumit Bose wrote: I wonder if it would makes sense to add the cached user object to preq in pam_check_user_search() to avoid the lookup in

[SSSD] Re: [PATCH] PAM: Export original user shell to tlog-rec

2016-04-11 Thread Sumit Bose
On Fri, Apr 08, 2016 at 07:31:59PM +0300, Nikolai Kondrashov wrote: > On 04/06/2016 02:06 PM, Sumit Bose wrote: > >On Wed, Apr 06, 2016 at 12:59:32PM +0300, Nikolai Kondrashov wrote: > >>On 03/18/2016 07:56 PM, Nikolai Kondrashov wrote: > >>>The attached patch adds exporting of the original

[SSSD] Re: [PATCH] PAM: Export original user shell to tlog-rec

2016-04-11 Thread Nikolai Kondrashov
On 04/11/2016 11:43 AM, Jakub Hrozek wrote: On Fri, Apr 08, 2016 at 07:31:59PM +0300, Nikolai Kondrashov wrote: On 04/06/2016 02:06 PM, Sumit Bose wrote: sorry for the delay. The patch looks good in general and is working as expected. Currently the environment variable is set unconditionally

[SSSD] Re: [PATCH] PAM: Export original user shell to tlog-rec

2016-04-11 Thread Jakub Hrozek
On Fri, Apr 08, 2016 at 07:31:59PM +0300, Nikolai Kondrashov wrote: > On 04/06/2016 02:06 PM, Sumit Bose wrote: > >On Wed, Apr 06, 2016 at 12:59:32PM +0300, Nikolai Kondrashov wrote: > >>On 03/18/2016 07:56 PM, Nikolai Kondrashov wrote: > >>>The attached patch adds exporting of the original

[SSSD] Re: [PATCH] PAM: Export original user shell to tlog-rec

2016-04-08 Thread Nikolai Kondrashov
On 04/06/2016 02:06 PM, Sumit Bose wrote: On Wed, Apr 06, 2016 at 12:59:32PM +0300, Nikolai Kondrashov wrote: On 03/18/2016 07:56 PM, Nikolai Kondrashov wrote: The attached patch adds exporting of the original (non-overridden) user shell to tlog-rec, during the PAM session opening. The shell

[SSSD] Re: [PATCH] PAM: Export original user shell to tlog-rec

2016-04-06 Thread Sumit Bose
On Wed, Apr 06, 2016 at 12:59:32PM +0300, Nikolai Kondrashov wrote: > On 03/18/2016 07:56 PM, Nikolai Kondrashov wrote: > >The attached patch adds exporting of the original (non-overridden) user shell > >to tlog-rec, during the PAM session opening. The shell is exported via adding > >variable

[SSSD] Re: [PATCH] PAM: Export original user shell to tlog-rec

2016-04-06 Thread Nikolai Kondrashov
On 03/18/2016 07:56 PM, Nikolai Kondrashov wrote: The attached patch adds exporting of the original (non-overridden) user shell to tlog-rec, during the PAM session opening. The shell is exported via adding variable "TLOG_REC_SHELL" to the user's environment. Bump, tlog still needs this!