[SSSD] Re: [PATCH 2/2] sdap: Skip exact duplicates when extending maps

2016-08-19 Thread Jakub Hrozek
On Fri, Aug 19, 2016 at 10:36:01AM +0200, Jakub Hrozek wrote: > ACK, then. > > CI: http://sssd-ci.duckdns.org/logs/job/52/09/summary.html * master: * 133647422d6e276a597494002873b2afce1d12a7 * b6bc67f3272d8a45fb6b5c01c8a3f8e74010eb71 ___ sssd-de

[SSSD] Re: [PATCH 2/2] sdap: Skip exact duplicates when extending maps

2016-08-19 Thread Jakub Hrozek
On Thu, Aug 18, 2016 at 12:04:46PM +0200, Lukas Slebodnik wrote: > On (18/08/16 11:41), Jakub Hrozek wrote: > >On Wed, Aug 17, 2016 at 04:37:43PM +0200, Lukas Slebodnik wrote: > >> On (17/08/16 15:39), Lukas Slebodnik wrote: > >> >On (16/08/16 15:22), Lukas Slebodnik wrote: > >> >>On (16/08/16 11:5

[SSSD] Re: [PATCH 2/2] sdap: Skip exact duplicates when extending maps

2016-08-18 Thread Lukas Slebodnik
On (18/08/16 11:41), Jakub Hrozek wrote: >On Wed, Aug 17, 2016 at 04:37:43PM +0200, Lukas Slebodnik wrote: >> On (17/08/16 15:39), Lukas Slebodnik wrote: >> >On (16/08/16 15:22), Lukas Slebodnik wrote: >> >>On (16/08/16 11:50), Lukas Slebodnik wrote: >> >>>On (12/08/16 16:30), Lukas Slebodnik wrote

[SSSD] Re: [PATCH 2/2] sdap: Skip exact duplicates when extending maps

2016-08-18 Thread Jakub Hrozek
On Wed, Aug 17, 2016 at 04:37:43PM +0200, Lukas Slebodnik wrote: > On (17/08/16 15:39), Lukas Slebodnik wrote: > >On (16/08/16 15:22), Lukas Slebodnik wrote: > >>On (16/08/16 11:50), Lukas Slebodnik wrote: > >>>On (12/08/16 16:30), Lukas Slebodnik wrote: > On (12/08/16 16:14), Jakub Hrozek wrot

[SSSD] Re: [PATCH 2/2] sdap: Skip exact duplicates when extending maps

2016-08-17 Thread Lukas Slebodnik
On (17/08/16 15:39), Lukas Slebodnik wrote: >On (16/08/16 15:22), Lukas Slebodnik wrote: >>On (16/08/16 11:50), Lukas Slebodnik wrote: >>>On (12/08/16 16:30), Lukas Slebodnik wrote: On (12/08/16 16:14), Jakub Hrozek wrote: >On Fri, Aug 12, 2016 at 04:05:22PM +0200, Lukas Slebodnik wrote: >>

[SSSD] Re: [PATCH 2/2] sdap: Skip exact duplicates when extending maps

2016-08-17 Thread Lukas Slebodnik
On (16/08/16 15:22), Lukas Slebodnik wrote: >On (16/08/16 11:50), Lukas Slebodnik wrote: >>On (12/08/16 16:30), Lukas Slebodnik wrote: >>>On (12/08/16 16:14), Jakub Hrozek wrote: On Fri, Aug 12, 2016 at 04:05:22PM +0200, Lukas Slebodnik wrote: > On (10/08/16 20:59), Michal Židek wrote:

[SSSD] Re: [PATCH 2/2] sdap: Skip exact duplicates when extending maps

2016-08-17 Thread Lukas Slebodnik
On (16/08/16 15:20), Jakub Hrozek wrote: >On Tue, Aug 16, 2016 at 11:50:05AM +0200, Lukas Slebodnik wrote: >> Here you are >> >> LS > >The code looks good, but can you rebase the patches? BTW, You could not apply patches because integration test depends on patches from thread "[PATCH] intg: test n

[SSSD] Re: [PATCH 2/2] sdap: Skip exact duplicates when extending maps

2016-08-16 Thread Lukas Slebodnik
On (16/08/16 11:50), Lukas Slebodnik wrote: >On (12/08/16 16:30), Lukas Slebodnik wrote: >>On (12/08/16 16:14), Jakub Hrozek wrote: >>>On Fri, Aug 12, 2016 at 04:05:22PM +0200, Lukas Slebodnik wrote: On (10/08/16 20:59), Michal Židek wrote: >On 08/10/2016 08:36 PM, Lukas Slebodnik wrote:

[SSSD] Re: [PATCH 2/2] sdap: Skip exact duplicates when extending maps

2016-08-16 Thread Jakub Hrozek
On Tue, Aug 16, 2016 at 11:50:05AM +0200, Lukas Slebodnik wrote: > Here you are > > LS The code looks good, but can you rebase the patches? ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/sssd-dev

[SSSD] Re: [PATCH 2/2] sdap: Skip exact duplicates when extending maps

2016-08-16 Thread Lukas Slebodnik
On (12/08/16 16:30), Lukas Slebodnik wrote: >On (12/08/16 16:14), Jakub Hrozek wrote: >>On Fri, Aug 12, 2016 at 04:05:22PM +0200, Lukas Slebodnik wrote: >>> On (10/08/16 20:59), Michal Židek wrote: >>> >On 08/10/2016 08:36 PM, Lukas Slebodnik wrote: >>> >> On (10/08/16 17:41), Michal Židek wrote: >

[SSSD] Re: [PATCH 2/2] sdap: Skip exact duplicates when extending maps

2016-08-12 Thread Lukas Slebodnik
On (12/08/16 16:14), Jakub Hrozek wrote: >On Fri, Aug 12, 2016 at 04:05:22PM +0200, Lukas Slebodnik wrote: >> On (10/08/16 20:59), Michal Židek wrote: >> >On 08/10/2016 08:36 PM, Lukas Slebodnik wrote: >> >> On (10/08/16 17:41), Michal Židek wrote: >> >> > Hi, >> >> > >> >> > see the attached patc

[SSSD] Re: [PATCH 2/2] sdap: Skip exact duplicates when extending maps

2016-08-12 Thread Jakub Hrozek
On Fri, Aug 12, 2016 at 04:05:22PM +0200, Lukas Slebodnik wrote: > On (10/08/16 20:59), Michal Židek wrote: > >On 08/10/2016 08:36 PM, Lukas Slebodnik wrote: > >> On (10/08/16 17:41), Michal Židek wrote: > >> > Hi, > >> > > >> > see the attached patch. > >> > > >> > I modified the detection of du

[SSSD] Re: [PATCH 2/2] sdap: Skip exact duplicates when extending maps

2016-08-12 Thread Lukas Slebodnik
On (10/08/16 20:59), Michal Židek wrote: >On 08/10/2016 08:36 PM, Lukas Slebodnik wrote: >> On (10/08/16 17:41), Michal Židek wrote: >> > Hi, >> > >> > see the attached patch. >> > >> > I modified the detection of duplicates when >> > extending the maps (sysdb_attr:ldap_attr). >> > >> > When we

[SSSD] Re: [PATCH 2/2] sdap: Skip exact duplicates when extending maps

2016-08-10 Thread Michal Židek
On 08/10/2016 08:36 PM, Lukas Slebodnik wrote: On (10/08/16 17:41), Michal Židek wrote: Hi, see the attached patch. I modified the detection of duplicates when extending the maps (sysdb_attr:ldap_attr). When we try to add entry to the map that already exists in the map, then without this patc

[SSSD] Re: [PATCH 2/2] sdap: Skip exact duplicates when extending maps

2016-08-10 Thread Lukas Slebodnik
On (10/08/16 17:41), Michal Židek wrote: >Hi, > >see the attached patch. > >I modified the detection of duplicates when >extending the maps (sysdb_attr:ldap_attr). > >When we try to add entry to the map >that already exists in the map, then >without this patch we will fail. > >With this patch, we o