Re: [SSSD] [PATCH] Properly detect negative/invalid values for the minId and maxId

2009-09-10 Thread Simo Sorce
On Thu, 2009-09-10 at 11:12 -0400, Stephen Gallagher wrote: Now we'll first read the values in as a string and parse them to ensure that they represent positive numbers. Given conversion from string to integer is not a complex business, shouldn't we just retrieve the entry as a string and do

Re: [SSSD] [PATCH] Properly detect negative/invalid values for the minId and maxId

2009-09-10 Thread Stephen Gallagher
New patch with code review concerns addressed. On 09/10/2009 04:37 PM, Simo Sorce wrote: On Thu, 2009-09-10 at 16:02 -0400, Stephen Gallagher wrote: New approach attached. Patch 0001: Create two convenience functions, strtouint32 and strtoint32. These behave identically to strtol or strtoll,