Re: [SSSD] [PATCH] TESTS: fix compiler warnings

2015-07-28 Thread Pavel Reichl
On 07/28/2015 10:28 AM, Lukas Slebodnik wrote: On (28/07/15 10:16), Pavel Reichl wrote: Hello, please see trivial patch attached which fixes compiler warnings: [snip] ACK for unused variables NACK for discard_const It's beeter to change type of view_name from char * - const char * I

Re: [SSSD] [PATCH] TESTS: fix compiler warnings

2015-07-28 Thread Lukas Slebodnik
On (28/07/15 10:16), Pavel Reichl wrote: Hello, please see trivial patch attached which fixes compiler warnings: ../src/tests/cmocka/test_sysdb_views.c: In function ‘test_sysdb_add_overrides_to_object_local’: ../src/tests/cmocka/test_sysdb_views.c:307:33: error: assignment discards ‘const’

Re: [SSSD] [PATCH] TESTS: fix compiler warnings

2015-07-28 Thread Lukas Slebodnik
On (28/07/15 10:46), Pavel Reichl wrote: On 07/28/2015 10:28 AM, Lukas Slebodnik wrote: On (28/07/15 10:16), Pavel Reichl wrote: Hello, please see trivial patch attached which fixes compiler warnings: [snip] ACK for unused variables NACK for discard_const It's beeter to change type of

Re: [SSSD] [PATCH] TESTS: fix compiler warnings

2015-07-28 Thread Jakub Hrozek
On Tue, Jul 28, 2015 at 12:29:23PM +0200, Lukas Slebodnik wrote: On (28/07/15 10:46), Pavel Reichl wrote: On 07/28/2015 10:28 AM, Lukas Slebodnik wrote: On (28/07/15 10:16), Pavel Reichl wrote: Hello, please see trivial patch attached which fixes compiler warnings: [snip] ACK for