Re: [SSSD] [PATCH] tools: Don't shadow 'exit'

2015-11-10 Thread Lukas Slebodnik
On (10/11/15 09:00), Lukas Slebodnik wrote: >On (10/11/15 08:59), Lukas Slebodnik wrote: >>On (09/11/15 15:33), Jakub Hrozek wrote: >>>On Mon, Nov 09, 2015 at 10:44:49AM +0100, Lukas Slebodnik wrote: Obvious ACK >>> >>>While reviewing your patches, I found one more place I forgot to fix, >>>se

Re: [SSSD] [PATCH] tools: Don't shadow 'exit'

2015-11-10 Thread Jakub Hrozek
On Tue, Nov 10, 2015 at 03:06:22PM +0100, Jakub Hrozek wrote: > On Tue, Nov 10, 2015 at 09:03:55AM +0100, Lukas Slebodnik wrote: > > On (09/11/15 20:53), Jakub Hrozek wrote: > > >On Mon, Nov 09, 2015 at 06:35:05PM +0100, Lukas Slebodnik wrote: > > >> BTW which version do you prefer? > > >> a) signl

Re: [SSSD] [PATCH] tools: Don't shadow 'exit'

2015-11-10 Thread Jakub Hrozek
On Tue, Nov 10, 2015 at 09:03:55AM +0100, Lukas Slebodnik wrote: > On (09/11/15 20:53), Jakub Hrozek wrote: > >On Mon, Nov 09, 2015 at 06:35:05PM +0100, Lukas Slebodnik wrote: > >> BTW which version do you prefer? > >> a) signl > >> b) sig > >> c) a_signal > > > >I don't care :) Feel free to use a_

Re: [SSSD] [PATCH] tools: Don't shadow 'exit'

2015-11-10 Thread Lukas Slebodnik
On (09/11/15 20:53), Jakub Hrozek wrote: >On Mon, Nov 09, 2015 at 06:35:05PM +0100, Lukas Slebodnik wrote: >> BTW which version do you prefer? >> a) signl >> b) sig >> c) a_signal > >I don't care :) Feel free to use a_signal since it came first. Updated patches are attached. LS >From a2a1495247ed

Re: [SSSD] [PATCH] tools: Don't shadow 'exit'

2015-11-10 Thread Lukas Slebodnik
On (10/11/15 08:59), Lukas Slebodnik wrote: >On (09/11/15 15:33), Jakub Hrozek wrote: >>On Mon, Nov 09, 2015 at 10:44:49AM +0100, Lukas Slebodnik wrote: >>> Obvious ACK >> >>While reviewing your patches, I found one more place I forgot to fix, >>see the attached patch. > >>From b275e167c4c802c838d8

Re: [SSSD] [PATCH] tools: Don't shadow 'exit'

2015-11-09 Thread Lukas Slebodnik
On (09/11/15 15:33), Jakub Hrozek wrote: >On Mon, Nov 09, 2015 at 10:44:49AM +0100, Lukas Slebodnik wrote: >> Obvious ACK > >While reviewing your patches, I found one more place I forgot to fix, >see the attached patch. >From b275e167c4c802c838d8b3d4d2d419e8af6fa99b Mon Sep 17 00:00:00 2001 >From:

Re: [SSSD] [PATCH] tools: Don't shadow 'exit'

2015-11-09 Thread Jakub Hrozek
On Mon, Nov 09, 2015 at 06:35:05PM +0100, Lukas Slebodnik wrote: > BTW which version do you prefer? > a) signl > b) sig > c) a_signal I don't care :) Feel free to use a_signal since it came first. ___ sssd-devel mailing list sssd-devel@lists.fedorahosted

Re: [SSSD] [PATCH] tools: Don't shadow 'exit'

2015-11-09 Thread Lukas Slebodnik
On (09/11/15 15:32), Jakub Hrozek wrote: >On Mon, Nov 09, 2015 at 12:05:34PM +0100, Lukas Slebodnik wrote: >> On (09/11/15 10:30), Jakub Hrozek wrote: >> >Hi, >> > >> >please see the attached trivial patch. >> >> >From a27bf8f594a372a4c324b00b7931306b774c Mon Sep 17 00:00:00 2001 >> >From: Jak

Re: [SSSD] [PATCH] tools: Don't shadow 'exit'

2015-11-09 Thread Jakub Hrozek
On Mon, Nov 09, 2015 at 10:44:49AM +0100, Lukas Slebodnik wrote: > Obvious ACK While reviewing your patches, I found one more place I forgot to fix, see the attached patch. >From b275e167c4c802c838d8b3d4d2d419e8af6fa99b Mon Sep 17 00:00:00 2001 From: Jakub Hrozek Date: Mon, 9 Nov 2015 10:27:41 +0

Re: [SSSD] [PATCH] tools: Don't shadow 'exit'

2015-11-09 Thread Jakub Hrozek
On Mon, Nov 09, 2015 at 12:05:34PM +0100, Lukas Slebodnik wrote: > On (09/11/15 10:30), Jakub Hrozek wrote: > >Hi, > > > >please see the attached trivial patch. > > >From a27bf8f594a372a4c324b00b7931306b774c Mon Sep 17 00:00:00 2001 > >From: Jakub Hrozek > >Date: Mon, 9 Nov 2015 10:27:41 +010

Re: [SSSD] [PATCH] tools: Don't shadow 'exit'

2015-11-09 Thread Jakub Hrozek
On Mon, Nov 09, 2015 at 12:05:34PM +0100, Lukas Slebodnik wrote: > On (09/11/15 10:30), Jakub Hrozek wrote: > >Hi, > > > >please see the attached trivial patch. > > >From a27bf8f594a372a4c324b00b7931306b774c Mon Sep 17 00:00:00 2001 > >From: Jakub Hrozek > >Date: Mon, 9 Nov 2015 10:27:41 +010

Re: [SSSD] [PATCH] tools: Don't shadow 'exit'

2015-11-09 Thread Lukas Slebodnik
On (09/11/15 10:30), Jakub Hrozek wrote: >Hi, > >please see the attached trivial patch. >From a27bf8f594a372a4c324b00b7931306b774c Mon Sep 17 00:00:00 2001 >From: Jakub Hrozek >Date: Mon, 9 Nov 2015 10:27:41 +0100 >Subject: [PATCH] tools: Don't shadow 'exit' >MIME-Version: 1.0 >Content-Type:

Re: [SSSD] [PATCH] tools: Don't shadow 'exit'

2015-11-09 Thread Lukas Slebodnik
On (09/11/15 10:30), Jakub Hrozek wrote: >Hi, > >please see the attached trivial patch. >From a27bf8f594a372a4c324b00b7931306b774c Mon Sep 17 00:00:00 2001 >From: Jakub Hrozek >Date: Mon, 9 Nov 2015 10:27:41 +0100 >Subject: [PATCH] tools: Don't shadow 'exit' >MIME-Version: 1.0 >Content-Type: