Re: [SSSD] [PATCHES] Fix assorted minor bugs found by Coverity

2010-06-10 Thread Sumit Bose
On Wed, Jun 09, 2010 at 12:21:15PM -0400, Stephen Gallagher wrote: On 06/09/2010 11:09 AM, Sumit Bose wrote: NACK, with this patch the backend returns with pd-pam_status not set. Please change it to something like: pd-pam_status = PAM_SYSTEM_ERR; ipa_auth_reply(be_req,

Re: [SSSD] [PATCHES] Fix assorted minor bugs found by Coverity

2010-06-10 Thread Stephen Gallagher
On 06/10/2010 05:48 AM, Sumit Bose wrote: ok ACK to this and to 0002-0008, too. Pushed all eight to master and sssd-1-2. -- Stephen Gallagher RHCE 804006346421761 Delivering value year after year. Red Hat ranks #1 in value among software vendors. http://www.redhat.com/promo/vendor/

Re: [SSSD] [PATCHES] Fix assorted minor bugs found by Coverity

2010-06-09 Thread Sumit Bose
On Wed, Jun 09, 2010 at 10:53:55AM -0400, Stephen Gallagher wrote: All patches apply to both master and sssd-1-2. ... From b21eecc180bb62f2783c50ebae30a20940636c8d Mon Sep 17 00:00:00 2001 From: Stephen Gallagher sgall...@redhat.com Date: Wed, 9 Jun 2010 09:44:47 -0400 Subject: [PATCH

Re: [SSSD] [PATCHES] Fix assorted minor bugs found by Coverity

2010-06-09 Thread Stephen Gallagher
On 06/09/2010 11:09 AM, Sumit Bose wrote: NACK, with this patch the backend returns with pd-pam_status not set. Please change it to something like: pd-pam_status = PAM_SYSTEM_ERR; ipa_auth_reply(be_req, DP_ERR_FATAL, pd-pam_status); and call pd =

Re: [SSSD] [PATCHES] Fix assorted minor bugs found by Coverity

2010-06-09 Thread Sumit Bose
On Wed, Jun 09, 2010 at 12:21:15PM -0400, Stephen Gallagher wrote: On 06/09/2010 11:09 AM, Sumit Bose wrote: NACK, with this patch the backend returns with pd-pam_status not set. Please change it to something like: pd-pam_status = PAM_SYSTEM_ERR; ipa_auth_reply(be_req,