Re: [SSSD] [PATCH] Allow arbitrary-length PAM messages

2010-03-25 Thread Sumit Bose
On Wed, Mar 24, 2010 at 06:56:10AM -0400, Stephen Gallagher wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 03/24/2010 06:49 AM, Stephen Gallagher wrote: On 03/23/2010 04:51 PM, Simo Sorce wrote: On Tue, 23 Mar 2010 16:38:57 -0400 Stephen Gallagher sgall...@redhat.com wrote:

[SSSD] [PATCH] Regression test against RHBZ #576856

2010-03-25 Thread Jakub Hrozek
From 12876ab2e79ac913229cf6ba40b504d863cb5193 Mon Sep 17 00:00:00 2001 From: Jakub Hrozek jhro...@redhat.com Date: Thu, 25 Mar 2010 15:10:56 +0100 Subject: [PATCH] Regression test against RHBZ #576856 --- src/providers/ipa/ipa_common.c |5 - src/providers/ipa/ipa_common.h |5 +

Re: [SSSD] [PATCH] Allow arbitrary-length PAM messages

2010-03-25 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 03/25/2010 09:56 AM, Sumit Bose wrote: NACK. Please consider the following two comments: - can you call free(user_msg) just after do_pam_conversation() to avoid to have it two times? - can you make buf in read_pipe_handler() a

[SSSD] [PATCH] Add krb5_kpasswd to IPA provider

2010-03-25 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 The krb5 options were out of sync, causing a runtime abort. This patch is slightly modified from the one attached to https://bugzilla.redhat.com/show_bug.cgi?id=576856 since that one only added the missing option and did not update the IPA_KRB5_OPTS

Re: [SSSD] [PATCH] path_utils improvements

2010-03-25 Thread John Dennis
On 03/19/2010 09:28 AM, Jakub Hrozek wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 These 3 patches add unit tests and convert documentation that was already present in the header file into doxygen format. The bugs found when adding the tests are fixed in a separate patch. John, I'm

Re: [SSSD] [PATCH] Fix LDAP search paths and other fixes for IPA

2010-03-25 Thread Sumit Bose
On Tue, Mar 16, 2010 at 11:55:23AM +0100, Sumit Bose wrote: Hi, the LDAP search paths in the IPA access modules currently will only work with single word domain names. This patch fixes this and adds some tests. bye, Sumit Hi, this is a new version of the patch where - the fixes to the

Re: [SSSD] [PATCH] Fix LDAP search paths and other fixes for IPA

2010-03-25 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 03/25/2010 11:57 AM, Sumit Bose wrote: On Tue, Mar 16, 2010 at 11:55:23AM +0100, Sumit Bose wrote: Hi, the LDAP search paths in the IPA access modules currently will only work with single word domain names. This patch fixes this and adds some

Re: [SSSD] [Transifex] File submitted via email to SSSD | Stable Branch (1.1.x)

2010-03-25 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 03/22/2010 04:31 PM, ad...@transifex.net wrote: Hello sssd, this is Transifex at http://www.transifex.net. The following attached files were submitted to SSSD | Stable Branch (1.1.x) by raven piotrd...@gmail.com Please, visit Transifex at

Re: [SSSD] [PATCH] Fix warnings from -Wmissing-field-initializers

2010-03-25 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 03/24/2010 08:41 AM, Jakub Hrozek wrote: On 03/24/2010 01:12 PM, Sumit Bose wrote: Hi, this patch fixes the warnings generated by -Wmissing-field-initializers by adding the missing elements. Please have a look at the changes to pysss.c

Re: [SSSD] [PATCH] Regression test against RHBZ #576856

2010-03-25 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 03/25/2010 10:30 AM, Stephen Gallagher wrote: On 03/25/2010 10:12 AM, Jakub Hrozek wrote: Ack. Pushed to master and 1-1-0 - -- Stephen Gallagher RHCE 804006346421761 Delivering value year after year. Red Hat ranks #1 in value among

Re: [SSSD] [PATCH] Add krb5_kpasswd to IPA provider

2010-03-25 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 03/25/2010 10:49 AM, Sumit Bose wrote: On Thu, Mar 25, 2010 at 10:33:11AM -0400, Stephen Gallagher wrote: The krb5 options were out of sync, causing a runtime abort. This patch is slightly modified from the one attached to

Re: [SSSD] [PATCH] path_utils improvements

2010-03-25 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 03/25/2010 11:20 AM, John Dennis wrote: On 03/19/2010 09:28 AM, Jakub Hrozek wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 These 3 patches add unit tests and convert documentation that was already present in the header file into

Re: [SSSD] [PATCH] Fix LDAP search paths and other fixes for IPA

2010-03-25 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 03/25/2010 12:08 PM, Stephen Gallagher wrote: On 03/25/2010 11:57 AM, Sumit Bose wrote: On Tue, Mar 16, 2010 at 11:55:23AM +0100, Sumit Bose wrote: Hi, the LDAP search paths in the IPA access modules currently will only work with single word

Re: [SSSD] [PATCH] Fix segfault in path_utils_ut

2010-03-25 Thread Jakub Hrozek
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 03/25/2010 08:41 PM, Stephen Gallagher wrote: These unit tests are paying off already. This segfault would have caused problems in libpath_utils. This patch also addresses a failure in path_split() to initialize a return value. ACK

Re: [SSSD] [PATCH] Fix segfault in path_utils_ut

2010-03-25 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 03/25/2010 03:51 PM, John Dennis wrote: On 03/25/2010 03:41 PM, Stephen Gallagher wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 These unit tests are paying off already. This segfault would have caused problems in libpath_utils. This

Re: [SSSD] [PATCH] Fix segfault in path_utils_ut

2010-03-25 Thread John Dennis
On 03/25/2010 03:53 PM, Stephen Gallagher wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 03/25/2010 03:51 PM, John Dennis wrote: On 03/25/2010 03:41 PM, Stephen Gallagher wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 These unit tests are paying off already. This segfault

Re: [SSSD] [PATCH] Fix segfault in path_utils_ut

2010-03-25 Thread John Dennis
On 03/25/2010 03:41 PM, Stephen Gallagher wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 These unit tests are paying off already. This segfault would have caused problems in libpath_utils. This patch also addresses a failure in path_split() to initialize a return value. Very Good.

Re: [SSSD] [PATCH] path_utils improvements

2010-03-25 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 03/25/2010 12:16 PM, Stephen Gallagher wrote: On 03/25/2010 11:20 AM, John Dennis wrote: On 03/19/2010 09:28 AM, Jakub Hrozek wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 These 3 patches add unit tests and convert documentation that

Re: [SSSD] Design proposal about INI interface improvements

2010-03-25 Thread Simo Sorce
On Thu, 25 Mar 2010 18:12:13 -0400 Dmitri Pal d...@redhat.com wrote: Dmitri Pal wrote: Hi, Currently the INI interface includes the following functions: int config_from_file (const char *application, const char *config_filename, struct collection_item **ini_config, int error_level,