Re: [SSSD] [PATCH] Properly handle read() and write() throughout the SSSD

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 06/09/2010 03:18 PM, Stephen Gallagher wrote: I'm attaching a second patch to handle this, as errno is misused throughout that entire file. This patch applies atop the read/write patch. Ack, but before pushing, please fix style issues in the

Re: [SSSD] [PATCHES] Fix assorted minor bugs found by Coverity

On Wed, Jun 09, 2010 at 12:21:15PM -0400, Stephen Gallagher wrote: On 06/09/2010 11:09 AM, Sumit Bose wrote: NACK, with this patch the backend returns with pd-pam_status not set. Please change it to something like: pd-pam_status = PAM_SYSTEM_ERR; ipa_auth_reply(be_req,

[SSSD] [PATCH] Save all data to sysdb in one transaction

Hi, this patch for master saves all IPA HBAC data in one transaction and proceeds if the sysdb transaction fails. It addresses a review comment from the Use new schema for HBAC service checks patch. The first patch changes the handling of the host data to be compatible with the other data. The

Re: [SSSD] [PATCH] Save all data to sysdb in one transaction

On 06/10/2010 05:56 AM, Sumit Bose wrote: Hi, this patch for master saves all IPA HBAC data in one transaction and proceeds if the sysdb transaction fails. It addresses a review comment from the Use new schema for HBAC service checks patch. The first patch changes the handling of the host

Re: [SSSD] [PATCH] [INI] Memory leak in case of empty value

On 06/10/2010 09:44 AM, Stephen Gallagher wrote: On 06/09/2010 04:30 PM, Dmitri Pal wrote: Stephen Gallagher wrote: On 06/09/2010 04:11 PM, Dmitri Pal wrote: Fixes #513. Thanks to Steve for helping to find it! Could not see it myself. Nack. Please address warning: CC

Re: [SSSD] [PATCH] [INI] Fixing NULL dereferencing in ini_config

On 06/09/2010 04:14 PM, Stephen Gallagher wrote: On 06/09/2010 02:30 PM, Dmitri Pal wrote: Fixes #504 Ack. Addendum: this patch only applies cleanly on sssd-1-2. Please rebase and resubmit a version of this patch that applies cleanly on master. -- Stephen Gallagher RHCE 804006346421761

Re: [SSSD] [PATCHES] Fix assorted minor bugs found by Coverity

On 06/10/2010 05:48 AM, Sumit Bose wrote: ok ACK to this and to 0002-0008, too. Pushed all eight to master and sssd-1-2. -- Stephen Gallagher RHCE 804006346421761 Delivering value year after year. Red Hat ranks #1 in value among software vendors. http://www.redhat.com/promo/vendor/

Re: [SSSD] [PATCH] [INI] Memory leak in case of empty value

On 06/10/2010 09:44 AM, Stephen Gallagher wrote: On 06/09/2010 04:30 PM, Dmitri Pal wrote: Stephen Gallagher wrote: On 06/09/2010 04:11 PM, Dmitri Pal wrote: Fixes #513. Thanks to Steve for helping to find it! Could not see it myself. Nack. Please address warning: CC

Re: [SSSD] [PATCH] [INI] Fixing NULL dereferencing in ini_config

On 06/09/2010 04:14 PM, Stephen Gallagher wrote: On 06/09/2010 02:30 PM, Dmitri Pal wrote: Fixes #504 Ack. Pushed to sssd-1-2. -- Stephen Gallagher RHCE 804006346421761 Delivering value year after year. Red Hat ranks #1 in value among software vendors. http://www.redhat.com/promo/vendor/

Re: [SSSD] [PATCH] Properly handle read() and write() throughout the SSSD

On 06/10/2010 05:43 AM, Jakub Hrozek wrote: On 06/09/2010 03:18 PM, Stephen Gallagher wrote: I'm attaching a second patch to handle this, as errno is misused throughout that entire file. This patch applies atop the read/write patch. Ack, but before pushing, please fix style issues in the

Re: [SSSD] [PATCH] [COLLECTION] Addressing initialization issues

On 06/09/2010 04:14 PM, Stephen Gallagher wrote: On 06/09/2010 02:07 PM, Dmitri Pal wrote: Fixes #519 Ack. Pushed to master and sssd-1-2. ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org

Re: [SSSD] [PATCH] [INI] Memory leak in case of empty value

Dmitri Pal wrote: Stephen Gallagher wrote: On 06/10/2010 09:44 AM, Stephen Gallagher wrote: On 06/09/2010 04:30 PM, Dmitri Pal wrote: Stephen Gallagher wrote: On 06/09/2010 04:11 PM, Dmitri Pal wrote: Fixes #513. Thanks

[SSSD] [PATCH] Don't segfault if ldap_access_filter is unspecified

Coverity caught another potential segfault. This one would be highly-visible. See https://fedorahosted.org/sssd/ticket/493 -- Stephen Gallagher RHCE 804006346421761 Delivering value year after year. Red Hat ranks #1 in value among software vendors. http://www.redhat.com/promo/vendor/ From

Re: [SSSD] [PATCH] Don't segfault if ldap_access_filter is unspecified

On 06/10/2010 01:04 PM, Stephen Gallagher wrote: Coverity caught another potential segfault. This one would be highly-visible. See https://fedorahosted.org/sssd/ticket/493 Sorry, that referenced the wrong ticket. Correct ticket is https://fedorahosted.org/sssd/ticket/539 Updated patch

[SSSD] [PATCH] Assorted patches for Coverity issues

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 All of these patches apply on top of both master and 1-2. I'll send the ones that are different separately. -BEGIN PGP SIGNATURE- Version: GnuPG v2.0.14 (GNU/Linux) Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/

[SSSD] [PATCH] Fix invalid talloc_move in groupshow

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 This patch applies to 1.2 only -BEGIN PGP SIGNATURE- Version: GnuPG v2.0.14 (GNU/Linux) Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/ iEYEARECAAYFAkwRL/4ACgkQHsardTLnvCUQiQCfaOectlH2rw9kWLStorgVv4jP

[SSSD] [PATCH] Remove the -g option from useradd

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 When working on #522 I realized that since the local domain is now MPG-only, it doesn't make sense to offer an option to set the primary GID different than UID. The attached two patches for 1.2 and master remove the -g option altogether. -BEGIN

[SSSD] [PATCH] Remove the krb5_changepw_principal option

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 For 1.2 just undocument it, remove it altogether for master. Fixes: #531 -BEGIN PGP SIGNATURE- Version: GnuPG v2.0.14 (GNU/Linux) Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/

Re: [SSSD] [PATCH] Assorted patches for Coverity issues

On 06/10/2010 02:33 PM, Jakub Hrozek wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 All of these patches apply on top of both master and 1-2. I'll send the ones that are different separately. Ack to all four. -- Stephen Gallagher RHCE 804006346421761 Delivering value year after

Re: [SSSD] [PATCH] Remove the krb5_changepw_principal option

On Thu, 10 Jun 2010 20:34:13 +0200 Jakub Hrozek jhro...@redhat.com wrote: +#define SSSD_KRB5_CHANGEPW_PRINCIPLE SSSD_KRB5_CHANGEPW_PRINCIPLE + shouldn't this be: kadmin/changepw ? struct krb5_child_ctx { /* opts taken from kinit */ /* in seconds */ @@ -63,7 +65,6 @@ struct

Re: [SSSD] [PATCH] Fix invalid talloc_move in groupshow

On 06/10/2010 02:33 PM, Jakub Hrozek wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 This patch applies to 1.2 only Ack. -- Stephen Gallagher RHCE 804006346421761 Delivering value year after year. Red Hat ranks #1 in value among software vendors. http://www.redhat.com/promo/vendor/

Re: [SSSD] [PATCH] Remove the -g option from useradd

On 06/10/2010 02:33 PM, Jakub Hrozek wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 When working on #522 I realized that since the local domain is now MPG-only, it doesn't make sense to offer an option to set the primary GID different than UID. The attached two patches for 1.2 and