[SSSD] [sssd PR#139][comment] Initial revision of sssd pytest framework

2017-02-06 Thread mrniranjan
URL: https://github.com/SSSD/sssd/pull/139 Title: #139: Initial revision of sssd pytest framework mrniranjan commented: """ I will submit the changes (i.e fixing the pep8 and pylint errors), I am awaiting the changes to be merged downstream first. """ See the full comment at

[SSSD] [sssd PR#141][comment] PAM: Use cache_req to perform initgroups lookups

2017-02-06 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/141 Title: #141: PAM: Use cache_req to perform initgroups lookups fidencio commented: """ @pbrezina, commits are ready to be reviewed. @spbnick, you're not (totally) blocked anymore. """ See the full comment at

[SSSD] [sssd PR#141][edited] PAM: Use cache_req to perform initgroups lookups

2017-02-06 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/141 Author: fidencio Title: #141: PAM: Use cache_req to perform initgroups lookups Action: edited Changed field: title Original value: """ PAM: Use cache_req_user_by_name_*() """ ___ sssd-devel mailing list

[SSSD] Re: Avoid running two instances of the same service (#3300)

2017-02-06 Thread Fabiano FidĂȘncio
On Sun, Feb 5, 2017 at 11:24 PM, Fabiano FidĂȘncio wrote: > I've spent some amount of time trying to properly deal with this issue > and I really need the opinion/suggestion of more experienced > developers. > > Basically, as explained in #3300 this situation can happen is two

[SSSD] [sssd PR#141][synchronized] PAM: Use cache_req_user_by_name_*()

2017-02-06 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/141 Author: fidencio Title: #141: PAM: Use cache_req_user_by_name_*() Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/141/head:pr141 git checkout pr141 From

[SSSD] [sssd PR#141][edited] PAM: Use cache_req to perform initgroups lookups

2017-02-06 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/141 Author: fidencio Title: #141: PAM: Use cache_req to perform initgroups lookups Action: edited Changed field: body Original value: """ PAM responder has been already using a lot from cache_req and one of the missing parts (most likely the only one?)

[SSSD] [sssd PR#141][-Changes requested] PAM: Use cache_req to perform initgroups lookups

2017-02-06 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/141 Title: #141: PAM: Use cache_req to perform initgroups lookups Label: -Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#112][comment] FAILOVER: Improve port status log messages

2017-02-06 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/112 Title: #112: FAILOVER: Improve port status log messages jhrozek commented: """ * master: 1c7f9a676088ecee4c14df14b8688b391fb32a05 """ See the full comment at https://github.com/SSSD/sssd/pull/112#issuecomment-277713445

[SSSD] [sssd PR#112][-Accepted] FAILOVER: Improve port status log messages

2017-02-06 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/112 Title: #112: FAILOVER: Improve port status log messages Label: -Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#112][+Pushed] FAILOVER: Improve port status log messages

2017-02-06 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/112 Title: #112: FAILOVER: Improve port status log messages Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#112][closed] FAILOVER: Improve port status log messages

2017-02-06 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/112 Author: justin-stephenson Title: #112: FAILOVER: Improve port status log messages Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/112/head:pr112 git checkout pr112

[SSSD] [sssd PR#127][+Changes requested] ssh: use cache_req

2017-02-06 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/127 Title: #127: ssh: use cache_req Label: +Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#127][comment] ssh: use cache_req

2017-02-06 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/127 Title: #127: ssh: use cache_req jhrozek commented: """ I'm afraid this is still not fixed correctly. Please check this gdb session when I requested an IPA host with a default_domain_suffix pointing to a Windows domain: ``` 0x7f0a1cc0d543 in

[SSSD] [sssd PR#137][comment] Initial pkinit support

2017-02-06 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/137 Title: #137: Initial pkinit support jhrozek commented: """ pam_srv_test doesn't like being run under valgrind: http://sssd-ci.duckdns.org/logs/job/61/71/rhel7/ci-build-debug/ci-make-check-valgrind.log """ See the full comment at

[SSSD] [sssd PR#138][comment] IPA: Skip conflict entries associated with sudo rules

2017-02-06 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/138 Title: #138: IPA: Skip conflict entries associated with sudo rules jhrozek commented: """ I also ran IPA upstream automated tests in addition to some manual testing and no new regressions were found -> ACK Thank you for the patch! """ See the full

[SSSD] [sssd PR#138][+Accepted] IPA: Skip conflict entries associated with sudo rules

2017-02-06 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/138 Title: #138: IPA: Skip conflict entries associated with sudo rules Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#137][comment] Initial pkinit support

2017-02-06 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/137 Title: #137: Initial pkinit support jhrozek commented: """ There are some Coverity warnings: ``` Error: UNINIT (CWE-457): sssd-1.15.1/src/p11_child/p11_child_nss.c:112: var_decl: Declaring variable "key_id_str" without initializer.

[SSSD] [sssd PR#138][-Changes requested] IPA: Skip conflict entries associated with sudo rules

2017-02-06 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/138 Title: #138: IPA: Skip conflict entries associated with sudo rules Label: -Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#143][synchronized] Explicitly add ordering dependency for the responders' sockets

2017-02-06 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/143 Author: fidencio Title: #143: Explicitly add ordering dependency for the responders' sockets Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/143/head:pr143 git checkout pr143

[SSSD] [sssd PR#147][opened] IFP: Update ifp_iface_generated.c

2017-02-06 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/147 Author: fidencio Title: #147: IFP: Update ifp_iface_generated.c Action: opened PR body: """ These changes are leftovers from commit 78b4b7e. """ To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd

[SSSD] [sssd PR#143][edited] Explicitly add ordering dependency for the responders' sockets

2017-02-06 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/143 Author: fidencio Title: #143: Explicitly add ordering dependency for the responders' sockets Action: edited Changed field: body Original value: """ While debugging the whole breakage reported by Stric I've noticed that the NSS socket has been

[SSSD] [sssd PR#143][synchronized] Explicitly add ordering dependency for the responders' sockets

2017-02-06 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/143 Author: fidencio Title: #143: Explicitly add ordering dependency for the responders' sockets Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/143/head:pr143 git checkout pr143

[SSSD] [sssd PR#146][opened] Avoid running two instances of the same service

2017-02-06 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/146 Author: fidencio Title: #146: Avoid running two instances of the same service Action: opened PR body: """ Those two patches together are responsible for avoiding running two "instances" of the same service. The commit message of each patch has

[SSSD] [sssd PR#146][comment] Avoid running two instances of the same service

2017-02-06 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/146 Title: #146: Avoid running two instances of the same service fidencio commented: """ Ah, an important and obvious note ... of course I'm okay re-writing the second patch to use DBus instead of sd-bus, in case it's required by the reviewers. """ See

[SSSD] [sssd PR#145][comment] Fix storing a sudoRule attriubute in a case-insensitive domain when the attriubute values differ only by case

2017-02-06 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/145 Title: #145: Fix storing a sudoRule attriubute in a case-insensitive domain when the attriubute values differ only by case jhrozek commented: """ Yes, both cases should be added. The change of behaviour is the duplicate detection -- even the previous