URL: https://github.com/SSSD/sssd/pull/148
Title: #148: SYSTEMD: Update journald drop-in file
Label: +Changes requested
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to
URL: https://github.com/SSSD/sssd/pull/139
Title: #139: Initial revision of sssd pytest framework
lslebodn commented:
"""
On (03/02/17 00:39), Jakub Hrozek wrote:
>On Thu, Feb 02, 2017 at 12:48:11PM -0800, lslebodn wrote:
>> On (02/02/17 08:33), Jakub Hrozek wrote:
>> >On Thu, Feb 02, 2017 at
URL: https://github.com/SSSD/sssd/pull/148
Title: #148: SYSTEMD: Update journald drop-in file
fidencio commented:
"""
Patch looks fine.
May I ask why the type notify required interactive mode? Would make sense to
also add the explanation to the commit message?
Patch is good to go, but I'm
URL: https://github.com/SSSD/sssd/pull/141
Title: #141: PAM: Use cache_req to perform initgroups lookups
fidencio commented:
"""
CI: http://sssd-ci.duckdns.org/logs/job/61/72/summary.html
"""
See the full comment at
https://github.com/SSSD/sssd/pull/141#issuecomment-277927439
URL: https://github.com/SSSD/sssd/pull/148
Author: lslebodn
Title: #148: SYSTEMD: Update journald drop-in file
Action: opened
PR body:
"""
We changed type forking into type notify as part of commit
d4063e9a21a4e203bee7e0a0144fa8cabb14cc46.
But we forgot to update template drop-in file for
URL: https://github.com/SSSD/sssd/pull/127
Title: #127: ssh: use cache_req
pbrezina commented:
"""
Try now.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/127#issuecomment-277965152
___
sssd-devel mailing list --
URL: https://github.com/SSSD/sssd/pull/139
Title: #139: Initial revision of sssd pytest framework
jhrozek commented:
"""
On Tue, Feb 07, 2017 at 12:50:23AM -0800, lslebodn wrote:
> On (03/02/17 00:39), Jakub Hrozek wrote:
> >On Thu, Feb 02, 2017 at 12:48:11PM -0800, lslebodn wrote:
> >> On
URL: https://github.com/SSSD/sssd/pull/127
Title: #127: ssh: use cache_req
jhrozek commented:
"""
On Tue, Feb 07, 2017 at 02:56:00AM -0800, Pavel Březina wrote:
> Try now.
thanks, that case is now fixed. I'll run a couple of more tests before
acking.
"""
See the full comment at
On Tue, Feb 7, 2017 at 12:20 PM, Pavel Březina wrote:
> On 02/05/2017 11:24 PM, Fabiano Fidêncio wrote:
>>
>> I've spent some amount of time trying to properly deal with this issue
>> and I really need the opinion/suggestion of more experienced
>> developers.
>
>
> Hi, I'm
URL: https://github.com/SSSD/sssd/pull/148
Title: #148: SYSTEMD: Update journald drop-in file
Label: -Changes requested
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to
URL: https://github.com/SSSD/sssd/pull/149
Author: jhrozek
Title: #149: Fix subdomain discovery if sssd.conf domain name is different
from joined domain name
Action: opened
PR body:
"""
Please see the commit message for problem description and a way to reproduce
the issue.
"""
To pull the
On 02/05/2017 11:24 PM, Fabiano Fidêncio wrote:
I've spent some amount of time trying to properly deal with this issue
and I really need the opinion/suggestion of more experienced
developers.
Hi, I'm not sure I understand it correctly so let us clarify it.
Basically, as explained in #3300
URL: https://github.com/SSSD/sssd/pull/149
Title: #149: Fix subdomain discovery if sssd.conf domain name is different from
joined domain name
Label: +Accepted
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an
URL: https://github.com/SSSD/sssd/pull/147
Title: #147: IFP: Update ifp_iface_generated.c
pbrezina commented:
"""
Ack to the patch.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/147#issuecomment-277976661
___
sssd-devel mailing list
URL: https://github.com/SSSD/sssd/pull/147
Title: #147: IFP: Update ifp_iface_generated.c
pbrezina commented:
"""
Interesting, we must have some bug in sbus codegen since it doesn't get removed
in my tree. I remember a ticket when sbus_codegen seemed to be randomly
generated different code
URL: https://github.com/SSSD/sssd/pull/145
Title: #145: Fix storing a sudoRule attriubute in a case-insensitive domain
when the attriubute values differ only by case
fidencio commented:
"""
ACK from me.
But, please, wait till @pbrezina's reaction to your comment before pushing.
(and that's
URL: https://github.com/SSSD/sssd/pull/85
Title: #85: SYSDB: Removing of sysdb_try_to_find_expected_dn()
Label: +Accepted
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to
URL: https://github.com/SSSD/sssd/pull/85
Title: #85: SYSDB: Removing of sysdb_try_to_find_expected_dn()
jhrozek commented:
"""
If @sumit-bose agrees the use-case he brought up in one of the previous
comments is covered, then I think the patches can be pushed. I tested the
following cases:
-
URL: https://github.com/SSSD/sssd/pull/145
Title: #145: Fix storing a sudoRule attriubute in a case-insensitive domain
when the attriubute values differ only by case
pbrezina commented:
"""
I don't remember the code now, but does this still obey case sensitivity
setting?
"""
See the full
URL: https://github.com/SSSD/sssd/pull/145
Title: #145: Fix storing a sudoRule attriubute in a case-insensitive domain
when the attriubute values differ only by case
jhrozek commented:
"""
check the body of sysdb_sudo_add_lowered_users -- it just returns with EOK if
the domain is supposed to
URL: https://github.com/SSSD/sssd/pull/147
Author: fidencio
Title: #147: IFP: Update ifp_iface_generated.c
Action: closed
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/147/head:pr147
git checkout pr147
URL: https://github.com/SSSD/sssd/pull/147
Title: #147: IFP: Update ifp_iface_generated.c
Label: +Pushed
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
URL: https://github.com/SSSD/sssd/pull/148
Title: #148: SYSTEMD: Update journald drop-in file
Label: +Accepted
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
URL: https://github.com/SSSD/sssd/pull/147
Title: #147: IFP: Update ifp_iface_generated.c
pbrezina commented:
"""
Please figure out why sbus codegen didn't remove this code instead of removing
it manually.
"""
See the full comment at
URL: https://github.com/SSSD/sssd/pull/144
Title: #144: SSSD does not start if using only the local provider and services
line is empty
pbrezina commented:
"""
@fidencio go with these patches, that is why I created a new ticket for dummy
provider
@lslebodn with files provider I believe we can
URL: https://github.com/SSSD/sssd/pull/147
Title: #147: IFP: Update ifp_iface_generated.c
fidencio commented:
"""
@pbrezina, may I ask you to open a ticket for this issue?
It has to be fixed in the (near) future.
"""
See the full comment at
URL: https://github.com/SSSD/sssd/pull/148
Title: #148: SYSTEMD: Update journald drop-in file
lslebodn commented:
"""
Because `man 5 systemd.service` says that.:
```
Behavior of notify is similar to simple; however, it is expected
that the daemon sends a notification message
URL: https://github.com/SSSD/sssd/pull/147
Title: #147: IFP: Update ifp_iface_generated.c
fidencio commented:
"""
Pavel,
I didn't remove the code manually. I've noticed this file changed after
building the project.
"""
See the full comment at
URL: https://github.com/SSSD/sssd/pull/144
Title: #144: SSSD does not start if using only the local provider and services
line is empty
pbrezina commented:
"""
In general, I think we should finally create a dummy local provider so we can
avoid special casing it all the time. I created a
URL: https://github.com/SSSD/sssd/pull/141
Title: #141: PAM: Use cache_req to perform initgroups lookups
pbrezina commented:
"""
Ack from me. Can someone else do review as well since I was helping Fabiano
with those patches?
"""
See the full comment at
On Tue, Feb 7, 2017 at 12:58 PM, Pavel Březina wrote:
> On 02/07/2017 12:31 PM, Fabiano Fidêncio wrote:
>>
>> On Tue, Feb 7, 2017 at 12:20 PM, Pavel Březina
>> wrote:
>>>
>>> On 02/05/2017 11:24 PM, Fabiano Fidêncio wrote:
I've spent some
URL: https://github.com/SSSD/sssd/pull/147
Title: #147: IFP: Update ifp_iface_generated.c
lslebodn commented:
"""
On (07/02/17 03:50), Pavel Březina wrote:
>Interesting, we must have some bug in sbus codegen since it doesn't get
>removed in my tree. I remember a ticket when sbus_codegen seemed
URL: https://github.com/SSSD/sssd/pull/108
Title: #108: Partially revert "CONFIG: Use default config when none provided"
Label: +Accepted
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to
URL: https://github.com/SSSD/sssd/pull/108
Title: #108: Partially revert "CONFIG: Use default config when none provided"
jhrozek commented:
"""
I'm sorry it took so long to review this PR. I agree with the patch so I'm
adding Accepted. The use-case of sssd being not configured at all will be
URL: https://github.com/SSSD/sssd/pull/144
Title: #144: SSSD does not start if using only the local provider and services
line is empty
lslebodn commented:
"""
On (07/02/17 03:46), fidencio wrote:
>Just to clarify, do you think we should go for the dummy local provider
>instead of this patch
URL: https://github.com/SSSD/sssd/pull/144
Title: #144: SSSD does not start if using only the local provider and services
line is empty
fidencio commented:
"""
Just to clarify, do you think we should go for the dummy local provider instead
of this patch series? Or that we should also go for
On 02/07/2017 12:31 PM, Fabiano Fidêncio wrote:
On Tue, Feb 7, 2017 at 12:20 PM, Pavel Březina wrote:
On 02/05/2017 11:24 PM, Fabiano Fidêncio wrote:
I've spent some amount of time trying to properly deal with this issue
and I really need the opinion/suggestion of more
URL: https://github.com/SSSD/sssd/pull/147
Title: #147: IFP: Update ifp_iface_generated.c
lslebodn commented:
"""
master:
* 2ddcd5785f10de42bf03dfc36eca94dbc1fc1fb3
LS
"""
See the full comment at
https://github.com/SSSD/sssd/pull/147#issuecomment-277980195
URL: https://github.com/SSSD/sssd/pull/85
Title: #85: SYSDB: Removing of sysdb_try_to_find_expected_dn()
sumit-bose commented:
"""
I'm fine with the patches, please go ahead.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/85#issuecomment-277989609
URL: https://github.com/SSSD/sssd/pull/138
Title: #138: IPA: Skip conflict entries associated with sudo rules
lslebodn commented:
"""
The first two matches need to be squashed otherwise it would break possibility
to use git bisect
```
./src/providers/ipa/ipa_sudo_conversion.c: In function
URL: https://github.com/SSSD/sssd/pull/138
Title: #138: IPA: Skip conflict entries associated with sudo rules
Label: -Accepted
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to
URL: https://github.com/SSSD/sssd/pull/108
Author: lslebodn
Title: #108: Partially revert "CONFIG: Use default config when none provided"
Action: closed
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/108/head:pr108
git checkout pr108
URL: https://github.com/SSSD/sssd/pull/108
Title: #108: Partially revert "CONFIG: Use default config when none provided"
Label: +Pushed
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to
URL: https://github.com/SSSD/sssd/pull/148
Title: #148: SYSTEMD: Update journald drop-in file
lslebodn commented:
"""
master:
* 7b4704a10958bb7d3390db9eff863875d2b643f7
sssd-1-14:
* 14fe5a922c07da4c95feb65d1455d7f89d9e0f86
sssd-1-13:
* 5e8474c2dc38c6c2e148db0d8ea9814bc6d5f275
LS
"""
See
URL: https://github.com/SSSD/sssd/pull/144
Title: #144: SSSD does not start if using only the local provider and services
line is empty
fidencio commented:
"""
You did not mention anything in your comment, @lslebodn. While @pbrezina said
"go with these patches".
I personally don't agree on
URL: https://github.com/SSSD/sssd/pull/146
Title: #146: Avoid running two instances of the same service
pbrezina commented:
"""
Please, stick with sbus code and do not use sdbus. We are at a point where we
have internal higher level api to create send and parse dbus message, all
talloc
URL: https://github.com/SSSD/sssd/pull/147
Title: #147: IFP: Update ifp_iface_generated.c
pbrezina commented:
"""
When I explicitly touch ifp_iface.xml it gets regenerated correctly... but why
wasn't it back at the time?
"""
See the full comment at
URL: https://github.com/SSSD/sssd/pull/144
Title: #144: SSSD does not start if using only the local provider and services
line is empty
Label: -Accepted
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to
URL: https://github.com/SSSD/sssd/pull/144
Title: #144: SSSD does not start if using only the local provider and services
line is empty
lslebodn commented:
"""
My intention was to wait for files provider and drop this PR.
But maybe I misunderstood something
"""
See the full comment at
URL: https://github.com/SSSD/sssd/pull/144
Title: #144: SSSD does not start if using only the local provider and services
line is empty
fidencio commented:
"""
You did not mention anything in your comment, @lslebodn. While @pbrezina said
"go with these patches".
I personally don't agree on
URL: https://github.com/SSSD/sssd/pull/144
Title: #144: SSSD does not start if using only the local provider and services
line is empty
lslebodn commented:
"""
My intention was to wait for files provider and drop this PR.
But maybe I misunderstood something
"""
See the full comment at
URL: https://github.com/SSSD/sssd/pull/146
Title: #146: Avoid running two instances of the same service
Label: +Changes requested
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to
URL: https://github.com/SSSD/sssd/pull/144
Title: #144: SSSD does not start if using only the local provider and services
line is empty
Label: +Accepted
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to
URL: https://github.com/SSSD/sssd/pull/108
Title: #108: Partially revert "CONFIG: Use default config when none provided"
lslebodn commented:
"""
master:
* c029f707d4847b01ff64bf3bb1fd46c0b5927cdb
sssd-1-14:
* 21fad04b58ce1e4502e37a3855412b15a1fbbad6
LS
"""
See the full comment at
URL: https://github.com/SSSD/sssd/pull/127
Title: #127: ssh: use cache_req
Label: +Accepted
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
URL: https://github.com/SSSD/sssd/pull/127
Title: #127: ssh: use cache_req
Label: -Changes requested
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
URL: https://github.com/SSSD/sssd/pull/138
Title: #138: IPA: Skip conflict entries associated with sudo rules
Label: +Changes requested
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to
URL: https://github.com/SSSD/sssd/pull/148
Author: lslebodn
Title: #148: SYSTEMD: Update journald drop-in file
Action: closed
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/148/head:pr148
git checkout pr148
URL: https://github.com/SSSD/sssd/pull/148
Title: #148: SYSTEMD: Update journald drop-in file
Label: +Pushed
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
URL: https://github.com/SSSD/sssd/pull/138
Title: #138: IPA: Skip conflict entries associated with sudo rules
justin-stephenson commented:
"""
Hi Lukas, I squashed the two patches together but now there is a check failing.
Could you help me understand if I am missing something?
"""
See the
URL: https://github.com/SSSD/sssd/pull/138
Title: #138: IPA: Skip conflict entries associated with sudo rules
lslebodn commented:
"""
That was just a problem with repositories otherwise installation of
dependencies would not fail.
```
install-deps: failure 00:00:30
URL: https://github.com/SSSD/sssd/pull/138
Title: #138: IPA: Skip conflict entries associated with sudo rules
Label: -Changes requested
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to
URL: https://github.com/SSSD/sssd/pull/138
Title: #138: IPA: Skip conflict entries associated with sudo rules
lslebodn commented:
"""
master:
* 1404f3aa541849d880cce591584ba1580014cb50
* d0aae3c1e87e2e51ab178b7b343261443094a974
sssd-1-14:
* db0c5135add7c93638794abd8c7f04a1c5d74186
*
URL: https://github.com/SSSD/sssd/pull/138
Title: #138: IPA: Skip conflict entries associated with sudo rules
Label: +Pushed
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to
URL: https://github.com/SSSD/sssd/pull/138
Author: justin-stephenson
Title: #138: IPA: Skip conflict entries associated with sudo rules
Action: closed
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/138/head:pr138
git checkout pr138
URL: https://github.com/SSSD/sssd/pull/146
Title: #146: Avoid running two instances of the same service
fidencio commented:
"""
@pbrezina: sticking with sbus code is not something that simple to do here and
I'll explain you the reasons.
The code flow is:
- for each of the responders
-
URL: https://github.com/SSSD/sssd/pull/138
Author: justin-stephenson
Title: #138: IPA: Skip conflict entries associated with sudo rules
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/138/head:pr138
git checkout pr138
67 matches
Mail list logo