[SSSD] [sssd PR#160][comment] Fix files provider reallocation logic

2017-02-22 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/160 Title: #160: Fix files provider reallocation logic pbrezina commented: """ `talloc_realloc` takes number of elements not the total size so ack. """ See the full comment at https://github.com/SSSD/sssd/pull/160#issuecomment-281609221

[SSSD] [sssd PR#66][+Pushed] Minor Dynamic DNS fixes

2017-02-22 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/66 Title: #66: Minor Dynamic DNS fixes Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#66][closed] Minor Dynamic DNS fixes

2017-02-22 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/66 Author: justin-stephenson Title: #66: Minor Dynamic DNS fixes Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/66/head:pr66 git checkout pr66

[SSSD] [sssd PR#66][comment] Minor Dynamic DNS fixes

2017-02-22 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/66 Title: #66: Minor Dynamic DNS fixes jhrozek commented: """ * master: * d694d4fdcc81f24c2f9e3bb5a0dbe0a52498f196 * fccd8f9ab7a0ac9868c43ea0e8c3af142b2809fa """ See the full comment at https://github.com/SSSD/sssd/pull/66#issuecomment-281643200

[SSSD] [sssd PR#70][comment] check_duplicate: check name member before using it

2017-02-22 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/70 Title: #70: check_duplicate: check name member before using it jhrozek commented: """ Actually, let's push this PR now, there is a test so we won't regress """ See the full comment at https://github.com/SSSD/sssd/pull/70#issuecomment-281643957

[SSSD] [sssd PR#70][+Pushed] check_duplicate: check name member before using it

2017-02-22 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/70 Title: #70: check_duplicate: check name member before using it Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#70][comment] check_duplicate: check name member before using it

2017-02-22 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/70 Title: #70: check_duplicate: check name member before using it jhrozek commented: """ master: 454cf0c3808a9f6a0c9f79e9796e17c58907ee6c 08bf6b4a281ef4308119dccbba4e86cf28b505d2 sssd-1-14:

[SSSD] [sssd PR#161][comment] pam_sss: check conversation callback

2017-02-22 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/161 Title: #161: pam_sss: check conversation callback pbrezina commented: """ Ack. """ See the full comment at https://github.com/SSSD/sssd/pull/161#issuecomment-281643799 ___ sssd-devel mailing list --

[SSSD] [sssd PR#161][+Accepted] pam_sss: check conversation callback

2017-02-22 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/161 Title: #161: pam_sss: check conversation callback Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#159][comment] pam: use authtok from PAM stack if available

2017-02-22 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/159 Title: #159: pam: use authtok from PAM stack if available pbrezina commented: """ Will this fix https://bugzilla.redhat.com/show_bug.cgi?id=1329598 ? """ See the full comment at https://github.com/SSSD/sssd/pull/159#issuecomment-281647271

[SSSD] [sssd PR#161][opened] pam_sss: check conversation callback

2017-02-22 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/161 Author: sumit-bose Title: #161: pam_sss: check conversation callback Action: opened PR body: """ With this patch pam_sss checks if a conversation callback is available before using it. Resolves https://fedorahosted.org/sssd/ticket/3296 There is

[SSSD] [sssd PR#155][+Pushed] MONITOR: Don't return an error in case we fail to register a service

2017-02-22 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/155 Title: #155: MONITOR: Don't return an error in case we fail to register a service Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#155][closed] MONITOR: Don't return an error in case we fail to register a service

2017-02-22 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/155 Author: fidencio Title: #155: MONITOR: Don't return an error in case we fail to register a service Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/155/head:pr155 git checkout

[SSSD] [sssd PR#155][comment] MONITOR: Don't return an error in case we fail to register a service

2017-02-22 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/155 Title: #155: MONITOR: Don't return an error in case we fail to register a service jhrozek commented: """ * master: 86bcc81a665dde4799d67ab7ea2bbd23608e7dab """ See the full comment at https://github.com/SSSD/sssd/pull/155#issuecomment-281663999

[SSSD] [sssd PR#155][-Accepted] MONITOR: Don't return an error in case we fail to register a service

2017-02-22 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/155 Title: #155: MONITOR: Don't return an error in case we fail to register a service Label: -Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#160][+Pushed] Fix files provider reallocation logic

2017-02-22 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/160 Title: #160: Fix files provider reallocation logic Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#160][closed] Fix files provider reallocation logic

2017-02-22 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/160 Author: jhrozek Title: #160: Fix files provider reallocation logic Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/160/head:pr160 git checkout pr160

[SSSD] [sssd PR#160][comment] Fix files provider reallocation logic

2017-02-22 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/160 Title: #160: Fix files provider reallocation logic jhrozek commented: """ * master: fc91d72f32660712f7c9e872e00deb91f188fea3 """ See the full comment at https://github.com/SSSD/sssd/pull/160#issuecomment-281655954

[SSSD] [sssd PR#162][opened] cache_req: use own namespace for UPNs

2017-02-22 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/162 Author: sumit-bose Title: #162: cache_req: use own namespace for UPNs Action: opened PR body: """ If the UPN use the same domain name as the configured domain an unsuccessful lookup by name will already create an entry in the negative cache. If the

[SSSD] [sssd PR#159][comment] pam: use authtok from PAM stack if available

2017-02-22 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/159 Title: #159: pam: use authtok from PAM stack if available sumit-bose commented: """ > Will this fix https://bugzilla.redhat.com/show_bug.cgi?id=1329598 ? Yes, if the control of the pam_unix auth is changed in authconfig as described above

[SSSD] [sssd PR#156][+Pushed] FILES: Remove unnecessary check

2017-02-22 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/156 Title: #156: FILES: Remove unnecessary check Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#156][comment] FILES: Remove unnecessary check

2017-02-22 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/156 Title: #156: FILES: Remove unnecessary check jhrozek commented: """ * master: 1f49be4429c17475b789e9089ce4d0ae48315e74 """ See the full comment at https://github.com/SSSD/sssd/pull/156#issuecomment-281666431

[SSSD] [sssd PR#156][closed] FILES: Remove unnecessary check

2017-02-22 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/156 Author: lslebodn Title: #156: FILES: Remove unnecessary check Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/156/head:pr156 git checkout pr156

[SSSD] [sssd PR#139][comment] Initial revision of sssd pytest framework

2017-02-22 Thread mrniranjan
URL: https://github.com/SSSD/sssd/pull/139 Title: #139: Initial revision of sssd pytest framework mrniranjan commented: """ @lslebodn @jhrozek i have an internal fix for pep8 and whitespaces, and also a lot of pylint fixes are pending internal review. i will try to send a revised patch by

[SSSD] [sssd PR#161][+Pushed] pam_sss: check conversation callback

2017-02-22 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/161 Title: #161: pam_sss: check conversation callback Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#161][closed] pam_sss: check conversation callback

2017-02-22 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/161 Author: sumit-bose Title: #161: pam_sss: check conversation callback Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/161/head:pr161 git checkout pr161

[SSSD] [sssd PR#161][comment] pam_sss: check conversation callback

2017-02-22 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/161 Title: #161: pam_sss: check conversation callback jhrozek commented: """ Fixed upstream: * master: 0965a77c4ff0b358d24582955cb7ae375ebaa0d2 * sssd-1-14: ba8e3f2850e5a328bc3e732b471280fc4fa49c53 * sssd-1-13: cc8c28ad26ae8dbd7e8bee1dee6d5439f2ee06fe

[SSSD] [sssd PR#156][comment] FILES: Remove unnecessary check

2017-02-22 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/156 Title: #156: FILES: Remove unnecessary check jhrozek commented: """ No, I meant the one in save_group, but you're right the check for \0 is strange. """ See the full comment at https://github.com/SSSD/sssd/pull/156#issuecomment-281665452

[SSSD] [sssd PR#137][+Changes requested] Initial pkinit support

2017-02-22 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/137 Title: #137: Initial pkinit support Label: +Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#163][opened] Enable the files domain for all sssd configurations

2017-02-22 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/163 Author: jhrozek Title: #163: Enable the files domain for all sssd configurations Action: opened PR body: """ This patch is a prerequisite for Fedora-26 feature: https://fedoraproject.org/wiki/Changes/SSSDCacheForLocalUsers Adds a new build-time

[SSSD] [sssd PR#164][opened] Remove unused import of run_shell from tests

2017-02-22 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/164 Author: jhrozek Title: #164: Remove unused import of run_shell from tests Action: opened PR body: """ None """ To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/164/head:pr164 git checkout pr164

[SSSD] [sssd PR#165][synchronized] selinux: Do not fail if SELinux is not managed

2017-02-22 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/165 Author: mzidek-rh Title: #165: selinux: Do not fail if SELinux is not managed Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/165/head:pr165 git checkout pr165 From

[SSSD] [sssd PR#165][comment] selinux: Do not fail if SELinux is not managed

2017-02-22 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/165 Title: #165: selinux: Do not fail if SELinux is not managed mzidek-rh commented: """ fixed a typo in commit message """ See the full comment at https://github.com/SSSD/sssd/pull/165#issuecomment-281760081

[SSSD] [sssd PR#165][opened] selinux: Do not fail if SELinux is not managed

2017-02-22 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/165 Author: mzidek-rh Title: #165: selinux: Do not fail if SELinux is not managed Action: opened PR body: """ Previously we failed if selinux_is_managed returned 0 or -1 (not managed or error). With this patch we only fail in case of error and continue

[SSSD] [sssd PR#165][comment] selinux: Do not fail if SELinux is not managed

2017-02-22 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/165 Title: #165: selinux: Do not fail if SELinux is not managed mzidek-rh commented: """ I did not test this last version yet, because I have some issues with my test environment, but very similar version worked for me :) . So feel free to test/review.

[SSSD] [sssd PR#166][edited] Please see the commit message for commit description.

2017-02-22 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/166 Author: jhrozek Title: #166: Please see the commit message for commit description. Action: edited Changed field: title Original value: """ Please see the commit message for commit description. """ ___

[SSSD] [sssd PR#137][comment] Initial pkinit support

2017-02-22 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/137 Title: #137: Initial pkinit support sumit-bose commented: """ Thank you for the rigid review, I've fixed the comments move some strucht members to a previous patch to not break the individual compilation. """ See the full comment at

[SSSD] [sssd PR#164][+Accepted] Remove unused import of run_shell from tests

2017-02-22 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/164 Title: #164: Remove unused import of run_shell from tests Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#164][comment] Remove unused import of run_shell from tests

2017-02-22 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/164 Title: #164: Remove unused import of run_shell from tests fidencio commented: """ Obvious ACK. Interesting that it's been there since forever. """ See the full comment at https://github.com/SSSD/sssd/pull/164#issuecomment-281760586

[SSSD] [sssd PR#137][comment] Initial pkinit support

2017-02-22 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/137 Title: #137: Initial pkinit support jhrozek commented: """ The patches work now, if the three small issues above and the individual compilation are addressed, I'll ack """ See the full comment at

[SSSD] [sssd PR#166][opened] Please see the commit message for commit description.

2017-02-22 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/166 Author: jhrozek Title: #166: Please see the commit message for commit description. Action: opened PR body: """ To reproduce, log in as a user from a trusted domain. Before the patch, you should see an error message about the domain not being found