[SSSD] [sssd PR#146][comment] Avoid running two instances of the same service

2017-03-02 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/146 Title: #146: Avoid running two instances of the same service jhrozek commented: """ The last version works for me. I tested: * no services line at all - I was allowed to start the socket * service present in the list - starting the socket failed *

[SSSD] [sssd PR#162][+Accepted] cache_req: use own namespace for UPNs

2017-03-02 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/162 Title: #162: cache_req: use own namespace for UPNs Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#146][comment] Avoid running two instances of the same service

2017-03-02 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/146 Title: #146: Avoid running two instances of the same service jhrozek commented: """ CI: http://sssd-ci.duckdns.org/logs/job/63/63/summary.html ACK """ See the full comment at https://github.com/SSSD/sssd/pull/146#issuecomment-283618180

[SSSD] [sssd PR#159][+Accepted] pam: use authtok from PAM stack if available

2017-03-02 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/159 Title: #159: pam: use authtok from PAM stack if available Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#159][comment] pam: use authtok from PAM stack if available

2017-03-02 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/159 Title: #159: pam: use authtok from PAM stack if available pbrezina commented: """ Ack. """ See the full comment at https://github.com/SSSD/sssd/pull/159#issuecomment-283621166 ___ sssd-devel mailing list --

[SSSD] [sssd PR#159][comment] pam: use authtok from PAM stack if available

2017-03-02 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/159 Title: #159: pam: use authtok from PAM stack if available lslebodn commented: """ On (02/03/17 02:51), Pavel Březina wrote: >Ack. > master: * 6dd271fdcf6ceb0afd77e703c98897672da3671a Do you patch also into oder branches? LS """ See the full

[SSSD] [sssd PR#162][comment] cache_req: use own namespace for UPNs

2017-03-02 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/162 Title: #162: cache_req: use own namespace for UPNs pbrezina commented: """ Ack. """ See the full comment at https://github.com/SSSD/sssd/pull/162#issuecomment-283618437 ___ sssd-devel mailing list --

[SSSD] [sssd PR#146][+Accepted] Avoid running two instances of the same service

2017-03-02 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/146 Title: #146: Avoid running two instances of the same service Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#175][opened] Add module for starting services

2017-03-02 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/175 Author: lslebodn Title: #175: Add module for starting services Action: opened PR body: """ This is a WIP version of reducing code duplication in our cwrap integration tests. I am still not sure whether we should also reuse function

[SSSD] [sssd PR#141][comment] PAM: Use cache_req to perform initgroups lookups

2017-03-02 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/141 Title: #141: PAM: Use cache_req to perform initgroups lookups jhrozek commented: """ CI: http://sssd-ci.duckdns.org/logs/job/63/64/summary.html (yes, I know we need to squash patches later and I'm running some manual tests, but so far so good) """

[SSSD] [sssd PR#141][comment] PAM: Use cache_req to perform initgroups lookups

2017-03-02 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/141 Title: #141: PAM: Use cache_req to perform initgroups lookups jhrozek commented: """ (this was for Jenkins, I don't know why the centos CI failed, so I'm just re-running it) """ See the full comment at

[SSSD] [sssd PR#146][synchronized] Avoid running two instances of the same service

2017-03-02 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/146 Author: fidencio Title: #146: Avoid running two instances of the same service Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/146/head:pr146 git checkout pr146 From

[SSSD] [sssd PR#146][comment] Avoid running two instances of the same service

2017-03-02 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/146 Title: #146: Avoid running two instances of the same service lslebodn commented: """ This version do not read config snippets. It was ok for python-sssdconfig because we decided to not support it there. Previously we plan to use `ExecStartPre` also

[SSSD] [sssd PR#152][comment] Add a tevent wrapper around libcurl's asynchronous interface

2017-03-02 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/152 Title: #152: Add a tevent wrapper around libcurl's asynchronous interface lslebodn commented: """ seems to work well with el7 http://sssd-ci.duckdns.org/logs/job/63/65/summary.html http://sssd-ci.duckdns.org/logs/job/63/66/summary.html LS """ See

[SSSD] [sssd PR#146][comment] Avoid running two instances of the same service

2017-03-02 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/146 Title: #146: Avoid running two instances of the same service lslebodn commented: """ On (02/03/17 04:41), fidencio wrote: >On Thu, Mar 2, 2017 at 1:32 PM, lslebodn wrote: > >> *@lslebodn* commented on this pull request. >>

[SSSD] [sssd PR#146][+Changes requested] Avoid running two instances of the same service

2017-03-02 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/146 Title: #146: Avoid running two instances of the same service Label: +Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#146][-Accepted] Avoid running two instances of the same service

2017-03-02 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/146 Title: #146: Avoid running two instances of the same service Label: -Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#177][opened] first letter of user name template for override_homedir

2017-03-02 Thread reguero
URL: https://github.com/SSSD/sssd/pull/177 Author: reguero Title: #177: first letter of user name template for override_homedir Action: opened PR body: """ This is needed in order to remap homedirs onto large filesystems such as AFS or EOS where there is a filesystem level with the first

[SSSD] [sssd PR#162][comment] cache_req: use own namespace for UPNs

2017-03-02 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/162 Title: #162: cache_req: use own namespace for UPNs lslebodn commented: """ On (02/03/17 02:39), Pavel Březina wrote: >Ack. > master: * 54039570d26e29444c398aa4ad6ba638f1713566 LS >-- >You are receiving this because you are subscribed to this thread.

[SSSD] [sssd PR#159][closed] pam: use authtok from PAM stack if available

2017-03-02 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/159 Author: sumit-bose Title: #159: pam: use authtok from PAM stack if available Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/159/head:pr159 git checkout pr159

[SSSD] [sssd PR#159][comment] pam: use authtok from PAM stack if available

2017-03-02 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/159 Title: #159: pam: use authtok from PAM stack if available lslebodn commented: """ On (02/03/17 02:51), Pavel Březina wrote: >Ack. > master: * 6dd271fdcf6ceb0afd77e703c98897672da3671a Do you patch also into oder branches? LS """ See the full

[SSSD] [sssd PR#159][+Pushed] pam: use authtok from PAM stack if available

2017-03-02 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/159 Title: #159: pam: use authtok from PAM stack if available Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#176][opened] Fix detecting UPN suffixes in IPA subdomain code

2017-03-02 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/176 Author: jhrozek Title: #176: Fix detecting UPN suffixes in IPA subdomain code Action: opened PR body: """ To reproduce, start with a fresh domain and attempt to log in as a user with an UPN suffix. """ To pull the PR as Git branch: git remote add

[SSSD] [sssd PR#162][closed] cache_req: use own namespace for UPNs

2017-03-02 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/162 Author: sumit-bose Title: #162: cache_req: use own namespace for UPNs Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/162/head:pr162 git checkout pr162

[SSSD] [sssd PR#162][+Pushed] cache_req: use own namespace for UPNs

2017-03-02 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/162 Title: #162: cache_req: use own namespace for UPNs Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#146][comment] Avoid running two instances of the same service

2017-03-02 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/146 Title: #146: Avoid running two instances of the same service fidencio commented: """ On Thu, Mar 2, 2017 at 1:32 PM, lslebodn wrote: > *@lslebodn* commented on this pull request. > -- > > In

[SSSD] [sssd PR#177][comment] first letter of user name template for override_homedir

2017-03-02 Thread centos-ci
URL: https://github.com/SSSD/sssd/pull/177 Title: #177: first letter of user name template for override_homedir centos-ci commented: """ Can one of the admins verify this patch? """ See the full comment at https://github.com/SSSD/sssd/pull/177#issuecomment-283660048

[SSSD] [sssd PR#146][synchronized] Avoid running two instances of the same service

2017-03-02 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/146 Author: fidencio Title: #146: Avoid running two instances of the same service Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/146/head:pr146 git checkout pr146 From

[SSSD] [sssd PR#177][comment] first letter of user name template for override_homedir

2017-03-02 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/177 Title: #177: first letter of user name template for override_homedir jhrozek commented: """ ok to test """ See the full comment at https://github.com/SSSD/sssd/pull/177#issuecomment-283676284 ___ sssd-devel

[SSSD] [sssd PR#177][comment] first letter of user name template for override_homedir

2017-03-02 Thread centos-ci
URL: https://github.com/SSSD/sssd/pull/177 Title: #177: first letter of user name template for override_homedir centos-ci commented: """ Can one of the admins verify this patch? """ See the full comment at https://github.com/SSSD/sssd/pull/177#issuecomment-283660035

[SSSD] [sssd PR#146][comment] Avoid running two instances of the same service

2017-03-02 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/146 Title: #146: Avoid running two instances of the same service fidencio commented: """ @lslebodn: new patch set updated. All your comments should've been addressed now. """ See the full comment at

[SSSD] [sssd PR#178][comment] UTIL: Sanitize newline characters.

2017-03-02 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/178 Title: #178: UTIL: Sanitize newline characters. jhrozek commented: """ ok to test """ See the full comment at https://github.com/SSSD/sssd/pull/178#issuecomment-283676013 ___ sssd-devel mailing list --

[SSSD] [sssd PR#178][comment] UTIL: Sanitize newline characters.

2017-03-02 Thread centos-ci
URL: https://github.com/SSSD/sssd/pull/178 Title: #178: UTIL: Sanitize newline characters. centos-ci commented: """ Can one of the admins verify this patch? """ See the full comment at https://github.com/SSSD/sssd/pull/178#issuecomment-283662859 ___

[SSSD] [sssd PR#178][comment] UTIL: Sanitize newline characters.

2017-03-02 Thread centos-ci
URL: https://github.com/SSSD/sssd/pull/178 Title: #178: UTIL: Sanitize newline characters. centos-ci commented: """ Can one of the admins verify this patch? """ See the full comment at https://github.com/SSSD/sssd/pull/178#issuecomment-283662835 ___

[SSSD] [sssd PR#178][opened] UTIL: Sanitize newline characters.

2017-03-02 Thread vtapia
URL: https://github.com/SSSD/sssd/pull/178 Author: vtapia Title: #178: UTIL: Sanitize newline characters. Action: opened PR body: """ Introducing valid usernames with a trailing newline character triggers the removal of valid LDB cache entries Resolves:

[SSSD] [sssd PR#141][+Changes requested] PAM: Use cache_req to perform initgroups lookups

2017-03-02 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/141 Title: #141: PAM: Use cache_req to perform initgroups lookups Label: +Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#141][comment] PAM: Use cache_req to perform initgroups lookups

2017-03-02 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/141 Title: #141: PAM: Use cache_req to perform initgroups lookups jhrozek commented: """ I found one bug in the patches that I pushed into my branch: https://github.com/jhrozek/sssd/tree/pam_cache_req @fidencio if you agree, please squash it in, squash

[SSSD] [sssd PR#179][opened] Search UPN only in the given domain

2017-03-02 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/179 Author: jhrozek Title: #179: Search UPN only in the given domain Action: opened PR body: """ We were searching UPNs in the whole sysdb, which made cache_req think the result came in from the domain it was searching. The bug manifested when a user

[SSSD] [sssd PR#176][+Pushed] Fix detecting UPN suffixes in IPA subdomain code

2017-03-02 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/176 Title: #176: Fix detecting UPN suffixes in IPA subdomain code Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#176][comment] Fix detecting UPN suffixes in IPA subdomain code

2017-03-02 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/176 Title: #176: Fix detecting UPN suffixes in IPA subdomain code lslebodn commented: """ master: * 8718ff9ccd29f6431bfa8630bfa3576b2692c9ee """ See the full comment at https://github.com/SSSD/sssd/pull/176#issuecomment-283709259

[SSSD] [sssd PR#176][closed] Fix detecting UPN suffixes in IPA subdomain code

2017-03-02 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/176 Author: jhrozek Title: #176: Fix detecting UPN suffixes in IPA subdomain code Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/176/head:pr176 git checkout pr176

[SSSD] [sssd PR#141][synchronized] PAM: Use cache_req to perform initgroups lookups

2017-03-02 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/141 Author: fidencio Title: #141: PAM: Use cache_req to perform initgroups lookups Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/141/head:pr141 git checkout pr141 From

[SSSD] [sssd PR#141][-Changes requested] PAM: Use cache_req to perform initgroups lookups

2017-03-02 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/141 Title: #141: PAM: Use cache_req to perform initgroups lookups Label: -Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#141][comment] PAM: Use cache_req to perform initgroups lookups

2017-03-02 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/141 Title: #141: PAM: Use cache_req to perform initgroups lookups fidencio commented: """ @jhrozek: done! """ See the full comment at https://github.com/SSSD/sssd/pull/141#issuecomment-283803546 ___ sssd-devel

[SSSD] [sssd PR#154][synchronized] Confront caches first

2017-03-02 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/154 Author: fidencio Title: #154: Confront caches first Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/154/head:pr154 git checkout pr154 From

[SSSD] [sssd PR#180][opened] SECRETS: Shutdown the responder in case it becomes idle

2017-03-02 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/180 Author: fidencio Title: #180: SECRETS: Shutdown the responder in case it becomes idle Action: opened PR body: """ Similarly to what has been done for the other responders, let's shutdown the secrets responder in case it becomes idle. Resolves:

[SSSD] [sssd PR#141][comment] PAM: Use cache_req to perform initgroups lookups

2017-03-02 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/141 Title: #141: PAM: Use cache_req to perform initgroups lookups jhrozek commented: """ retest this please """ See the full comment at https://github.com/SSSD/sssd/pull/141#issuecomment-283624101 ___

[SSSD] [sssd PR#176][+Accepted] Fix detecting UPN suffixes in IPA subdomain code

2017-03-02 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/176 Title: #176: Fix detecting UPN suffixes in IPA subdomain code Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#152][comment] Add a tevent wrapper around libcurl's asynchronous interface

2017-03-02 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/152 Title: #152: Add a tevent wrapper around libcurl's asynchronous interface jhrozek commented: """ retest this please """ See the full comment at https://github.com/SSSD/sssd/pull/152#issuecomment-283681560

[SSSD] [sssd PR#139][comment] Initial revision of sssd pytest framework

2017-03-02 Thread mrniranjan
URL: https://github.com/SSSD/sssd/pull/139 Title: #139: Initial revision of sssd pytest framework mrniranjan commented: """ I have updated the PR with pep8,pylint fixes, please have a look and let me know how we can move forward """ See the full comment at

[SSSD] [sssd PR#170][comment] PROXY: Remove duplicit users from group

2017-03-02 Thread celestian
URL: https://github.com/SSSD/sssd/pull/170 Title: #170: PROXY: Remove duplicit users from group celestian commented: """ So, @lslebodn and me looked at how to test this patch. Unfortunately we found out that proxy code uses ```nss_files_getgrnam_r``` which is not mocked by

[SSSD] [sssd PR#176][comment] Fix detecting UPN suffixes in IPA subdomain code

2017-03-02 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/176 Title: #176: Fix detecting UPN suffixes in IPA subdomain code sumit-bose commented: """ Patch looks good and is working as expected. ACK. """ See the full comment at https://github.com/SSSD/sssd/pull/176#issuecomment-283688433

[SSSD] [sssd PR#146][+Pushed] Avoid running two instances of the same service

2017-03-02 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/146 Title: #146: Avoid running two instances of the same service Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#146][closed] Avoid running two instances of the same service

2017-03-02 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/146 Author: fidencio Title: #146: Avoid running two instances of the same service Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/146/head:pr146 git checkout pr146

[SSSD] [sssd PR#146][comment] Avoid running two instances of the same service

2017-03-02 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/146 Title: #146: Avoid running two instances of the same service lslebodn commented: """ I did small change before push because there were hardcoded paths in socket files. @fidencio ACKed them :-) `sed -e 's!/usr/libexec!@libexecdir@!' -i

[SSSD] [sssd PR#146][comment] Avoid running two instances of the same service

2017-03-02 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/146 Title: #146: Avoid running two instances of the same service lslebodn commented: """ master: * e0ca21d9f899c60cc50030c6ae793c48e92b5b7f * 9c0c83eecf963416effee67dab55711234373fde """ See the full comment at

[SSSD] [sssd PR#146][-Changes requested] Avoid running two instances of the same service

2017-03-02 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/146 Title: #146: Avoid running two instances of the same service Label: -Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to