On 11/08/2017 11:28 AM, Sumit Bose wrote:
Hi,
while trying to prepare some diagrams to illustrate how the memory mapped
cache works I realized that we might not use the payload factor as
expected.
In sss_mmap_cache_init() we set a payload depending of the type of
cached data, e.g. for passwd
URL: https://github.com/SSSD/sssd/pull/433
Title: #433: PAM: Multiple certificates on a Smartcard
fidencio commented:
"""
Okay, all the downstream tests passed (one of the them only in the second run,
though).
ACK!
"""
See the full comment at
URL: https://github.com/SSSD/sssd/pull/433
Title: #433: PAM: Multiple certificates on a Smartcard
Label: -Changes requested
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to
URL: https://github.com/SSSD/sssd/pull/424
Title: #424: TOOLS: Add a new sssctl command access-report
Label: -Changes requested
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to
URL: https://github.com/SSSD/sssd/pull/433
Title: #433: PAM: Multiple certificates on a Smartcard
fidencio commented:
"""
Please, whoever pushes this patch set, add Scott Poore as reviewer as well.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/433#issuecomment-343130006
URL: https://github.com/SSSD/sssd/pull/433
Title: #433: PAM: Multiple certificates on a Smartcard
Label: +Accepted
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
URL: https://github.com/SSSD/sssd/pull/446
Author: jhrozek
Title: #446: RESP: Add some missing NULL checks
Action: opened
PR body:
"""
This trivial bug was copied all around the responder code. Only when I
initially copied it for another time I noticed we should check the info
structure
On (23/10/17 21:33), Michael Ströder wrote:
>Jakub Hrozek wrote:
>> On Mon, Oct 23, 2017 at 09:19:21PM +0200, Michael Ströder wrote:
>>> Jakub Hrozek wrote:
On Mon, Oct 23, 2017 at 08:46:08PM +0200, Michael Ströder wrote:
> Has anything changed with building the man pages?
>
> I'm
URL: https://github.com/SSSD/sssd/pull/446
Title: #446: RESP: Add some missing NULL checks
fidencio commented:
"""
ACK!
"""
See the full comment at
https://github.com/SSSD/sssd/pull/446#issuecomment-343150607
___
sssd-devel mailing list --
URL: https://github.com/SSSD/sssd/pull/446
Title: #446: RESP: Add some missing NULL checks
Label: +Accepted
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
URL: https://github.com/SSSD/sssd/pull/433
Title: #433: PAM: Multiple certificates on a Smartcard
lslebodn commented:
"""
Just a note. I would like to avoid following change:
```
diff --git a/src/util/authtok.c b/src/util/authtok.c
index c2f78be32..2c5a26ce3 100644
--- a/src/util/authtok.c
+++
URL: https://github.com/SSSD/sssd/pull/433
Title: #433: PAM: Multiple certificates on a Smartcard
lslebodn commented:
"""
@fidencio Are you still able to see warning with latest version after dropping
change in `sss_authtok_get_type` ?
"""
See the full comment at
URL: https://github.com/SSSD/sssd/pull/433
Title: #433: PAM: Multiple certificates on a Smartcard
fidencio commented:
"""
Let me re-run the covscan just to give you a proper answer, but the patch
you're proposing to drop was proposed exactly to fix that issue.
"""
See the full comment at
URL: https://github.com/SSSD/sssd/pull/442
Title: #442: LDAP: Improve error treatment from sdap_cli_connect() in ldap_auth
sumit-bose commented:
"""
The patch makes sense and passes the CI (with the current exception on F27 and
rawhide caused by the newer libldb). ACK
@fidencio, please let me
URL: https://github.com/SSSD/sssd/pull/433
Title: #433: PAM: Multiple certificates on a Smartcard
Label: -Accepted
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
URL: https://github.com/SSSD/sssd/pull/441
Title: #441: CHILD: Pass information about logger to children
fidencio commented:
"""
@lslebodn, although the "SYSTEMD: Clean pid file in corner cases" is not
related to this series, I'm fine on having it pushed together.
Code-wise the patch looks
URL: https://github.com/SSSD/sssd/pull/446
Author: jhrozek
Title: #446: RESP: Add some missing NULL checks
Action: closed
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/446/head:pr446
git checkout pr446
URL: https://github.com/SSSD/sssd/pull/446
Title: #446: RESP: Add some missing NULL checks
lslebodn commented:
"""
master:
* 2c6c3cff23a0750a5f68b52cb1a52e241aa20615
"""
See the full comment at
https://github.com/SSSD/sssd/pull/446#issuecomment-343276748
URL: https://github.com/SSSD/sssd/pull/433
Title: #433: PAM: Multiple certificates on a Smartcard
fidencio commented:
"""
@lslebodn, so, if I revert that patch the warning is back. I, personally, don't
think that the safety check would hurt us in any way, so I'd prefer keeping it
and avoiding
19 matches
Mail list logo