[SSSD] [sssd PR#432][-Changes requested] CACHE_REQ: Better debugging for email conflicts

2017-11-10 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/432 Title: #432: CACHE_REQ: Better debugging for email conflicts Label: -Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#432][comment] CACHE_REQ: Better debugging for email conflicts

2017-11-10 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/432 Title: #432: CACHE_REQ: Better debugging for email conflicts mzidek-rh commented: """ Here is the issue that tracks the email in 'nameAlias' attribute issue: https://pagure.io/SSSD/sssd/issue/3567 """ See the full comment at

[SSSD] [sssd PR#441][comment] CHILD: Pass information about logger to children

2017-11-10 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/441 Title: #441: CHILD: Pass information about logger to children fidencio commented: """ Just for the record: JobID: 2135562 Status: Completed Result: Pass """ See the full comment at https://github.com/SSSD/sssd/pull/441#issuecomment-343412753

[SSSD] [sssd PR#437][comment] KCM: Fix restart during/after upgrade

2017-11-10 Thread benzea
URL: https://github.com/SSSD/sssd/pull/437 Title: #437: KCM: Fix restart during/after upgrade benzea commented: """ Alright, I think I understand now. I ran "systemctl restart sssd-kcm" which did not start sssd-kcm.socket but only sssd-kcm.service. So it appears the daemon then did an idle

[SSSD] [sssd PR#432][comment] CACHE_REQ: Better debugging for email conflicts

2017-11-10 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/432 Title: #432: CACHE_REQ: Better debugging for email conflicts fidencio commented: """ Just for the record. We had a meeting Yesterday and we discussed this PR face-to-face in order to speed the process up and do not block it. @lslebodn's worries

[SSSD] [sssd PR#441][closed] CHILD: Pass information about logger to children

2017-11-10 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/441 Author: lslebodn Title: #441: CHILD: Pass information about logger to children Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/441/head:pr441 git checkout pr441

[SSSD] [sssd PR#441][+Pushed] CHILD: Pass information about logger to children

2017-11-10 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/441 Title: #441: CHILD: Pass information about logger to children Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#439][closed] sudo: always use srv_opts from id context - Backport to SSSD-1.13

2017-11-10 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/439 Author: pbrezina Title: #439: sudo: always use srv_opts from id context - Backport to SSSD-1.13 Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/439/head:pr439 git checkout pr439

[SSSD] [sssd PR#439][comment] sudo: always use srv_opts from id context - Backport to SSSD-1.13

2017-11-10 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/439 Title: #439: sudo: always use srv_opts from id context - Backport to SSSD-1.13 lslebodn commented: """ sssd-1-13: * c5d53b0ce89dd0ce5642964dace3edf15e9bad98 """ See the full comment at https://github.com/SSSD/sssd/pull/439#issuecomment-343473057

[SSSD] [sssd PR#439][+Pushed] sudo: always use srv_opts from id context - Backport to SSSD-1.13

2017-11-10 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/439 Title: #439: sudo: always use srv_opts from id context - Backport to SSSD-1.13 Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#433][comment] PAM: Multiple certificates on a Smartcard

2017-11-10 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/433 Title: #433: PAM: Multiple certificates on a Smartcard sumit-bose commented: """ @fidencio, @lslebodn, the new version has both, the if-check and the sss_authtok patch, remove. I'll enhance the sss_authtok patch and send it with a different PR. """

[SSSD] [sssd PR#440][comment] TOOLS: Double quote array expansions in sss_debuglevel

2017-11-10 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/440 Title: #440: TOOLS: Double quote array expansions in sss_debuglevel lslebodn commented: """ master: * 06c4482c0cda8f6493203d49ef316b3c2bb069dc * c8396478ed5f1a8adcf48ff362fff64e550a2ad7 """ See the full comment at

[SSSD] [sssd PR#433][comment] PAM: Multiple certificates on a Smartcard

2017-11-10 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/433 Title: #433: PAM: Multiple certificates on a Smartcard fidencio commented: """ So, I've just done some tests here and seems that we can just drop "authtok: check for NULL in sss_authtok_get_type()" patch, as long as we add the following fixup to the

[SSSD] [sssd PR#433][comment] PAM: Multiple certificates on a Smartcard

2017-11-10 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/433 Title: #433: PAM: Multiple certificates on a Smartcard fidencio commented: """ @lslebodn, @sumit-bose, both of you agree on that? (so we can have it merged sooner than later :-)) """ See the full comment at

[SSSD] [sssd PR#440][comment] TOOLS: Double quote array expansions in sss_debuglevel

2017-11-10 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/440 Title: #440: TOOLS: Double quote array expansions in sss_debuglevel lslebodn commented: """ Obvious, ACK """ See the full comment at https://github.com/SSSD/sssd/pull/440#issuecomment-343470336 ___

[SSSD] [sssd PR#440][closed] TOOLS: Double quote array expansions in sss_debuglevel

2017-11-10 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/440 Author: fidencio Title: #440: TOOLS: Double quote array expansions in sss_debuglevel Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/440/head:pr440 git checkout pr440

[SSSD] [sssd PR#440][+Pushed] TOOLS: Double quote array expansions in sss_debuglevel

2017-11-10 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/440 Title: #440: TOOLS: Double quote array expansions in sss_debuglevel Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#442][comment] LDAP: Improve error treatment from sdap_cli_connect() in ldap_auth

2017-11-10 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/442 Title: #442: LDAP: Improve error treatment from sdap_cli_connect() in ldap_auth lslebodn commented: """ @sumit-bose I'm waiting for results of tests. I'll push the patch after good results with your ACK """ See the full comment at

[SSSD] [sssd PR#433][comment] PAM: Multiple certificates on a Smartcard

2017-11-10 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/433 Title: #433: PAM: Multiple certificates on a Smartcard fidencio commented: """ Covscan passed. ACK, and I'm adding the "Accepted" label. """ See the full comment at https://github.com/SSSD/sssd/pull/433#issuecomment-343521532

[SSSD] [sssd PR#433][+Accepted] PAM: Multiple certificates on a Smartcard

2017-11-10 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/433 Title: #433: PAM: Multiple certificates on a Smartcard Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#442][closed] LDAP: Improve error treatment from sdap_cli_connect() in ldap_auth

2017-11-10 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/442 Author: fidencio Title: #442: LDAP: Improve error treatment from sdap_cli_connect() in ldap_auth Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/442/head:pr442 git checkout pr442

[SSSD] [sssd PR#433][comment] PAM: Multiple certificates on a Smartcard

2017-11-10 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/433 Title: #433: PAM: Multiple certificates on a Smartcard lslebodn commented: """ whitespace unit test failed for me on my laptop + I would like to re-run downstream tests with current master which contains fixes for few regressions. (therefore temporary

[SSSD] [sssd PR#433][-Accepted] PAM: Multiple certificates on a Smartcard

2017-11-10 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/433 Title: #433: PAM: Multiple certificates on a Smartcard Label: -Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#442][comment] LDAP: Improve error treatment from sdap_cli_connect() in ldap_auth

2017-11-10 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/442 Title: #442: LDAP: Improve error treatment from sdap_cli_connect() in ldap_auth lslebodn commented: """ master: * 20d18db36096e3fa2636143a83a12a2e3a7f26d6 """ See the full comment at https://github.com/SSSD/sssd/pull/442#issuecomment-343581840

[SSSD] [sssd PR#442][comment] LDAP: Improve error treatment from sdap_cli_connect() in ldap_auth

2017-11-10 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/442 Title: #442: LDAP: Improve error treatment from sdap_cli_connect() in ldap_auth lslebodn commented: """ There were some random failures which I did not see before. But it worked well after re-executing problematic jobs 5 times. I hope it was not

[SSSD] [sssd PR#437][comment] KCM: Fix restart during/after upgrade

2017-11-10 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/437 Title: #437: KCM: Fix restart during/after upgrade lslebodn commented: """ On (10/11/17 10:51), Benjamin Berg wrote: >Alright, I think I understand now. I ran "systemctl restart sssd-kcm" which >did not start sssd-kcm.socket but only sssd-kcm.service.

[SSSD] [sssd PR#433][comment] PAM: Multiple certificates on a Smartcard

2017-11-10 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/433 Title: #433: PAM: Multiple certificates on a Smartcard lslebodn commented: """ > @lslebodn, @sumit-bose, both of you agree on that? (so we can have it merged > sooner than later :-)) Sure I suggested to drop the check. """ See the full comment at

[SSSD] [sssd PR#442][comment] LDAP: Improve error treatment from sdap_cli_connect() in ldap_auth

2017-11-10 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/442 Title: #442: LDAP: Improve error treatment from sdap_cli_connect() in ldap_auth sumit-bose commented: """ @lslebodn, thanks, shall I set the Accepted flag or will you do it? """ See the full comment at

[SSSD] [sssd PR#441][+Accepted] CHILD: Pass information about logger to children

2017-11-10 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/441 Title: #441: CHILD: Pass information about logger to children Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#441][comment] CHILD: Pass information about logger to children

2017-11-10 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/441 Title: #441: CHILD: Pass information about logger to children fidencio commented: """ Downstream tests have passed (I've ran the one responsible for finding the regression in the first place). """ See the full comment at