[SSSD] [sssd PR#592][comment] Responder: simplify if-else structure in sss_dp_get_account_msg()

2018-06-08 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/592 Title: #592: Responder: simplify if-else structure in sss_dp_get_account_msg() fidencio commented: """ @jhrozek, although this one is ack'ed, I don't see a reason why it should be merged *before* the release. So, please, if you agree, let's merged it

[SSSD] [sssd PR#592][+Accepted] Responder: simplify if-else structure in sss_dp_get_account_msg()

2018-06-08 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/592 Title: #592: Responder: simplify if-else structure in sss_dp_get_account_msg() Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#588][comment] nss-imap: add sss_nss_getsidbyuid() and sss_nss_getsidbygid()

2018-06-08 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/588 Title: #588: nss-imap: add sss_nss_getsidbyuid() and sss_nss_getsidbygid() jhrozek commented: """ * master: * b8da03b4234ea5536dc08c1627c710f0b64afc64 * 54c040cb4ea120771954d5882b756e9300b7b673 * 8ae68aa27d3e4d3a42ebfa3cb165dc4d9f289c61 *

[SSSD] [sssd PR#588][closed] nss-imap: add sss_nss_getsidbyuid() and sss_nss_getsidbygid()

2018-06-08 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/588 Author: sumit-bose Title: #588: nss-imap: add sss_nss_getsidbyuid() and sss_nss_getsidbygid() Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/588/head:pr588 git checkout pr588

[SSSD] [sssd PR#588][+Pushed] nss-imap: add sss_nss_getsidbyuid() and sss_nss_getsidbygid()

2018-06-08 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/588 Title: #588: nss-imap: add sss_nss_getsidbyuid() and sss_nss_getsidbygid() Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#588][comment] nss-imap: add sss_nss_getsidbyuid() and sss_nss_getsidbygid()

2018-06-08 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/588 Title: #588: nss-imap: add sss_nss_getsidbyuid() and sss_nss_getsidbygid() jhrozek commented: """ also 8550c06fd960f2b68d7aa67f403510415cd8fdda """ See the full comment at https://github.com/SSSD/sssd/pull/588#issuecomment-395764422

[SSSD] [sssd PR#582][closed] ipa: MPG realted fixes for lookups by GID

2018-06-08 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/582 Author: sumit-bose Title: #582: ipa: MPG realted fixes for lookups by GID Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/582/head:pr582 git checkout pr582

[SSSD] [sssd PR#582][comment] ipa: MPG realted fixes for lookups by GID

2018-06-08 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/582 Title: #582: ipa: MPG realted fixes for lookups by GID jhrozek commented: """ * master: * ad6ab352879264fdade8861aff53aa035a2e2240 * e66517dcf63f1d4aaf866c22371dac7740ce0a48 * 032221568fe4287686d0ebb11b5c1fe51cc4735f *

[SSSD] [sssd PR#582][+Pushed] ipa: MPG realted fixes for lookups by GID

2018-06-08 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/582 Title: #582: ipa: MPG realted fixes for lookups by GID Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#593][closed] Better debug messages for some GPO misconfigurations

2018-06-08 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/593 Author: mzidek-rh Title: #593: Better debug messages for some GPO misconfigurations Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/593/head:pr593 git checkout pr593

[SSSD] [sssd PR#593][+Pushed] Better debug messages for some GPO misconfigurations

2018-06-08 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/593 Title: #593: Better debug messages for some GPO misconfigurations Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#593][comment] Better debug messages for some GPO misconfigurations

2018-06-08 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/593 Title: #593: Better debug messages for some GPO misconfigurations jhrozek commented: """ * master: * f3f1bd4 * 39d37f6 """ See the full comment at https://github.com/SSSD/sssd/pull/593#issuecomment-395766207

[SSSD] [sssd PR#594][comment] KCM: be aware that size_t might have different size than other integers

2018-06-08 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/594 Title: #594: KCM: be aware that size_t might have different size than other integers jhrozek commented: """ * maste6191cf81d78cfff3140975734a7e1afbcd484f30r: """ See the full comment at https://github.com/SSSD/sssd/pull/594#issuecomment-395765834

[SSSD] [sssd PR#594][closed] KCM: be aware that size_t might have different size than other integers

2018-06-08 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/594 Author: sumit-bose Title: #594: KCM: be aware that size_t might have different size than other integers Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/594/head:pr594 git checkout

[SSSD] [sssd PR#594][+Pushed] KCM: be aware that size_t might have different size than other integers

2018-06-08 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/594 Title: #594: KCM: be aware that size_t might have different size than other integers Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#588][+Accepted] nss-imap: add sss_nss_getsidbyuid() and sss_nss_getsidbygid()

2018-06-08 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/588 Title: #588: nss-imap: add sss_nss_getsidbyuid() and sss_nss_getsidbygid() Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#588][comment] nss-imap: add sss_nss_getsidbyuid() and sss_nss_getsidbygid()

2018-06-08 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/588 Title: #588: nss-imap: add sss_nss_getsidbyuid() and sss_nss_getsidbygid() jhrozek commented: """ CI: http://vm-031.ABC/logs/job/90/18/summary.html """ See the full comment at https://github.com/SSSD/sssd/pull/588#issuecomment-395762462

[SSSD] [sssd PR#585][comment] tcurl: do not log the payload

2018-06-08 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/585 Title: #585: tcurl: do not log the payload jhrozek commented: """ * master: f8025ae01699b5221079a4ee2c6111c514642ce4 """ See the full comment at https://github.com/SSSD/sssd/pull/585#issuecomment-395765273

[SSSD] [sssd PR#585][+Pushed] tcurl: do not log the payload

2018-06-08 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/585 Title: #585: tcurl: do not log the payload Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org Fedora Code

[SSSD] [sssd PR#585][closed] tcurl: do not log the payload

2018-06-08 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/585 Author: fidencio Title: #585: tcurl: do not log the payload Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/585/head:pr585 git checkout pr585

[SSSD] [sssd PR#582][+Accepted] ipa: MPG realted fixes for lookups by GID

2018-06-08 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/582 Title: #582: ipa: MPG realted fixes for lookups by GID Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#582][comment] ipa: MPG realted fixes for lookups by GID

2018-06-08 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/582 Title: #582: ipa: MPG realted fixes for lookups by GID jhrozek commented: """ CI: http://vm-031.ABC/logs/job/90/17/summary.html """ See the full comment at https://github.com/SSSD/sssd/pull/582#issuecomment-395679152

[SSSD] [sssd PR#588][comment] nss-imap: add sss_nss_getsidbyuid() and sss_nss_getsidbygid()

2018-06-08 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/588 Title: #588: nss-imap: add sss_nss_getsidbyuid() and sss_nss_getsidbygid() jhrozek commented: """ @sumit-bose Let me know what do you think about adding the break to the default case, otherwise the patches look good and I think they should even go

[SSSD] [sssd PR#592][edited] Responder: simplify if-else structure in sss_dp_get_account_msg()

2018-06-08 Thread amitkumar50
URL: https://github.com/SSSD/sssd/pull/592 Author: amitkumar50 Title: #592: Responder: simplify if-else structure in sss_dp_get_account_msg() Action: edited Changed field: title Original value: """ too complex if-else structure in sss_dp_get_account_msg """

[SSSD] [sssd PR#592][comment] too complex if-else structure in sss_dp_get_account_msg

2018-06-08 Thread amitkumar50
URL: https://github.com/SSSD/sssd/pull/592 Title: #592: too complex if-else structure in sss_dp_get_account_msg amitkumar50 commented: """ @fidencio Apologies Yes I know about template. I submit PR with template most time. Skipped this time. Will remember. >And thanks for the contribution!

[SSSD] Re: RFC: 1.16.2 release notes

2018-06-08 Thread Fabiano FidĂȘncio
Jakub, On Fri, Jun 8, 2018 at 11:02 AM, Jakub Hrozek wrote: > Hi, > > below are the release notes for 1.16.2. Please comment :-) > > SSSD 1.16.2 > === > > Highlights > -- > > New Features > > * The smart card authentication, or in more general certificate >

[SSSD] [sssd PR#592][synchronized] too complex if-else structure in sss_dp_get_account_msg

2018-06-08 Thread amitkumar50
URL: https://github.com/SSSD/sssd/pull/592 Author: amitkumar50 Title: #592: too complex if-else structure in sss_dp_get_account_msg Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/592/head:pr592 git checkout pr592

[SSSD] RFC: 1.16.2 release notes

2018-06-08 Thread Jakub Hrozek
Hi, below are the release notes for 1.16.2. Please comment :-) SSSD 1.16.2 === Highlights -- New Features * The smart card authentication, or in more general certificate authentication code now supports OpenSSL in addition to previously supported NSS (#3489).

[SSSD] [sssd PR#592][comment] Responder: simplify if-else structure in sss_dp_get_account_msg()

2018-06-08 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/592 Title: #592: Responder: simplify if-else structure in sss_dp_get_account_msg() fidencio commented: """ Ack! """ See the full comment at https://github.com/SSSD/sssd/pull/592#issuecomment-395706268 ___

[SSSD] [sssd PR#579][comment] krb5 locator: add support for multiple addresses and sub-domains

2018-06-08 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/579 Title: #579: krb5 locator: add support for multiple addresses and sub-domains sumit-bose commented: """ I hope the latest version helps to fix/avoid the crash by making sure the offline callbacks are only run once (as the online callbacks already

[SSSD] [sssd PR#579][comment] krb5 locator: add support for multiple addresses and sub-domains

2018-06-08 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/579 Title: #579: krb5 locator: add support for multiple addresses and sub-domains jhrozek commented: """ Thank you, I ran a quick test and I no longer see the crashes. I will continue with the full review later, though. """ See the full comment at

[SSSD] [sssd PR#579][synchronized] krb5 locator: add support for multiple addresses and sub-domains

2018-06-08 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/579 Author: sumit-bose Title: #579: krb5 locator: add support for multiple addresses and sub-domains Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/579/head:pr579 git checkout

[SSSD] [sssd PR#579][comment] krb5 locator: add support for multiple addresses and sub-domains

2018-06-08 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/579 Title: #579: krb5 locator: add support for multiple addresses and sub-domains jhrozek commented: """ retest this please """ See the full comment at https://github.com/SSSD/sssd/pull/579#issuecomment-395842120

[SSSD] Announcing SSSD 1.16.2

2018-06-08 Thread Jakub Hrozek
SSSD 1.16.2 === The SSSD team is proud to announce the release of version 1.16.2 of the System Security Services Daemon. The tarball can be downloaded from https://releases.pagure.org/SSSD/sssd/ RPM packages will be made available for Fedora shortly. Feedback Please provide