URL: https://github.com/SSSD/sssd/pull/614
Title: #614: nss_protocol_fill_initgr: skip incomplete groups instead of
bailing out
Label: -Accepted
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to
URL: https://github.com/SSSD/sssd/pull/614
Title: #614: nss_protocol_fill_initgr: skip incomplete groups instead of
bailing out
fidencio commented:
"""
Although the patch looks good, after a conversation with @jhrozek ... I have my
mind made that we may be just papering over a more critical
URL: https://github.com/SSSD/sssd/pull/624
Title: #624: Fix "test-find-uid" and "find_uid-tests" tests
fidencio commented:
"""
master:
a41367f
"""
See the full comment at
https://github.com/SSSD/sssd/pull/624#issuecomment-411662715
___
sssd-devel
URL: https://github.com/SSSD/sssd/pull/624
Title: #624: Fix "test-find-uid" and "find_uid-tests" tests
Label: +Pushed
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to
URL: https://github.com/SSSD/sssd/pull/629
Title: #629: ldap: remove parallel requests from rfc2307bis
pbrezina commented:
"""
I ran some manual tests and everything passed. Ack.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/629#issuecomment-411716915
URL: https://github.com/SSSD/sssd/pull/132
Title: #132: Add "Wants=" to sssd unit
pbrezina commented:
"""
Sockets for secrets and kcm responders are avoided on purpose?
"""
See the full comment at
https://github.com/SSSD/sssd/pull/132#issuecomment-411698413
URL: https://github.com/SSSD/sssd/pull/614
Title: #614: nss_protocol_fill_initgr: skip incomplete groups instead of
bailing out
fidencio commented:
"""
I see. We'll have a phone call Today and discuss this patch within SSSD team.
Although we don't have nor follow any "governance", I do
URL: https://github.com/SSSD/sssd/pull/614
Title: #614: nss_protocol_fill_initgr: skip incomplete groups instead of
bailing out
fidencio commented:
"""
I see. We'll have a phone call Today and discuss this patch within SSSD team.
Although we don't have nor follow any "governance", I do
URL: https://github.com/SSSD/sssd/pull/132
Title: #132: Add "Wants=" to sssd unit
pbrezina commented:
"""
OK. In that case the manpage change should be rephrase because the term `all
services` is misleading.
```
By default, all services are enabled.
URL: https://github.com/SSSD/sssd/pull/629
Title: #629: ldap: remove parallel requests from rfc2307bis
Label: +Accepted
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to
URL: https://github.com/SSSD/sssd/pull/132
Title: #132: Add "Wants=" to sssd unit
fidencio commented:
"""
Yes, they are. Theoretically secrets and kcm responders' sockets are (or should
be) enabled by default by the distro.
"""
See the full comment at
URL: https://github.com/SSSD/sssd/pull/132
Title: #132: Add "Wants=" to sssd unit
fidencio commented:
"""
Yes, they are. Theoretically sssd and kcm responders' sockets are (or should
be) enabled by default by the distro.
"""
See the full comment at
URL: https://github.com/SSSD/sssd/pull/614
Title: #614: nss_protocol_fill_initgr: skip incomplete groups instead of
bailing out
asheplyakov commented:
"""
@fidencio
> would you have a cache dump, logs or even a machine that you could give us
> access
Unfortunately no. That was a client's
URL: https://github.com/SSSD/sssd/pull/626
Title: #626: SELINUX: Also call is_selinux_enabled as a check for selinux child
Label: -Accepted
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to
URL: https://github.com/SSSD/sssd/pull/626
Title: #626: SELINUX: Also call is_selinux_enabled as a check for selinux child
fidencio commented:
"""
master:
1e81d04
"""
See the full comment at
https://github.com/SSSD/sssd/pull/626#issuecomment-411663228
URL: https://github.com/SSSD/sssd/pull/626
Title: #626: SELINUX: Also call is_selinux_enabled as a check for selinux child
Label: +Pushed
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to
URL: https://github.com/SSSD/sssd/pull/624
Author: stanislavlevin
Title: #624: Fix "test-find-uid" and "find_uid-tests" tests
Action: closed
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/624/head:pr624
git checkout pr624
URL: https://github.com/SSSD/sssd/pull/624
Title: #624: Fix "test-find-uid" and "find_uid-tests" tests
Label: -Changes requested
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to
URL: https://github.com/SSSD/sssd/pull/626
Author: jhrozek
Title: #626: SELINUX: Also call is_selinux_enabled as a check for selinux child
Action: closed
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/626/head:pr626
git checkout pr626
URL: https://github.com/SSSD/sssd/pull/624
Title: #624: Fix "test-find-uid" and "find_uid-tests" tests
fidencio commented:
"""
After a conversation with @jhrozek, I'm doing the requested changes in this
patch and pushing it.
"""
See the full comment at
URL: https://github.com/SSSD/sssd/pull/614
Title: #614: nss_protocol_fill_initgr: skip incomplete groups instead of
bailing out
Label: +Pushed
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to
URL: https://github.com/SSSD/sssd/pull/614
Title: #614: nss_protocol_fill_initgr: skip incomplete groups instead of
bailing out
fidencio commented:
"""
We agreed on merging the PR during our team meeting.
"""
See the full comment at
URL: https://github.com/SSSD/sssd/pull/614
Title: #614: nss_protocol_fill_initgr: skip incomplete groups instead of
bailing out
Label: +Accepted
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to
URL: https://github.com/SSSD/sssd/pull/614
Title: #614: nss_protocol_fill_initgr: skip incomplete groups instead of
bailing out
fidencio commented:
"""
master:
4937f2c
"""
See the full comment at
https://github.com/SSSD/sssd/pull/614#issuecomment-411796606
URL: https://github.com/SSSD/sssd/pull/614
Title: #614: nss_protocol_fill_initgr: skip incomplete groups instead of
bailing out
Label: -Accepted
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to
URL: https://github.com/SSSD/sssd/pull/614
Author: asheplyakov
Title: #614: nss_protocol_fill_initgr: skip incomplete groups instead of
bailing out
Action: closed
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/614/head:pr614
git
URL: https://github.com/SSSD/sssd/pull/631
Author: fidencio
Title: #631: nss: remove unused label
Action: opened
PR body:
"""
After 4937f2c6, Sumit noticed the following warning/breakage:
make[2]: Leaving directory '/home/sbose/sssd/master_build/src/man'
Making check in .
URL: https://github.com/SSSD/sssd/pull/631
Title: #631: nss: remove unused label
sumit-bose commented:
"""
I had a minor comment (see inline), please let me know if you agree or if you
think that it would be safer to keep this patch minimal.
"""
See the full comment at
URL: https://github.com/SSSD/sssd/pull/632
Author: sumit-bose
Title: #632: tests: fix sss_nss_idmap-tests
Action: opened
PR body:
"""
If sss_nss_idmap-tests is complied with -Wl,-Bsymbolic-functions it
fails because sss_nss_make_request_timeout() is not properly wrapped but
the tests expects
URL: https://github.com/SSSD/sssd/pull/631
Title: #631: nss: remove unused label
fidencio commented:
"""
I agree with your comment (but maybe I would prefer to have your suggestion as
a separate patch of this very same PR).
Would you mind pushing this as it is in order to fix the breakage
URL: https://github.com/SSSD/sssd/pull/632
Title: #632: tests: fix sss_nss_idmap-tests
panlinux commented:
"""
Thanks, I can confirm that this patch makes the sss_nss_idmap-tests tests pass
on Ubuntu 18.10 with -Wl,-Bsymbolic-functions enabled.
"""
See the full comment at
URL: https://github.com/SSSD/sssd/pull/631
Author: fidencio
Title: #631: nss: remove unused label
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/631/head:pr631
git checkout pr631
From
URL: https://github.com/SSSD/sssd/pull/631
Title: #631: nss: remove unused label
fidencio commented:
"""
@sumit-bose, I've changed my mind and fully adopted your suggestion in one
single patch.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/631#issuecomment-411858930
URL: https://github.com/SSSD/sssd/pull/620
Title: #620: Add pam_cert_pam_services option
fidencio commented:
"""
@sumit-bose, shall we go for @lslebodn's patch instead?
If so, I'd close this PR and push https://pagure.io/SSSD/sssd/pull-request/3799
Tomorrow.
"""
See the full comment at
URL: https://github.com/SSSD/sssd/pull/632
Title: #632: tests: fix sss_nss_idmap-tests
fidencio commented:
"""
Looks good to me!
"""
See the full comment at
https://github.com/SSSD/sssd/pull/632#issuecomment-411861571
___
sssd-devel mailing list --
URL: https://github.com/SSSD/sssd/pull/632
Title: #632: tests: fix sss_nss_idmap-tests
Label: +Accepted
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
Fedora
URL: https://github.com/SSSD/sssd/pull/630
Title: #630: KCM/SECRETS: Use a library to access the secrets storage instead
of the secrets responder, deprecate secrets responder
Label: +Changes requested
___
sssd-devel mailing list --
37 matches
Mail list logo
