Re: [SSSD] [PATCH] Update manpage with new enumerate syntax

2009-09-10 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 09/09/2009 02:16 PM, Simo Sorce wrote: On Wed, 2009-09-09 at 13:34 -0400, Stephen Gallagher wrote: $SUBJECT Ack. Simo. Pushed to master - -- Stephen Gallagher RHCE 804006346421761 Looking to carve out IT costs?

Re: [SSSD] [PATCHES] Handle invalid domain configuration better

2009-09-10 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 09/09/2009 02:20 PM, Simo Sorce wrote: On Wed, 2009-09-09 at 13:33 -0400, Stephen Gallagher wrote: Patch 0001: Ensure that daemonization happens after reading in the configuration, so critical configuration errors repord FAILED during init

[SSSD] [PATCH] Collection improvements to copy functions

2009-09-10 Thread Dmitri Pal
See patch comment. Also ticket #174 https://fedorahosted.org/sssd/ticket/174 regarding constants that might alert your attention. -- Thank you, Dmitri Pal Engineering Manager IPA project, Red Hat Inc. --- Looking to carve out IT costs? www.redhat.com/carveoutcosts/

[SSSD] [PATCH] Read and validate configuration before daemonizing

2009-09-10 Thread Stephen Gallagher
Attached is a new approach to reading the configuration and exiting with an error code if the configuration is invalid. There should be no situation where this will affect signal/process setup anymore. Patch 0001: Simple cleanup. We're now using a private event context for the confdb and ignoring

[SSSD] [PATCH] Properly detect negative/invalid values for the minId and maxId

2009-09-10 Thread Stephen Gallagher
Now we'll first read the values in as a string and parse them to ensure that they represent positive numbers. -- Stephen Gallagher RHCE 804006346421761 Looking to carve out IT costs? www.redhat.com/carveoutcosts/ From 84a4386fa03406d32ca9dfcaa9bd4956f190fcb0 Mon Sep 17 00:00:00 2001 From:

Re: [SSSD] [PATCH] fix DBusWatch handling

2009-09-10 Thread Mathias Gug
Hi, On Mon, Aug 31, 2009 at 3:10 PM, Stephen Gallagher sgall...@redhat.com wrote: New revision. I was finally able to test this patch on an Ubuntu machine (thanks Steve) and we found out 2 pretty nasty bugs masquerading each other on Fedora. This new revision should be final, it works on

Re: [SSSD] [PATCH] Fix proxy enumerations with newer tevent

2009-09-10 Thread Mathias Gug
Hi, On Thu, Sep 3, 2009 at 7:43 AM, Stephen Gallagher sgall...@redhat.com wrote: Ok I have fixed it by ignoring errors on the save operation. I also found a copypaste error where we were calling enum_users_process from enum_groups_process Pushed to master. I've included this patch into

Re: [SSSD] [PATCH] Read and validate configuration before daemonizing

2009-09-10 Thread Simo Sorce
On Thu, 2009-09-10 at 11:11 -0400, Stephen Gallagher wrote: Attached is a new approach to reading the configuration and exiting with an error code if the configuration is invalid. There should be no situation where this will affect signal/process setup anymore. Patch 0001: Simple cleanup.

Re: [SSSD] [PATCH] Properly detect negative/invalid values for the minId and maxId

2009-09-10 Thread Simo Sorce
On Thu, 2009-09-10 at 11:12 -0400, Stephen Gallagher wrote: Now we'll first read the values in as a string and parse them to ensure that they represent positive numbers. Given conversion from string to integer is not a complex business, shouldn't we just retrieve the entry as a string and do

Re: [SSSD] [PATCH] Collection improvements to copy functions

2009-09-10 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 09/10/2009 10:51 AM, Dmitri Pal wrote: See patch comment. Also ticket #174 https://fedorahosted.org/sssd/ticket/174 regarding constants that might alert your attention.

Re: [SSSD] [PATCH] Read and validate configuration before daemonizing

2009-09-10 Thread Simo Sorce
On Thu, 2009-09-10 at 16:18 -0400, Stephen Gallagher wrote: mem_ctx is not used anymore in this function as far as I can see, please remove it. It is still used for sysdb_init, so I left it there. That sysdb_init() is used only to make sure the db is properly initialized but the results

Re: [SSSD] [PATCH] Properly detect negative/invalid values for the minId and maxId

2009-09-10 Thread Stephen Gallagher
New patch with code review concerns addressed. On 09/10/2009 04:37 PM, Simo Sorce wrote: On Thu, 2009-09-10 at 16:02 -0400, Stephen Gallagher wrote: New approach attached. Patch 0001: Create two convenience functions, strtouint32 and strtoint32. These behave identically to strtol or strtoll,

Re: [SSSD] [PATCH] Collection improvements to copy functions

2009-09-10 Thread Simo Sorce
On Thu, 2009-09-10 at 16:34 -0400, Stephen Gallagher wrote: Ack pushed -- Simo Sorce * Red Hat, Inc * New York ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/sssd-devel

Re: [SSSD] [PATCH] Read and validate configuration before daemonizing

2009-09-10 Thread Simo Sorce
On Thu, 2009-09-10 at 16:58 -0400, Stephen Gallagher wrote: On 09/10/2009 04:42 PM, Simo Sorce wrote: On Thu, 2009-09-10 at 16:18 -0400, Stephen Gallagher wrote: mem_ctx is not used anymore in this function as far as I can see, please remove it. It is still used for sysdb_init, so I

[SSSD] Add copyright notices

2009-09-10 Thread Jakub Hrozek
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Fixes: #138 Done with a script based on git-blame output. -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.9 (GNU/Linux) Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/ iEYEARECAAYFAkqpcaYACgkQHsardTLnvCX1qwCgkEVZJQQtJzjK9Elm7tjxkyhu

[SSSD] [PATCH] Small changes to the example config and manpage

2009-09-10 Thread Jakub Hrozek
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Small changes to the example config and manpage Remove magicPrivateGroups since it's set automatically, use bool values for enumerate. Also add a notice about krb5 auth-module with a link to specialized manpage to sssd.conf(5) similar to what we

Re: [SSSD] [PATCH] Small changes to the example config and manpage

2009-09-10 Thread Stephen Gallagher
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 09/10/2009 05:41 PM, Jakub Hrozek wrote: Small changes to the example config and manpage Remove magicPrivateGroups since it's set automatically, use bool values for enumerate. Also add a notice about krb5 auth-module with a link to

[SSSD] [PATCH] COLLECTION Functions to deal with hash

2009-09-10 Thread Dmitri Pal
A small patch that addresses my concerns related to ELAPI starting to have too much knowledge about internals of collection. See patch comments for details. -- Thank you, Dmitri Pal Engineering Manager IPA project, Red Hat Inc. --- Looking to carve out IT costs?

Re: [SSSD] [PATCH] COLLECTION Functions to deal with hash

2009-09-10 Thread Simo Sorce
On Thu, 2009-09-10 at 18:07 -0400, Dmitri Pal wrote: A small patch that addresses my concerns related to ELAPI starting to have too much knowledge about internals of collection. See patch comments for details. Ack, good move. Simo. -- Simo Sorce * Red Hat, Inc * New York

Re: [SSSD] [PATCH] ELAPI Better separation from collection internals.

2009-09-10 Thread Simo Sorce
On Thu, 2009-09-10 at 18:33 -0400, Dmitri Pal wrote: Getting paranoid about good layering of the interfaces... Patch fixes ELAPI part to take advantage of the collection public interfaces only. Keeping ourselves honest is always a good thing! Ack. Simo. -- Simo Sorce * Red Hat, Inc * New