I haven't gotten Transifex to send the patches to the sssd-devel list
yet, so I'm forwarding this one on manually for the moment.
I give it an Ack, and a thank-you to Piotr Drąg
--
Stephen Gallagher
RHCE 804006346421761
Looking to carve out IT costs?
www.redhat.com/carveoutcosts/
From
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 09/16/2009 11:40 AM, Stephen Gallagher wrote:
I haven't gotten Transifex to send the patches to the sssd-devel list
yet, so I'm forwarding this one on manually for the moment.
I give it an Ack, and a thank-you to Piotr Drąg
Guys,
This is great, thank you for finding it.
But this will really mess up my merges.
Can it be undone?
Also I have a ticket open to explicitly return to this part of code and
sort things out with valgrind.
Thanks for finding the answer and cause of the problem, it will make the
fixes simple
but
On 09/16/2009 01:29 PM, Stephen Gallagher wrote:
On 09/16/2009 11:40 AM, Stephen Gallagher wrote:
I haven't gotten Transifex to send the patches to the sssd-devel list
yet, so I'm forwarding this one on manually for the moment.
I give it an Ack, and a thank-you to Piotr Drg
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 09/16/2009 02:41 PM, Sumit Bose wrote:
On Wed, Sep 16, 2009 at 02:29:09PM -0400, Stephen Gallagher wrote:
On 09/16/2009 01:29 PM, Stephen Gallagher wrote:
On 09/16/2009 11:40 AM, Stephen Gallagher wrote:
I haven't gotten Transifex to send the
On Wed, 2009-09-16 at 14:33 -0400, Stephen Gallagher wrote:
Dmitri, it's a very simple change that will be very easy to resolve
with
'git rebase' and 'git mergetool'.
There's no reason that a complete fix should be held back for the
convenience of any one developer.
Also, no. The
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 09/15/2009 09:20 PM, Dmitri Pal wrote:
1) Comparison and sorting collections
Did you maybe forget to git-add a file? Makefile.am references
collection_cmp.c but that file is in none of the patches.
Jakub
-BEGIN PGP SIGNATURE-
On Wed, 2009-09-16 at 08:48 -0400, Simo Sorce wrote:
Please make it a macro or a subroutine instead of adding it three
times.
Yeah, will do.
Ok new patches attached, with members debug turned into a macro.
Simo.
--
Simo Sorce * Red Hat, Inc * New York
From
Simo Sorce wrote:
On Wed, 2009-09-16 at 14:33 -0400, Stephen Gallagher wrote:
Dmitri, it's a very simple change that will be very easy to resolve
with
'git rebase' and 'git mergetool'.
There's no reason that a complete fix should be held back for the
convenience of any one developer.
Jakub Hrozek wrote:
On 09/15/2009 09:20 PM, Dmitri Pal wrote:
1) Comparison and sorting collections
Did you maybe forget to git-add a file? Makefile.am references
collection_cmp.c but that file is in none of the patches.
Jakub
Thank you, yes I will resend.
Dmitri Pal wrote:
See patch comments for details.
All three are not massive.
1) Comparison and sorting collections
2) Taking part of the code from long module and putting it into a new
module for readability
3) Adding new functionality to the module created in previous patch
Hi,
Spotted some dhash warnings. Seems like worth fixing especially
shadowing ones...
dhash_test.c: In function ‘main’:
dhash_test.c:288: warning: declaration of ‘i’ shadows a previous local
dhash_test.c:115: warning: shadowed declaration is here
dhash_test.c:312: warning: declaration of ‘i’
12 matches
Mail list logo