Re: [SSSD] [PATCH] LDAP: Do not impose sizelimit=1 for single-entry searches

2015-07-23 Thread Lukas Slebodnik
On (23/07/15 10:57), Jakub Hrozek wrote: On Thu, Jul 23, 2015 at 09:39:00AM +0200, Lukas Slebodnik wrote: On (21/07/15 21:33), Jakub Hrozek wrote: Hi, the attached patch fixes regression tracked by https://fedorahosted.org/sssd/ticket/2723 Please see the commit message for more details.

[SSSD] [PATCH] sssd: incorrect checks on length values during packet, decoding

2015-07-23 Thread Michal Židek
Hi, see the attached patch for ticket https://fedorahosted.org/sssd/ticket/1697 I think this is a candidate to include in our coding guidelines. Thanks, Michal -- Senior Principal Intern From e731298ddb68395322843e3b143ff04bdec3353f Mon Sep 17 00:00:00 2001 From:

Re: [SSSD] [PATCHES] DYNDNS: support mult. interfaces for dyndns_iface opt

2015-07-23 Thread Jakub Hrozek
On Thu, Jul 23, 2015 at 01:47:19PM +0200, Pavel Reichl wrote: I hope attached patch set addresses all concerns, thanks! My issues were addressed and the code seems to work. Coverity didn't find anything either. ACK ___ sssd-devel mailing list

[SSSD] [PATCH] krb5: do not send SSS_OTP if two factors were used

2015-07-23 Thread Sumit Bose
Hi, This patch fixes an issue with two factor authentication. When the user is prompted to enter long term password (first factor) and one-time component (second factor) separately the first component may remain on the PAM stack so that other modules can use the long term password. bye, Sumit

Re: [SSSD] [PATCHES] DYNDNS: support mult. interfaces for dyndns_iface opt

2015-07-23 Thread Pavel Reichl
I hope attached patch set addresses all concerns, thanks! From 228335d2a51b5624f8500e69418e0df1355dc64c Mon Sep 17 00:00:00 2001 From: Pavel Reichl prei...@redhat.com Date: Wed, 8 Jul 2015 09:01:24 -0400 Subject: [PATCH 1/5] DYNDNS: sss_iface_addr_list_get return ENOENT If none of eligible

Re: [SSSD] [PATCH] LDAP: Do not impose sizelimit=1 for single-entry searches

2015-07-23 Thread Lukas Slebodnik
On (21/07/15 21:33), Jakub Hrozek wrote: Hi, the attached patch fixes regression tracked by https://fedorahosted.org/sssd/ticket/2723 Please see the commit message for more details. From 2f4e2e6d5e8f29f5b2cdd9f0b825edc172da57ea Mon Sep 17 00:00:00 2001 From: Jakub Hrozek jhro...@redhat.com

Re: [SSSD] [PATCHES] DYNDNS: support mult. interfaces for dyndns_iface opt

2015-07-23 Thread Jakub Hrozek
On Wed, Jul 22, 2015 at 07:54:43PM +0200, Pavel Reichl wrote: Hello Jakub, thanks for the comments, I have updated first 4th patches as you proposed, but I need some clarification of the last patch, please see comments inline: The first patches are mostly good now, I only have two minor

Re: [SSSD] [PATCH] AD: Handle cases where no GPOs apply

2015-07-23 Thread Lukas Slebodnik
On (20/07/15 10:41), Stephen Gallagher wrote: It is possible to have a machine where none of the GPOs associated with it include access-control rules. Currently, this results in a denial-by-system-error. We need to treat this case as allowing the user (see the test cases in

Re: [SSSD] [PATCH] LDAP: Do not impose sizelimit=1 for single-entry searches

2015-07-23 Thread Jakub Hrozek
On Thu, Jul 23, 2015 at 09:39:00AM +0200, Lukas Slebodnik wrote: On (21/07/15 21:33), Jakub Hrozek wrote: Hi, the attached patch fixes regression tracked by https://fedorahosted.org/sssd/ticket/2723 Please see the commit message for more details. From

Re: [SSSD] [PATCH] Fix minor typos in messages, commnts and docs

2015-07-23 Thread Yuri Chornoivan
написане Fri, 26 Jun 2015 08:56:15 +0300, Yuri Chornoivan yurc...@ukr.net: Hi, There are several minor typos in SSSD code. Thanks for fixing them. Best regards, Yuri Ping? ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org

Re: [SSSD] [PATCH] Fix minor typos in messages, commnts and docs

2015-07-23 Thread Jakub Hrozek
On Thu, Jul 23, 2015 at 12:03:33PM +0300, Yuri Chornoivan wrote: написане Fri, 26 Jun 2015 08:56:15 +0300, Yuri Chornoivan yurc...@ukr.net: Hi, There are several minor typos in SSSD code. Thanks for fixing them. Best regards, Yuri Ping? Sorry about the delay Yuri, I didn't tag the

Re: [SSSD] [PATCHES] DYNDNS: support mult. interfaces for dyndns_iface opt

2015-07-23 Thread Pavel Reichl
On 07/23/2015 11:42 AM, Jakub Hrozek wrote: +static errno_t match_ip(const struct sockaddr *sa, +const struct sockaddr *sb, +bool *_res) Don't you think it would be simpler to just return bool? For cases where Yes, it would be simpler, but I

Re: [SSSD] [PATCHES] DYNDNS: support mult. interfaces for dyndns_iface opt

2015-07-23 Thread Jakub Hrozek
On Thu, Jul 23, 2015 at 12:28:33PM +0200, Pavel Reichl wrote: On 07/23/2015 11:42 AM, Jakub Hrozek wrote: +static errno_t match_ip(const struct sockaddr *sa, +const struct sockaddr *sb, +bool *_res) Don't you think it would be simpler to just

[SSSD] [PATCH] CI: Set env variable for all tabs in screen

2015-07-23 Thread Lukas Slebodnik
ehlo, It's a side effect of my effort to write integration tests for memory cache. Attached patch simplify troubleshooting of sssd in cwrap environment. LS From 1d270fee496651b8560790a98d444d86fecbc8ae Mon Sep 17 00:00:00 2001 From: Lukas Slebodnik lsleb...@redhat.com Date: Thu, 23 Jul 2015

Re: [SSSD] [PATCH] IPA: Handle sssd-owned keytabs when running as root

2015-07-23 Thread Jakub Hrozek
On Wed, Jul 22, 2015 at 11:25:06PM +0200, Jakub Hrozek wrote: On Wed, Jul 22, 2015 at 06:16:00PM +0200, Jakub Hrozek wrote: Hi, the attached patch fixes #2718. To reproduce, run sssd as the root user, but chown the keytab as the sssd users. And now with two additional trivial patches