Re: [SSSD] [PATCH] krb5: do not send SSS_OTP if two factors were used

2015-07-29 Thread Jakub Hrozek
On Tue, Jul 28, 2015 at 08:51:44PM +0200, Jakub Hrozek wrote: On Thu, Jul 23, 2015 at 05:20:17PM +0200, Sumit Bose wrote: Hi, This patch fixes an issue with two factor authentication. When the user is prompted to enter long term password (first factor) and one-time component (second

Re: [SSSD] [PATCH] SPEC: Update spec file for krb5_local_auth_plugin

2015-07-29 Thread Jakub Hrozek
On Wed, Jul 29, 2015 at 01:42:20PM +0200, Petr Cech wrote: On 07/24/2015 09:46 AM, Lukas Slebodnik wrote: ehlo, patch is attached. LS 0001-SPEC-Update-spec-file-for-krb5_local_auth_plugin.patch From 9474dfc64cbd73ab25bf12660f6b55e5563fe14c Mon Sep 17 00:00:00 2001 From: Lukas

Re: [SSSD] [PATCH] AD: Use ad_site also when site search fails

2015-07-29 Thread Jakub Hrozek
On Wed, Jul 29, 2015 at 02:30:15PM +0200, Jakub Hrozek wrote: On Wed, Jul 29, 2015 at 11:07:09AM +0200, Pavel Březina wrote: On 07/28/2015 08:55 PM, Jakub Hrozek wrote: On Tue, Jul 28, 2015 at 08:51:22PM +0200, Jakub Hrozek wrote: On Tue, Jul 28, 2015 at 01:51:13PM +0200, Pavel Březina

Re: [SSSD] [PATCH] SDAP: rename SDAP_CACHE_PURGE_TIMEOUT

2015-07-29 Thread Jakub Hrozek
On Wed, Jul 29, 2015 at 10:19:33AM +0200, Pavel Reichl wrote: Hello, please see trivial patch attached. While I was investigating case I found that to access value of 'ldap_purge_cache_timeout' option I need to use enum value SDAP_CACHE_PURGE_TIMEOUT. I consider this to be a bad name (swap

[SSSD] [PATCH] SDAP: rename SDAP_CACHE_PURGE_TIMEOUT

2015-07-29 Thread Pavel Reichl
Hello, please see trivial patch attached. While I was investigating case I found that to access value of 'ldap_purge_cache_timeout' option I need to use enum value SDAP_CACHE_PURGE_TIMEOUT. I consider this to be a bad name (swap of cache and purge) as I took me additional time to find this

Re: [SSSD] [PATCH] AD: Use ad_site also when site search fails

2015-07-29 Thread Pavel Březina
On 07/28/2015 08:55 PM, Jakub Hrozek wrote: On Tue, Jul 28, 2015 at 08:51:22PM +0200, Jakub Hrozek wrote: On Tue, Jul 28, 2015 at 01:51:13PM +0200, Pavel Březina wrote: On 07/28/2015 01:42 PM, Jakub Hrozek wrote: On Tue, Jul 28, 2015 at 12:13:31PM +0200, Pavel Březina wrote: On 07/27/2015

Re: [SSSD] [PATCH] SPEC: Update spec file for krb5_local_auth_plugin

2015-07-29 Thread Petr Cech
On 07/24/2015 09:46 AM, Lukas Slebodnik wrote: ehlo, patch is attached. LS 0001-SPEC-Update-spec-file-for-krb5_local_auth_plugin.patch From 9474dfc64cbd73ab25bf12660f6b55e5563fe14c Mon Sep 17 00:00:00 2001 From: Lukas Slebodniklsleb...@redhat.com Date: Fri, 24 Jul 2015 09:24:31 +0200

Re: [SSSD] [PATCH] AD: Use ad_site also when site search fails

2015-07-29 Thread Jakub Hrozek
On Wed, Jul 29, 2015 at 11:07:09AM +0200, Pavel Březina wrote: On 07/28/2015 08:55 PM, Jakub Hrozek wrote: On Tue, Jul 28, 2015 at 08:51:22PM +0200, Jakub Hrozek wrote: On Tue, Jul 28, 2015 at 01:51:13PM +0200, Pavel Březina wrote: On 07/28/2015 01:42 PM, Jakub Hrozek wrote: On Tue, Jul 28,

Re: [SSSD] [PATCH] mmap_cache: Override functions for initgr mmap cache

2015-07-29 Thread Lukas Slebodnik
On (27/07/15 17:19), Michal Židek wrote: On 07/24/2015 04:57 PM, Lukas Slebodnik wrote: On (24/07/15 15:36), Michal Židek wrote: On 07/24/2015 03:21 PM, Lukas Slebodnik wrote: On (17/07/15 10:16), Lukas Slebodnik wrote: On (16/07/15 19:19), Michal Židek wrote: On 07/16/2015 05:07 PM, Lukas

Re: [SSSD] [PATCH] mmap_cache: Override functions for initgr mmap cache

2015-07-29 Thread Lukas Slebodnik
On (17/07/15 14:07), Lukas Slebodnik wrote: On (16/07/15 17:07), Lukas Slebodnik wrote: On (16/07/15 13:46), Michal Židek wrote: On 07/15/2015 06:42 PM, Lukas Slebodnik wrote: ehlo, reproducer: add user and few groups to ldap call id user remove one group authenticate call id user

Re: [SSSD] [PATCH] intg_test: Add integration test for memory cache

2015-07-29 Thread Lukas Slebodnik
On (24/07/15 16:48), Lukas Slebodnik wrote: On (24/07/15 16:19), Sumit Bose wrote: On Fri, Jul 24, 2015 at 03:35:22PM +0200, Lukas Slebodnik wrote: ehlo, it is a first version of integration test for memory cache. The main purpose of this mail is to have some comments to the first version.

Re: [SSSD] [PATCHES] Add support for Smartcard authentication

2015-07-29 Thread Jakub Hrozek
On Tue, Jul 28, 2015 at 10:43:13PM +0200, Sumit Bose wrote: Hi, I started the review, but because the patches are quite big, I will send my comments in batches. I hope that's fine. Thank you for the review. CI failed in distcheck. The failure was due to distcheck's