Re: [SSSD] [PATCH] test_memory_cache: Wait short time after cache invalidation

2015-08-12 Thread Lukas Slebodnik
On (12/08/15 14:35), Michal Židek wrote: On 08/12/2015 06:21 AM, Lukas Slebodnik wrote: On (11/08/15 14:43), Michal Židek wrote: On 08/11/2015 01:41 PM, Lukas Slebodnik wrote: On (10/08/15 13:32), Michal Židek wrote: On 08/10/2015 12:26 PM, Lukas Slebodnik wrote: On (10/08/15 10:41), Lukas

Re: [SSSD] [PATCH] test_memory_cache: Wait short time after cache invalidation

2015-08-12 Thread Lukas Slebodnik
On (12/08/15 14:07), Pavel Reichl wrote: On 08/11/2015 02:43 PM, Michal Židek wrote: I do not think that the fact that some situation is unlikely to happen is a reason to ignore it, especially if the solution is as easy as this one. And I know we could simply ask user in error message to run

Re: [SSSD] [WIP] [TEST]: Observation patch

2015-08-12 Thread Lukas Slebodnik
On (12/08/15 17:57), Petr Cech wrote: Hi, I have explored in detail why the test responder_cache_req-tests failed so often. I created a new VM with RHEL 6.7. OBSERVATION: How we know, CI machines are under pressure, so I wrote simple cpu_braker, see [1]. I ran the tests 50 times with

Re: [SSSD] [PATCH] DEBUG: Add new debug category for fail over

2015-08-12 Thread Lukas Slebodnik
On (12/08/15 19:09), Michal Židek wrote: On 08/12/2015 06:24 AM, Lukas Slebodnik wrote: On (11/08/15 15:00), Michal Židek wrote: On 08/11/2015 01:25 PM, Lukas Slebodnik wrote: On (11/08/15 13:16), Michal Židek wrote: On 08/11/2015 06:52 AM, Lukas Slebodnik wrote: On (10/08/15 19:28), Michal Židek

Re: [SSSD] [PATCH] NSS: Fix use after free

2015-08-12 Thread Lukas Slebodnik
On (12/08/15 14:17), Jakub Hrozek wrote: On Mon, Aug 10, 2015 at 06:38:29AM +0200, Lukas Slebodnik wrote: ehlo, Use after free can happed if there are two domains and user is not found in the first one. LS Would it be possible to write a testcase in the NSS responder test? It requires

Re: [SSSD] [PATCH] SYSDB: add more debug msgs. to group membership code

2015-08-12 Thread Lukas Slebodnik
On (12/08/15 09:42), Pavel Reichl wrote: On 08/12/2015 06:18 AM, Lukas Slebodnik wrote: On (11/08/15 18:36), Pavel Reichl wrote: Hello, I'm investigating log file with debug_level 9 that contains following lines [sssd[be[dom]]] [sysdb_update_members_ex] (0x0020): Could not add member

Re: [SSSD] [PATCH] SYSDB: add more debug msgs. to group membership code

2015-08-12 Thread Pavel Reichl
On 08/12/2015 10:11 AM, Lukas Slebodnik wrote: On (12/08/15 09:42), Pavel Reichl wrote: On 08/12/2015 06:18 AM, Lukas Slebodnik wrote: On (11/08/15 18:36), Pavel Reichl wrote: Hello, I'm investigating log file with debug_level 9 that contains following lines [sssd[be[dom]]]

Re: [SSSD] [PATCH] SYSDB: add more debug msgs. to group membership code

2015-08-12 Thread Pavel Reichl
On 08/12/2015 06:18 AM, Lukas Slebodnik wrote: On (11/08/15 18:36), Pavel Reichl wrote: Hello, I'm investigating log file with debug_level 9 that contains following lines [sssd[be[dom]]] [sysdb_update_members_ex] (0x0020): Could not add member [user@dom] to group [somedn]. Skipping.

[SSSD] [PATCH] UTIL: Alternative way for debug message initialisation

2015-08-12 Thread Lukas Slebodnik
ehlo, attached patch shoul avoid situation as in commit 7c69221077c780e62f6c536e78675f2dc1c131bc The comments does not guarantee anything. Author: Michal Zidek mzi...@redhat.com Date: Tue Mar 10 17:30:48 2015 +0100 DEBUG: Add missing strings for error messages We had more error

Re: [SSSD] [PATCH] SYSDB: add more debug msgs. to group membership code

2015-08-12 Thread Lukas Slebodnik
On (12/08/15 10:28), Pavel Reichl wrote: On 08/12/2015 10:11 AM, Lukas Slebodnik wrote: On (12/08/15 09:42), Pavel Reichl wrote: On 08/12/2015 06:18 AM, Lukas Slebodnik wrote: On (11/08/15 18:36), Pavel Reichl wrote: Hello, I'm investigating log file with debug_level 9 that contains following

[SSSD] [WIP] [TEST]: Observation patch

2015-08-12 Thread Petr Cech
Hi, I have explored in detail why the test responder_cache_req-tests failed so often. I created a new VM with RHEL 6.7. OBSERVATION: How we know, CI machines are under pressure, so I wrote simple cpu_braker, see [1]. I ran the tests 50 times with cpu_braker (average load 2.60, only 1

Re: [SSSD] [PATCH] DEBUG: Add new debug category for fail over

2015-08-12 Thread Michal Židek
On 08/12/2015 06:24 AM, Lukas Slebodnik wrote: On (11/08/15 15:00), Michal Židek wrote: On 08/11/2015 01:25 PM, Lukas Slebodnik wrote: On (11/08/15 13:16), Michal Židek wrote: On 08/11/2015 06:52 AM, Lukas Slebodnik wrote: On (10/08/15 19:28), Michal Židek wrote: See attached patch that

Re: [SSSD] [PATCH] Switch ldap_user_certificate default to userCertificate; binary

2015-08-12 Thread Jakub Hrozek
On Mon, Aug 10, 2015 at 12:59:24PM +0200, Jakub Hrozek wrote: Hi, the attached patches fix #2742. The first one makes sure we can print the certificate (or any binary attribute, really) safely. We only need to make sure to escape the attribute values before saving them to sysdb, because

[SSSD] [PATCH] Use sss_unique_file instead of calling mkstemp directly

2015-08-12 Thread Jakub Hrozek
Hi, there is a patchset that adds sss_unique_file with an optional destructor: https://patchwork.acksyn.org/patch/11351/ Attached are patches that use the function instead of mkstemp(). As you can see in the patches, we already fix some bugs this way, especially removing the tmpfiles left

Re: [SSSD] [PATCH] NSS: Fix use after free

2015-08-12 Thread Jakub Hrozek
On Mon, Aug 10, 2015 at 06:38:29AM +0200, Lukas Slebodnik wrote: ehlo, Use after free can happed if there are two domains and user is not found in the first one. LS Would it be possible to write a testcase in the NSS responder test? ___

Re: [SSSD] [PATCH] test_memory_cache: Wait short time after cache invalidation

2015-08-12 Thread Pavel Reichl
On 08/11/2015 02:43 PM, Michal Židek wrote: I do not think that the fact that some situation is unlikely to happen is a reason to ignore it, especially if the solution is as easy as this one. And I know we could simply ask user in error message to run sss_cache again, but I do not see reason

Re: [SSSD] [PATCH] Fetch one-way trust keytabs on sssd restart again

2015-08-12 Thread Jakub Hrozek
On Fri, Aug 07, 2015 at 12:22:39PM +0200, Pavel Březina wrote: On 07/30/2015 09:52 PM, Jakub Hrozek wrote: On Thu, Jul 30, 2015 at 09:46:11PM +0200, Jakub Hrozek wrote: Hi, the attached patches implement fetching the keytab for one-way trusts on each sssd restart. This is in order for admin

Re: [SSSD] [PATCH] SYSDB: add more debug msgs. to group membership code

2015-08-12 Thread Pavel Reichl
On 08/12/2015 01:06 PM, Lukas Slebodnik wrote: On (12/08/15 10:28), Pavel Reichl wrote: On 08/12/2015 10:11 AM, Lukas Slebodnik wrote: On (12/08/15 09:42), Pavel Reichl wrote: On 08/12/2015 06:18 AM, Lukas Slebodnik wrote: On (11/08/15 18:36), Pavel Reichl wrote: Hello, I'm investigating

Re: [SSSD] [PATCH] test_memory_cache: Wait short time after cache invalidation

2015-08-12 Thread Michal Židek
On 08/12/2015 06:21 AM, Lukas Slebodnik wrote: On (11/08/15 14:43), Michal Židek wrote: On 08/11/2015 01:41 PM, Lukas Slebodnik wrote: On (10/08/15 13:32), Michal Židek wrote: On 08/10/2015 12:26 PM, Lukas Slebodnik wrote: On (10/08/15 10:41), Lukas Slebodnik wrote: On (07/08/15 21:19),