[SSSD]Re: [PATCH] DATA_PROVIDER: BE_REQ as string in log message

2015-08-21 Thread Pavel Reichl
On 08/18/2015 01:19 PM, Petr Cech wrote: On 08/05/2015 11:23 AM, Jakub Hrozek wrote: B) While writing a patch Lukas noticed another similar logging messages [sssd[pam]] [sss_dp_get_account_msg] (0x0400): Creating request for [LDAP][3][1][name=mof_user6] I investigated it. This is the

[SSSD]Re: [PATCH] TESTS: ldap_id_cleanup timeouts

2015-08-21 Thread Michal Židek
On 08/20/2015 01:50 PM, Petr Cech wrote: On 08/19/2015 08:26 PM, Michal Židek wrote: Hi! This is another patch to avoid failing tests in the CI (make-check-valgrind). This time the ldap_id_cleanup tests. Looks like the one second cache timeout was too short and the tests sometimes failed

Re: [SSSD] [PATCH] TESTS: Removing part of responder_cache_req-tests

2015-08-21 Thread Petr Cech
On 08/21/2015 02:35 PM, Michal Židek wrote: Hi, some of the tests you deleted are valid and should not be deleted. Only those tests that rely on time(NULL) being the same as the time of request creation are invalid. All those that test old entries or nonexistent entries are OK. See comments

[SSSD]Re: [PATCH] TESTS: Removing part of responder_cache_req-tests

2015-08-21 Thread Michal Židek
On 08/21/2015 02:18 PM, Petr Cech wrote: Hi, there is patch, which removes failing tests from responder_cache_req suite. The reasons are mentioned in commit message. There will be another patch, which will rewrite those tests. Petr Hi, some of the tests you deleted are valid and should not

Re: [SSSD] [PATCH] sssd: incorrect checks on length values during packet, decoding

2015-08-21 Thread Petr Cech
On 07/23/2015 02:44 PM, Michal Židek wrote: Hi, see the attached patch for ticket https://fedorahosted.org/sssd/ticket/1697 I think this is a candidate to include in our coding guidelines. I agree. It is a candidate. Thanks, Michal ___

[SSSD]Re: Re: [PATCH] DATA_PROVIDER: BE_REQ as string in log message

2015-08-21 Thread Petr Cech
On 08/21/2015 01:08 PM, Pavel Reichl wrote: Hello Petr, make dict check fails: /workspace/ci/label/rhel7/ci-build-debug/sssd-1.13.1/_inst/share/locale\ -g3 -O2 -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -c

[SSSD]Re: More upstream CI tests

2015-08-21 Thread Nikolai Kondrashov
On 08/20/2015 12:38 AM, Jakub Hrozek wrote: as we're stabilizing the 1.13 branch and before we plan what we want to work on during the 1.14 development, we should use that time to write some more tests! Here are some areas where we could add tests. Please discuss or add your ideas, I would like

Re: [SSSD] [PATCH] DATA_PROVIDER: BE_REQ as string in log message

2015-08-21 Thread Pavel Reichl
On 08/21/2015 03:40 PM, Petr Cech wrote: On 08/21/2015 01:08 PM, Pavel Reichl wrote: Hello Petr, make dict check fails: /workspace/ci/label/rhel7/ci-build-debug/sssd-1.13.1/_inst/share/locale\ -g3 -O2 -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64

[SSSD] Embedding Lua into SSSD

2015-08-21 Thread Nikolai Kondrashov
Hi everyone, I might be in a strange and careless mood today, but here is something I wanted to suggest since the time I saw the amount of logic that goes into SSSD and is implemented in C. What if we implement some of the complicated logic inside SSSD in Lua [1]? Lua is a language

Re: [SSSD] [PATCH] Switch ldap_user_certificate default to userCertificate; binary

2015-08-21 Thread Simo Sorce
On Fri, 2015-08-21 at 09:50 +0200, Jan Cholasta wrote: Hi, On 10.8.2015 12:59, Jakub Hrozek wrote: Hi, the attached patches fix #2742. The first one makes sure we can print the certificate (or any binary attribute, really) safely. We only need to make sure to escape the attribute

Re: [SSSD] [PATCH] DATA_PROVIDER: BE_REQ as string in log message

2015-08-21 Thread Petr Cech
On 08/21/2015 05:10 PM, Pavel Reichl wrote: Petr can you change data_provider_req.c to include providers/data_provider_req.h instead of providers/data_provider.h ? I originally thought that you will be able to include solely data_provider_req.h from responder_dp.c but I see that

Re: [SSSD] [PATCH] DATA_PROVIDER: BE_REQ as string in log message

2015-08-21 Thread Pavel Reichl
On 08/21/2015 05:49 PM, Petr Cech wrote: On 08/21/2015 05:10 PM, Pavel Reichl wrote: Petr can you change data_provider_req.c to include providers/data_provider_req.h instead of providers/data_provider.h ? I originally thought that you will be able to include solely data_provider_req.h

Re: [SSSD] Embedding Lua into SSSD

2015-08-21 Thread Simo Sorce
On Fri, 2015-08-21 at 20:01 +0300, Nikolai Kondrashov wrote: Hi everyone, I might be in a strange and careless mood today, but here is something I wanted to suggest since the time I saw the amount of logic that goes into SSSD and is implemented in C. What if we implement some of the

[SSSD]Re: Re: [PATCH] TESTS: ldap_id_cleanup timeouts

2015-08-21 Thread Petr Cech
On 08/21/2015 01:33 PM, Michal Židek wrote: On 08/20/2015 01:50 PM, Petr Cech wrote: On 08/19/2015 08:26 PM, Michal Židek wrote: Hi! This is another patch to avoid failing tests in the CI (make-check-valgrind). This time the ldap_id_cleanup tests. Looks like the one second cache timeout was

Re: [SSSD] [PATCH] Switch ldap_user_certificate default to userCertificate; binary

2015-08-21 Thread Jan Cholasta
Hi, On 10.8.2015 12:59, Jakub Hrozek wrote: Hi, the attached patches fix #2742. The first one makes sure we can print the certificate (or any binary attribute, really) safely. We only need to make sure to escape the attribute values before saving them to sysdb, because then ldb guarantees