[SSSD] I think #2637 is out of scope of 1.13

Hi, ssia... I was working on implementing https://fedorahosted.org/sssd/ticket/2637 and while for most occurences it was quite easy to set domain status instead of back end status, I hit the sdap_id_op module.. The sdap_id_op operation sets the offline status directly, in a bit of a hackish way

Re: [SSSD] [PATCHES] cleanup task: Expire all memberof targets when removing user

CI passed: http://sssd-ci.duckdns.org/logs/job/24/24/summary.html ACK to all patches. - Original Message - From: "Pavel Reichl" To: sssd-devel@lists.fedorahosted.org Sent: Tuesday, September 1, 2015 6:40:51 PM Subject: Re: [SSSD] [PATCHES] cleanup task: Expire all

Re: [SSSD] [PATCH] UTIL: Function 2string for enum sss_cli_command

On 09/01/2015 08:44 AM, Petr Cech wrote: On 08/31/2015 09:51 PM, Jakub Hrozek wrote: On Mon, Aug 31, 2015 at 06:33:52PM +0200, Jakub Hrozek wrote: On Thu, Aug 27, 2015 at 12:19:18PM +0200, Lukas Slebodnik wrote: ACK LS * master: 11e8f3ecdddf8edd8b1bbe9f41b49ce8b709b92a This patch broke

Re: [SSSD] [PATCH] intg_tests: Add regression test for 2163

On (24/07/15 17:24), Lukas Slebodnik wrote: >On (22/07/15 11:43), Jakub Hrozek wrote: >>On Mon, Jul 20, 2015 at 03:52:52PM +0200, Lukas Slebodnik wrote: >>> On (20/07/15 15:46), Lukas Slebodnik wrote: >>> >ehlo, >>> > >>> >attached is a regression test for old ticket 2163. >>> >Currently it fails

Re: [SSSD] [PATCH] UTIL: Function 2string for enum sss_cli_command

On 08/31/2015 09:51 PM, Jakub Hrozek wrote: On Mon, Aug 31, 2015 at 06:33:52PM +0200, Jakub Hrozek wrote: On Thu, Aug 27, 2015 at 12:19:18PM +0200, Lukas Slebodnik wrote: ACK LS * master: 11e8f3ecdddf8edd8b1bbe9f41b49ce8b709b92a This patch broke distcheck: ../src/util/sss_cli_cmd.c

Re: [SSSD] [PATCH] NSS: Don't ignore backslash in usernames with ldap provider

On Mon, Aug 31, 2015 at 09:01:48PM +0200, Sumit Bose wrote: > On Fri, Aug 28, 2015 at 07:23:29AM +0200, Lukas Slebodnik wrote: > > ehlo, > > > > please review attached patch for regression #2772 > > > > LS > > Hi Lukas, > > thank you for taking care of the issue. > > The patch is working as

[SSSD] [DING-LIBS] [PATCH] Ensure ding-linbs metapackage depends on libbasicobjects

This change brings the upstream packaging closer to the downstream (fedora) packaging. For more information, please see https://fedorahosted.org/sssd/ticket/2770 From 1661c53bbc0df2efd3a767e25a5c7f33f4b0c717 Mon Sep 17 00:00:00 2001 From: "Robbie Harwood (frozencemetery)"

[SSSD] [DING-LIBS] [INI] [PATCH] Document ini_config_augment alphabetical file processing

The sorted file processing is a useful guarantee to have, and is provided by the current code. https://fedorahosted.org/sssd/ticket/2771 From d11f7814c968cb94d8321e723460391df556e2d6 Mon Sep 17 00:00:00 2001 From: Robbie Harwood Date: Mon, 31 Aug 2015 15:14:12 -0400 Subject:

Re: [SSSD] [PATCH] GPO: Use sss_unique_file and close fd on failure

On Wed, Aug 26, 2015 at 02:21:23PM +0200, Pavel Březina wrote: > On 08/18/2015 03:35 PM, Jakub Hrozek wrote: > >Hi, > > > >one more usage of sss_unique_file I forgot to send earlier. > > Nack. > > > ret = close(fd); > >+fd = -1; > > if (ret == -1) { > > ret = errno; > >

Re: [SSSD] [PATCH] GPO: Use sss_unique_file and close fd on failure

On 09/01/2015 11:19 AM, Jakub Hrozek wrote: On Wed, Aug 26, 2015 at 02:21:23PM +0200, Pavel Březina wrote: On 08/18/2015 03:35 PM, Jakub Hrozek wrote: Hi, one more usage of sss_unique_file I forgot to send earlier. Nack. ret = close(fd); +fd = -1; if (ret == -1) {

Re: [SSSD] [PATCH] NSS: Fix use after free

On Wed, Aug 19, 2015 at 11:15:16PM +0200, Jakub Hrozek wrote: > On Thu, Aug 13, 2015 at 07:41:02AM +0200, Lukas Slebodnik wrote: > > On (12/08/15 14:17), Jakub Hrozek wrote: > > >On Mon, Aug 10, 2015 at 06:38:29AM +0200, Lukas Slebodnik wrote: > > >> ehlo, > > >> > > >> Use after free can happed

[SSSD] [PATCHES] LDAP: Sanitize group dn before using in filter

ehlo, attached is alternative version for ticket 2744. The unit test passed but there is a performance improvement. If we compare 3rd patch to current master than there is a 10 less invocation of malloc (an also other functions) per group. and we saved allocation of 1091 per group. There was a

Re: [SSSD] [PATCH] PAM: Add pam environment variable AUTH_DOMAIN to pam reply

On Tue, Sep 01, 2015 at 11:00:26AM +0200, Jakub Hrozek wrote: > > Shall we push this patch to master since it looks correct code wise and > doesn't look like it should regress anything or shall we wait for more > complete solution in 1.14 that would also address domain-vs-realm > concerns? Is

Re: [SSSD] [PATCH] CONFDB: Assume config file version 2 if missing

On Tue, Aug 11, 2015 at 07:47:00AM +0200, Lukas Slebodnik wrote: > On (10/08/15 17:18), Michal Židek wrote: > >On 08/06/2015 01:39 PM, Lukas Slebodnik wrote: > >>On (05/08/15 13:41), Michal Židek wrote: > >>>On 07/30/2015 06:08 PM, Lukas Slebodnik wrote: > >>>-} else if (version <

Re: [SSSD] [PATCH] AD: send less logs to syslog

On 08/28/2015 02:09 PM, Pavel Reichl wrote: Hello, please see simple patch attached. Thanks! Ack. ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/sssd-devel

Re: [SSSD] [PATCH] CONFDB: Assume config file version 2 if missing

On Tue, Sep 01, 2015 at 11:00:15AM +0200, Lukas Slebodnik wrote: > On (01/09/15 10:51), Jakub Hrozek wrote: > >On Tue, Aug 11, 2015 at 07:47:00AM +0200, Lukas Slebodnik wrote: > >> On (10/08/15 17:18), Michal Židek wrote: > >> >On 08/06/2015 01:39 PM, Lukas Slebodnik wrote: > >> >>On (05/08/15

Re: [SSSD] [PATCH] CONFDB: Assume config file version 2 if missing

On 09/01/2015 11:11 AM, Jakub Hrozek wrote: On Tue, Sep 01, 2015 at 11:00:15AM +0200, Lukas Slebodnik wrote: On (01/09/15 10:51), Jakub Hrozek wrote: On Tue, Aug 11, 2015 at 07:47:00AM +0200, Lukas Slebodnik wrote: On (10/08/15 17:18), Michal Židek wrote: On 08/06/2015 01:39 PM, Lukas

Re: [SSSD] [PATCH] Two sbus fixes

On 09/01/2015 10:05 AM, Jakub Hrozek wrote: On Wed, Aug 26, 2015 at 02:26:06PM +0200, Pavel Březina wrote: On 08/10/2015 03:31 PM, Jakub Hrozek wrote: Hi, I found two issues in the sbus code while testing the by-certificate lookups. One was that if parsing the reply with client UID failed,

Re: [SSSD] [PATCH] CONFDB: Assume config file version 2 if missing

On (01/09/15 10:51), Jakub Hrozek wrote: >On Tue, Aug 11, 2015 at 07:47:00AM +0200, Lukas Slebodnik wrote: >> On (10/08/15 17:18), Michal Židek wrote: >> >On 08/06/2015 01:39 PM, Lukas Slebodnik wrote: >> >>On (05/08/15 13:41), Michal Židek wrote: >> >>>On 07/30/2015 06:08 PM, Lukas Slebodnik

Re: [SSSD] [PATCH] [HBAC]: Better libhbac debuging

In https://fedorahosted.org/sssd/wiki/FAQ SSSDBG_FATAL_FAILURE is described as: 0x0010: Fatal failures. Anything that would prevent SSSD from starting up or causes it to cease running. Are you sure that such errors can happen in HBAC? HBAC_DBG_FATAL isn't used in

Re: [SSSD] [PATCH] PAM: Add pam environment variable AUTH_DOMAIN to pam reply

On Thu, Jul 09, 2015 at 12:35:51PM +0200, Sumit Bose wrote: > On Thu, Jul 09, 2015 at 11:50:06AM +0200, Jan Pazdziora wrote: > > On Thu, Jul 09, 2015 at 11:33:11AM +0200, Sumit Bose wrote: > > > > > > Most probable because ad...@example.test is the Kerberos principal of > > > your user. If SSSD

Re: [SSSD] [PATCH] intg_tests: Add regression test for 2163

On Tue, Sep 01, 2015 at 08:49:49AM +0200, Lukas Slebodnik wrote: > On (24/07/15 17:24), Lukas Slebodnik wrote: > >On (22/07/15 11:43), Jakub Hrozek wrote: > >>On Mon, Jul 20, 2015 at 03:52:52PM +0200, Lukas Slebodnik wrote: > >>> On (20/07/15 15:46), Lukas Slebodnik wrote: > >>> >ehlo, > >>> > >

Re: [SSSD] [PATCH] GPO: Use sss_unique_file and close fd on failure

On Tue, Sep 01, 2015 at 11:28:32AM +0200, Pavel Březina wrote: > >Please see the attached patch, does it look better to you? > > Hi, yes. There is just an indentation error: > > >+if (fd != -1) { > >+fret = close(fd); > >+if (fret == -1) { > >+fret = errno; > >+

Re: [SSSD] [PATCH] intg_tests: Add regression test for 2163

On Tue, Sep 01, 2015 at 11:57:36AM +0200, Lukas Slebodnik wrote: > On (01/09/15 11:55), Jakub Hrozek wrote: > >On Tue, Sep 01, 2015 at 08:49:49AM +0200, Lukas Slebodnik wrote: > >> On (24/07/15 17:24), Lukas Slebodnik wrote: > >> >On (22/07/15 11:43), Jakub Hrozek wrote: > >> >>On Mon, Jul 20,

Re: [SSSD] [PATCH] AD: send less logs to syslog

On Tue, Sep 01, 2015 at 10:51:25AM +0200, Pavel Březina wrote: > On 08/28/2015 02:09 PM, Pavel Reichl wrote: > >Hello, > > > >please see simple patch attached. > > > >Thanks! > > Ack. * master: bfa5e3869bb68213f08169efe55c45cb625e8fd0 ___ sssd-devel

Re: [SSSD] Code style -- for loop iterative variables initial declaration

On 09/01/2015 10:58 AM, Jakub Hrozek wrote: On Mon, Aug 31, 2015 at 01:24:17PM +0200, Michal Židek wrote: On 08/31/2015 01:20 PM, Jakub Hrozek wrote: On Mon, Aug 31, 2015 at 02:09:19PM +0300, Alexander Bokovoy wrote: On Mon, 31 Aug 2015, Lukas Slebodnik wrote: On (29/08/15 14:33), Alexander

Re: [SSSD] [PATCH] UTIL: Function 2string for enum sss_cli_command

On Tue, Sep 01, 2015 at 09:37:29AM +0200, Pavel Reichl wrote: > On 09/01/2015 08:44 AM, Petr Cech wrote: > >On 08/31/2015 09:51 PM, Jakub Hrozek wrote: > >>On Mon, Aug 31, 2015 at 06:33:52PM +0200, Jakub Hrozek wrote: > >>>On Thu, Aug 27, 2015 at 12:19:18PM +0200, Lukas Slebodnik wrote: > ACK

Re: [SSSD] [PATCH] Two sbus fixes

On Wed, Aug 26, 2015 at 02:26:06PM +0200, Pavel Březina wrote: > On 08/10/2015 03:31 PM, Jakub Hrozek wrote: > >Hi, > > > >I found two issues in the sbus code while testing the by-certificate > >lookups. One was that if parsing the reply with client UID failed, then > >errno would have been

Re: [SSSD] [PATCH] PAM: Add pam environment variable AUTH_DOMAIN to pam reply

On Tue, Sep 01, 2015 at 11:06:59AM +0200, Jan Pazdziora wrote: > On Tue, Sep 01, 2015 at 11:00:26AM +0200, Jakub Hrozek wrote: > > > > Shall we push this patch to master since it looks correct code wise and > > doesn't look like it should regress anything or shall we wait for more > > complete

Re: [SSSD] [PATCH] intg_tests: Add regression test for 2163

On (01/09/15 11:57), Lukas Slebodnik wrote: >On (01/09/15 11:55), Jakub Hrozek wrote: >>On Tue, Sep 01, 2015 at 08:49:49AM +0200, Lukas Slebodnik wrote: >>> On (24/07/15 17:24), Lukas Slebodnik wrote: >>> >On (22/07/15 11:43), Jakub Hrozek wrote: >>> >>On Mon, Jul 20, 2015 at 03:52:52PM +0200,

Re: [SSSD] Code style -- for loop iterative variables initial declaration

On Mon, Aug 31, 2015 at 01:24:17PM +0200, Michal Židek wrote: > On 08/31/2015 01:20 PM, Jakub Hrozek wrote: > >On Mon, Aug 31, 2015 at 02:09:19PM +0300, Alexander Bokovoy wrote: > >>On Mon, 31 Aug 2015, Lukas Slebodnik wrote: > >>>On (29/08/15 14:33), Alexander Bokovoy wrote: > On Fri, 28 Aug

Re: [SSSD] [PATCH] Two sbus fixes

On Tue, Sep 01, 2015 at 10:37:16AM +0200, Pavel Březina wrote: > On 09/01/2015 10:05 AM, Jakub Hrozek wrote: > >On Wed, Aug 26, 2015 at 02:26:06PM +0200, Pavel Březina wrote: > >>On 08/10/2015 03:31 PM, Jakub Hrozek wrote: > >>>Hi, > >>> > >>>I found two issues in the sbus code while testing the

Re: [SSSD] [PATCH] intg_tests: Add regression test for 2163

On (01/09/15 11:55), Jakub Hrozek wrote: >On Tue, Sep 01, 2015 at 08:49:49AM +0200, Lukas Slebodnik wrote: >> On (24/07/15 17:24), Lukas Slebodnik wrote: >> >On (22/07/15 11:43), Jakub Hrozek wrote: >> >>On Mon, Jul 20, 2015 at 03:52:52PM +0200, Lukas Slebodnik wrote: >> >>> On (20/07/15 15:46),

Re: [SSSD] [PATCH] GPO: Use sss_unique_file and close fd on failure

On 09/01/2015 11:54 AM, Jakub Hrozek wrote: On Tue, Sep 01, 2015 at 11:28:32AM +0200, Pavel Březina wrote: Please see the attached patch, does it look better to you? Hi, yes. There is just an indentation error: +if (fd != -1) { +fret = close(fd); +if (fret == -1) { +

Re: [SSSD] [PATCH v3] Remove trailing whitespace

On 09/01/2015 07:21 AM, Lukas Slebodnik wrote: On (31/08/15 16:24), Nikolai Kondrashov wrote: I wouldn't say these are exclusive. I think we still need to fix the Git tree detection, so it doesn't consider to be under a git repo, which doesn't start at the source root, and so it works with

[SSSD] [PATCH] GPO: use SDAP_SASL_AUTHID as samAccountName

Hi, this patch contains a fix for https://fedorahosted.org/sssd/ticket/2692. If uses the SDAP_SASL_AUTHID config option because it already contains the right NetBIOS name in the AD case. I basically tested the patch on a host with a long hostname. Without the patch I see: [ad_gpo_connect_done]

Re: [SSSD] [PATCH v3] Remove trailing whitespace

On 08/31/2015 09:59 AM, Lukas Slebodnik wrote: diff --git a/src/tests/whitespace_test b/src/tests/whitespace_test new file mode 100755 index ..508fe2d532cc6a3967af8eaa5c7dc4dccdc653f3 --- /dev/null +++ b/src/tests/whitespace_test @@ -0,0 +1,32 @@

Re: [SSSD] [PATCHES] cleanup task: Expire all memberof targets when removing user

On 08/31/2015 06:53 PM, Michal Židek wrote: 0001-Makefile.am-Add-AM_CFLAGS-for-libsss_ldap_common.patch From b563b44a99c91c75523ea11e18cb7f7552750817 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Michal=20=C5=BDidek?= Date: Mon, 31 Aug 2015 18:21:44 +0200 Subject: [PATCH 1/5]

[SSSD] [PATCHES] BUILD: Speed up build of some tests

ehlo, Attached patches reduce count of compiled ".c" files from 935 -> 815 (almost 9%). This reduction is achieved in deduplication of compiling "*.c" files in tests. BTW the tests were compiled 4 times in our CI script. * make tests * mock build * make distcheck * code coverage The result

Re: [SSSD] [DING-LIBS] [PATCH] Ensure ding-linbs metapackage depends on libbasicobjects

On (01/09/15 18:18), Robbie Harwood wrote: >This change brings the upstream packaging closer to the downstream >(fedora) packaging. For more information, please see >https://fedorahosted.org/sssd/ticket/2770 >From 1661c53bbc0df2efd3a767e25a5c7f33f4b0c717 Mon Sep 17 00:00:00 2001 >From: "Robbie

Re: [SSSD] [DING-LIBS] [INI] [PATCH] Document ini_config_augment alphabetical file processing

On (01/09/15 18:19), Robbie Harwood wrote: >The sorted file processing is a useful guarantee to have, and is >provided by the current code. https://fedorahosted.org/sssd/ticket/2771 >From d11f7814c968cb94d8321e723460391df556e2d6 Mon Sep 17 00:00:00 2001 >From: Robbie Harwood

Re: [SSSD] [PATCHES] cleanup task: Expire all memberof targets when removing user

On 09/01/2015 05:53 PM, Pavel Reichl wrote: On 09/01/2015 04:02 PM, Michal Židek wrote: From 314116b09758e23626021da2f99f57f64846b26b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Michal=20=C5=BDidek?= Date: Mon, 31 Aug 2015 18:21:44 +0200 Subject: [PATCH 1/5] Makefile.am: Add

Re: [SSSD] [PATCHES] cleanup task: Expire all memberof targets when removing user

On 09/01/2015 06:23 PM, Michal Židek wrote: On 09/01/2015 05:53 PM, Pavel Reichl wrote: On 09/01/2015 04:02 PM, Michal Židek wrote: From 314116b09758e23626021da2f99f57f64846b26b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Michal=20=C5=BDidek?= Date: Mon, 31 Aug 2015

Re: [SSSD] [PATCH] [HBAC]: Better libhbac debuging

On 09/01/2015 11:00 AM, Pavel Reichl wrote: From 6b1c6cac7123e78a2c55c51019b66a6bcf97ec29 Mon Sep 17 00:00:00 2001 From: Petr Cech Date: Fri, 24 Jul 2015 10:56:49 -0400 Subject: [PATCH 2/2] HBAC: Better libhbac debugging Added support for logging via external log function.

Re: [SSSD] [PATCH] GPO: use SDAP_SASL_AUTHID as samAccountName

On Tue, Sep 01, 2015 at 02:57:36PM +0200, Sumit Bose wrote: > With this patch the only remaining caller for sss_krb5_get_primary() is > in the same source file. Shall it be made static and removed from > sss_krb5.h? Yes, but in a different patch, please.

Re: [SSSD] [PATCHES] cleanup task: Expire all memberof targets when removing user

On 09/01/2015 02:37 PM, Pavel Reichl wrote: On 08/31/2015 06:53 PM, Michal Židek wrote: 0001-Makefile.am-Add-AM_CFLAGS-for-libsss_ldap_common.patch From b563b44a99c91c75523ea11e18cb7f7552750817 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Michal=20=C5=BDidek?= Date: Mon, 31

Re: [SSSD] [PATCH] GPO: use SDAP_SASL_AUTHID as samAccountName

On Tue, Sep 01, 2015 at 03:14:59PM +0200, Jakub Hrozek wrote: > On Tue, Sep 01, 2015 at 02:57:36PM +0200, Sumit Bose wrote: > > With this patch the only remaining caller for sss_krb5_get_primary() is > > in the same source file. Shall it be made static and removed from > > sss_krb5.h? > > Yes,

Re: [SSSD] [PATCHES] cleanup task: Expire all memberof targets when removing user

On 09/01/2015 04:02 PM, Michal Židek wrote: From 314116b09758e23626021da2f99f57f64846b26b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Michal=20=C5=BDidek?= Date: Mon, 31 Aug 2015 18:21:44 +0200 Subject: [PATCH 1/5] Makefile.am: Add missing AM_CFLAGS Some targets were missing

Re: [SSSD] [PATCH] intg_tests: Add regression test for 2163

On Tue, Sep 01, 2015 at 12:14:25PM +0200, Jakub Hrozek wrote: > On Tue, Sep 01, 2015 at 11:57:36AM +0200, Lukas Slebodnik wrote: > > On (01/09/15 11:55), Jakub Hrozek wrote: > > >On Tue, Sep 01, 2015 at 08:49:49AM +0200, Lukas Slebodnik wrote: > > >> On (24/07/15 17:24), Lukas Slebodnik wrote: > >

Re: [SSSD] [PATCH] GPO: Use sss_unique_file and close fd on failure

On Tue, Sep 01, 2015 at 12:57:14PM +0200, Pavel Březina wrote: > On 09/01/2015 11:54 AM, Jakub Hrozek wrote: > >On Tue, Sep 01, 2015 at 11:28:32AM +0200, Pavel Březina wrote: > >>>Please see the attached patch, does it look better to you? > >> > >>Hi, yes. There is just an indentation error: > >>