Re: [SSSD] I think #2637 is out of scope of 1.13

2015-09-02 Thread Sumit Bose
On Tue, Sep 01, 2015 at 08:19:06PM +0200, Jakub Hrozek wrote: > Hi, > > ssia... > > I was working on implementing https://fedorahosted.org/sssd/ticket/2637 > and while for most occurences it was quite easy to set domain status > instead of back end status, I hit the sdap_id_op module.. > > The

Re: [SSSD] [PATCH v3] Remove trailing whitespace

2015-09-02 Thread Lukas Slebodnik
On (01/09/15 15:36), Nikolai Kondrashov wrote: >On 08/31/2015 09:59 AM, Lukas Slebodnik wrote: >>diff --git a/src/tests/whitespace_test b/src/tests/whitespace_test >>new file mode 100755 >>index >>..508fe2d532cc6a3967af8eaa5c7dc4dccdc653f3 >>--- /dev/null

Re: [SSSD] pep8 warnings in python code

2015-09-02 Thread Lukas Slebodnik
On (01/09/15 14:37), Pavel Reichl wrote: >This patch fixes some of the pep8 warnings (number of issues reported by pep8 >utility changed from 204 to 127). >Should we file a ticket to reduce pep8 warning as much as possible? I suppose >we could even add a test that would fail if new pep8 warning is

[SSSD] Fix #2275 nested netgroups do not work in IPA provider

2015-09-02 Thread Petr Cech
Hi, reverting this commit "5e9bc89b28f1ac3ce573ecdece74fe9623580c28" fixed the problem for me. So is the original commit no longer valid? Regards, Petr >From 3a161789fc8ef82f4636e55369f4c5b04985f7c2 Mon Sep 17 00:00:00 2001 From: Petr Cech Date: Wed, 2 Sep 2015 11:51:12

Re: [SSSD] [WIKI] Contribute and DevelTips are duplicate

2015-09-02 Thread Michal Židek
On 08/17/2015 02:21 PM, Petr Cech wrote: On 07/17/2015 01:26 PM, Petr Cech wrote: Hi, I have read the wiki pages. And I have the edited version. It would be difficult to send the diff, so I started a new pages where you can view the result. Original pages: [ 1]

Re: [SSSD] [WIKI] Contribute and DevelTips are duplicate

2015-09-02 Thread Jakub Hrozek
On Wed, Sep 02, 2015 at 05:18:24PM +0200, Michal Židek wrote: > On 08/17/2015 02:21 PM, Petr Cech wrote: > >On 07/17/2015 01:26 PM, Petr Cech wrote: > >>Hi, > >> > >>I have read the wiki pages. And I have the edited version. It would be > >>difficult to send the diff, so I started a new pages

Re: [SSSD] [WIKI] Contribute and DevelTips are duplicate

2015-09-02 Thread Michal Židek
On 09/02/2015 05:47 PM, Jakub Hrozek wrote: On Wed, Sep 02, 2015 at 05:18:24PM +0200, Michal Židek wrote: On 08/17/2015 02:21 PM, Petr Cech wrote: On 07/17/2015 01:26 PM, Petr Cech wrote: Hi, I have read the wiki pages. And I have the edited version. It would be difficult to send the diff,

Re: [SSSD] Fix #2275 nested netgroups do not work in IPA provider

2015-09-02 Thread Lukas Slebodnik
On (02/09/15 18:06), Petr Cech wrote: >Hi, > >reverting this commit "5e9bc89b28f1ac3ce573ecdece74fe9623580c28" fixed the >problem for me. So is the original commit no longer valid? > I'm little bit worried about reverting this patch. Did you test the bug which was fixed by this commit. @see

Re: [SSSD] [PATCH] SYSDB: Index the objectSIDString attribute

2015-09-02 Thread Lukas Slebodnik
On (19/08/15 18:15), Jakub Hrozek wrote: >On Tue, Aug 18, 2015 at 05:31:43PM +0200, Michal Židek wrote: >> On 08/17/2015 10:35 PM, Jakub Hrozek wrote: >> >Hi, >> > >> >the attached patch was confirmed to work, so the code review should be >> >easy. But because it adds an index to objectSID, which

Re: [SSSD] [PATCH v3] Remove trailing whitespace

2015-09-02 Thread Nikolai Kondrashov
On 09/02/2015 10:05 AM, Lukas Slebodnik wrote: On (01/09/15 15:36), Nikolai Kondrashov wrote: On 08/31/2015 09:59 AM, Lukas Slebodnik wrote: diff --git a/src/tests/whitespace_test b/src/tests/whitespace_test new file mode 100755 index

Re: [SSSD] [PATCH v3] Remove trailing whitespace

2015-09-02 Thread Lukas Slebodnik
On (02/09/15 14:39), Nikolai Kondrashov wrote: >On 09/02/2015 10:05 AM, Lukas Slebodnik wrote: >>On (01/09/15 15:36), Nikolai Kondrashov wrote: >>>On 08/31/2015 09:59 AM, Lukas Slebodnik wrote: diff --git a/src/tests/whitespace_test b/src/tests/whitespace_test new file mode 100755

Re: [SSSD] [PATCH] NSS: Don't ignore backslash in usernames with ldap provider

2015-09-02 Thread Lukas Slebodnik
On (31/08/15 21:01), Sumit Bose wrote: >On Fri, Aug 28, 2015 at 07:23:29AM +0200, Lukas Slebodnik wrote: >> ehlo, >> >> please review attached patch for regression #2772 >> >> LS > >Hi Lukas, > >thank you for taking care of the issue. > >The patch is working as expected without breaking the SID

Re: [SSSD] [PATCH v3] Remove trailing whitespace

2015-09-02 Thread Pavel Reichl
On 09/02/2015 02:25 PM, Jakub Hrozek wrote: On Wed, Sep 02, 2015 at 01:52:42PM +0200, Lukas Slebodnik wrote: On (02/09/15 14:39), Nikolai Kondrashov wrote: I haven't tested it, otherwise ACK. Thank you for review. But It would be good if 3rd person formally ACK the patch because we(both) are

Re: [SSSD] I think #2637 is out of scope of 1.13

2015-09-02 Thread Jakub Hrozek
On Wed, Sep 02, 2015 at 10:11:46AM +0200, Sumit Bose wrote: > On Tue, Sep 01, 2015 at 08:19:06PM +0200, Jakub Hrozek wrote: > > Hi, > > > > ssia... > > > > I was working on implementing https://fedorahosted.org/sssd/ticket/2637 > > and while for most occurences it was quite easy to set domain

Re: [SSSD] [PATCH] NSS: Don't ignore backslash in usernames with ldap provider

2015-09-02 Thread Sumit Bose
On Wed, Sep 02, 2015 at 01:23:11PM +0200, Lukas Slebodnik wrote: > On (31/08/15 21:01), Sumit Bose wrote: > >On Fri, Aug 28, 2015 at 07:23:29AM +0200, Lukas Slebodnik wrote: > >> ehlo, > >> > >> please review attached patch for regression #2772 > >> > >> LS > > > >Hi Lukas, > > > >thank you for

Re: [SSSD] [PATCH v3] Remove trailing whitespace

2015-09-02 Thread Jakub Hrozek
On Wed, Sep 02, 2015 at 01:52:42PM +0200, Lukas Slebodnik wrote: > On (02/09/15 14:39), Nikolai Kondrashov wrote: > >I haven't tested it, otherwise ACK. > > > Thank you for review. But It would be good if 3rd person > formally ACK the patch because we(both) are authors of 2nd patch :-) Pavel, you

Re: [SSSD] [PATCH] CONFDB: Assume config file version 2 if missing

2015-09-02 Thread Lukas Slebodnik
On (01/09/15 12:55), Michal Židek wrote: >On 09/01/2015 11:11 AM, Jakub Hrozek wrote: >>On Tue, Sep 01, 2015 at 11:00:15AM +0200, Lukas Slebodnik wrote: >>>On (01/09/15 10:51), Jakub Hrozek wrote: On Tue, Aug 11, 2015 at 07:47:00AM +0200, Lukas Slebodnik wrote: >On (10/08/15 17:18), Michal

Re: [SSSD] [PATCH] NSS: Don't ignore backslash in usernames with ldap provider

2015-09-02 Thread Lukas Slebodnik
On (02/09/15 14:10), Sumit Bose wrote: >On Wed, Sep 02, 2015 at 01:23:11PM +0200, Lukas Slebodnik wrote: >> On (31/08/15 21:01), Sumit Bose wrote: >> >On Fri, Aug 28, 2015 at 07:23:29AM +0200, Lukas Slebodnik wrote: >> >> ehlo, >> >> >> >> please review attached patch for regression #2772 >> >>

Re: [SSSD] [PATCH] SDAP: Remove unused function

2015-09-02 Thread Pavel Reichl
On 09/02/2015 04:16 PM, Jakub Hrozek wrote: Unused code is broken code, remove it :) ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/sssd-devel Should we improve comment in

[SSSD] [PATCH] SDAP: Remove unused function

2015-09-02 Thread Jakub Hrozek
Unused code is broken code, remove it :) >From e3d8eda8dcf32adbdd001915d0308f16f6e45dfb Mon Sep 17 00:00:00 2001 From: Jakub Hrozek Date: Tue, 1 Sep 2015 17:50:32 +0200 Subject: [PATCH] SDAP: Remove unused function --- src/providers/ldap/ldap_common.c | 5 -