Re: [SSSD] [PATCH] sss_override: amend man page - overrides do not stack

On 10/02/2015 03:19 PM, Pavel Reichl wrote: Hello, please see simple patch attached. Ack. ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/sssd-devel

Re: [SSSD] [PATCH] BUILD: Rename whitespace tests

On 10/02/2015 03:22 PM, Lukas Slebodnik wrote: ehlo, attached patch should fix valgrind issues with whitespace_test Ah, I figured it out finally. Unfortunately that doesn't work on RHEL6 [1], where Automake doesn't support LOG_COMPILER and such and we have to use AUX_TEST_ENVIRONMENT instead.

Re: [SSSD] [PATCH] IPA: Check connection validity explicitly

On Thu, Oct 01, 2015 at 01:41:07PM +0200, Jakub Hrozek wrote: > I don't have a good idea how to reproduce except simulate the failure in > gdb, sorry... at least I verified that after setting the context to NULL: > (gdb) set clist[1] = 0 > the request runs to completion and SSSD doesn't

[SSSD] [PATCH] BUILD: Link just libsss_crypto with crypto libraries

ehlo, Attached patch should prevent such failures as in commit 73ec8fdfddb2d4bf99977f758eec80e1b1ee8542 BUILD: Link test_data_provider_be with -ldl SSS_CRYPT_LIBS should not be part of SSSD_LIBS. all necessary program and libraries should be linked with libsss_cryto.so an do not use

Re: [SSSD] [PATCHES] fix minor memory leaks

On 10/02/2015 10:42 AM, Pavel Reichl wrote: On 09/30/2015 09:21 AM, Pavel Reichl wrote: On 09/29/2015 05:49 PM, Jakub Hrozek wrote: On Tue, Sep 29, 2015 at 02:20:39PM +0200, Pavel Reichl wrote: In my opinion we can drop the change. This is not an imminent bug it's rather code style

Re: [SSSD] [PATCH] PAM: only allow missing user name for certificate

On (02/10/15 12:11), Lukas Slebodnik wrote: >On (02/10/15 10:21), Sumit Bose wrote: >>On Thu, Oct 01, 2015 at 03:12:06PM +0200, Pavel Reichl wrote: >>> >>> >>diff --git a/src/responder/pam/pamsrv_cmd.c >>> >>b/src/responder/pam/pamsrv_cmd.c >>> >>index >>>

Re: [SSSD] [PATCH] util: Include disabled domains in link_forest_roots

On 10/02/2015 07:44 AM, Lukas Slebodnik wrote: On (01/10/15 15:41), Michal Židek wrote: On 10/01/2015 03:08 PM, Lukas Slebodnik wrote: On (01/10/15 13:56), Michal Židek wrote: On 09/16/2015 03:56 PM, Michal Židek wrote: On 09/15/2015 04:03 PM, Jakub Hrozek wrote: On Tue, Sep 15, 2015 at

Re: [SSSD] [PATCH] BUILD: Rename whitespace tests

On 10/02/2015 04:49 PM, Lukas Slebodnik wrote: On (02/10/15 16:09), Nikolai Kondrashov wrote: On 10/02/2015 03:22 PM, Lukas Slebodnik wrote: attached patch should fix valgrind issues with whitespace_test Thank you, Lukas. This seems fine. I have also made another patch which excludes

[SSSD] [PATCH] CI: Exclude whitespace_test from Valgrind checks

On 10/02/2015 04:54 PM, Nikolai Kondrashov wrote: On 10/02/2015 04:49 PM, Lukas Slebodnik wrote: On (02/10/15 16:09), Nikolai Kondrashov wrote: On 10/02/2015 03:22 PM, Lukas Slebodnik wrote: attached patch should fix valgrind issues with whitespace_test Thank you, Lukas. This seems fine. I

Re: [SSSD] [PATCH] BUILD: Rename whitespace tests

On 10/02/2015 04:54 PM, Nikolai Kondrashov wrote: On 10/02/2015 04:49 PM, Lukas Slebodnik wrote: On (02/10/15 16:09), Nikolai Kondrashov wrote: On 10/02/2015 03:22 PM, Lukas Slebodnik wrote: attached patch should fix valgrind issues with whitespace_test Thank you, Lukas. This seems fine. I

[SSSD] [PATCH] sss_override: amend man page - overrides do not stack

Hello, please see simple patch attached. >From da7a3121fc37c2c20b58b716a261ea6de219f493 Mon Sep 17 00:00:00 2001 From: Pavel Reichl Date: Fri, 2 Oct 2015 09:11:51 -0400 Subject: [PATCH] sss_override: amend man page - overrides do not stack --- src/man/sss_override.8.xml | 8

Re: [SSSD] [PATCH] BUILD: Rename whitespace tests

On (02/10/15 16:09), Nikolai Kondrashov wrote: >On 10/02/2015 03:22 PM, Lukas Slebodnik wrote: >>attached patch should fix valgrind issues with whitespace_test > >Thank you, Lukas. This seems fine. I have also made another patch which >excludes whitespace_test from Valgrind run instead of renaming

Re: [SSSD] [PATCHES] fix minor memory leaks

On 09/30/2015 09:21 AM, Pavel Reichl wrote: On 09/29/2015 05:49 PM, Jakub Hrozek wrote: On Tue, Sep 29, 2015 at 02:20:39PM +0200, Pavel Reichl wrote: In my opinion we can drop the change. This is not an imminent bug it's rather code style dispute and I don't think that we have to bother

Re: [SSSD] [PATCH] MAN: proxy and krb5 are valid access control modules

On Thu, Oct 01, 2015 at 08:26:30AM +0300, Alexander Bokovoy wrote: > On Wed, 30 Sep 2015, Jakub Hrozek wrote: > >Hi, > > > >while documenting the security options I realized man sssd.conf doesn't > >include the krb5 and proxy access control modules. I hope I worded the > >sentence about krb5

[SSSD] [PATCH] TEST: recent_valid filter testing

Hi, there is WiP attached. I removed some tests like this one some time ago. They fail really often and we decided that the test logic was corrupted. Now I am trying get it back to the codebase. There is some kind of cmocka magic around data provider. I think it creates test_user_1 during

[SSSD] [PATCH] BUILD: Rename whitespace tests

ehlo, attached patch should fix valgrind issues with whitespace_test LS >From 0cab2c68751a2601c352fa38a48c27a6685ca469 Mon Sep 17 00:00:00 2001 From: Lukas Slebodnik Date: Fri, 2 Oct 2015 14:18:16 +0200 Subject: [PATCH] BUILD: Rename whitespace tests Tests with suffix .sh

Re: [SSSD] [PATCH] SDAP: Relax POSIX check

On 10/02/2015 12:43 PM, Jakub Hrozek wrote: On Fri, Oct 02, 2015 at 12:29:01PM +0200, Jakub Hrozek wrote: On Thu, Oct 01, 2015 at 08:44:11PM +0200, Jakub Hrozek wrote: On Thu, Oct 01, 2015 at 08:39:15PM +0200, Jakub Hrozek wrote: On Thu, Oct 01, 2015 at 08:31:50PM +0200, Lukas Slebodnik

Re: [SSSD] RFC: intg: Add basic user/group/membership change tests

On 10/02/2015 08:57 AM, Lukas Slebodnik wrote: On (23/09/15 15:42), Nikolai Kondrashov wrote: Hi everyone, I'm working on adding more LDAP integration tests upstream and here are some first results: basic user/group/membership addition/removal tests. Admittedly they're very basic, although

Re: [SSSD] [PATCH] MAN: Clarify pam_trusted_users option description

On Thu, Oct 01, 2015 at 08:27:53AM +0300, Alexander Bokovoy wrote: > On Wed, 30 Sep 2015, Jakub Hrozek wrote: > >Hi, > > > >while working on the hardening wiki page, I realized the > >pam_trusted_users option can be improved. Please see the attached patch. > ACK, this is much better explanation

Re: [SSSD] Add Catalan support in sssd

On Thu, Oct 01, 2015 at 10:10:47PM +0200, Jakub Hrozek wrote: > On Thu, Oct 01, 2015 at 09:28:48PM +0200, Robert Antoni Buj i Gelonch wrote: > > Hi, > > > > This patch adds Catalan support. Both /src/man/po/ca.po & po/ca.po files > > exit but they are not used to generate and distribute the

Re: [SSSD] [PATCH] sss tools: improve option handling

On (02/10/15 10:38), Pavel Reichl wrote: >After applying the patch I can't replicate the crash. >CI passed: http://sssd-ci.duckdns.org/logs/job/28/11/summary.html > >ACK master: * bda8039465a0084fb380e878c8f9ea3e900505ea sssd-1-13: * 4d5e7e548865bffec5b8656ecb81c73887949c75 LS

Re: [SSSD] [PATCH] SDAP: Relax POSIX check

On Fri, Oct 02, 2015 at 12:43:01PM +0200, Jakub Hrozek wrote: > * master: 6735c0451d4e80d7cd4b480a8c1f7dafb2b536ea * sssd-1-13: cc04876ec64b338f61ca275386f70baf91ce700f ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org

Re: [SSSD] [PATCH] sss tools: improve option handling

After applying the patch I can't replicate the crash. CI passed: http://sssd-ci.duckdns.org/logs/job/28/11/summary.html ACK ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/sssd-devel

Re: [SSSD] [PATCH] PAM: only allow missing user name for certificate

On (02/10/15 10:21), Sumit Bose wrote: >On Thu, Oct 01, 2015 at 03:12:06PM +0200, Pavel Reichl wrote: >> >> >>diff --git a/src/responder/pam/pamsrv_cmd.c >> >>b/src/responder/pam/pamsrv_cmd.c >> >>index >> >>27dddcf43c1ff6eb465e1cb58d6dddf21413dcc4..978c637e22b03d3be1e07e8dc713aa01c4bb22e5 >>

Re: [SSSD] RFC: intg: Add basic user/group/membership change tests

On Fri, Oct 02, 2015 at 07:57:52AM +0200, Lukas Slebodnik wrote: > On (23/09/15 15:42), Nikolai Kondrashov wrote: > >Hi everyone, > > > >I'm working on adding more LDAP integration tests upstream and here are some > >first results: basic user/group/membership addition/removal tests. > > >

Re: [SSSD] [PATCH] TEST: recent_valid filter testing

There is previous commit to this ticket, so you can see what tests were removed. https://git.fedorahosted.org/cgit/sssd.git/commit/?id=bdf422fde0fd6b40b3412bad3b200f8fd7ea8693 ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org

Re: [SSSD] [PATCH] PAM: only allow missing user name for certificate

On Thu, Oct 01, 2015 at 03:12:06PM +0200, Pavel Reichl wrote: > > >>diff --git a/src/responder/pam/pamsrv_cmd.c b/src/responder/pam/pamsrv_cmd.c > >>index > >>27dddcf43c1ff6eb465e1cb58d6dddf21413dcc4..978c637e22b03d3be1e07e8dc713aa01c4bb22e5 > >> 100644 > >>--- a/src/responder/pam/pamsrv_cmd.c >

Re: [SSSD] [PATCH] SDAP: Relax POSIX check

On Fri, Oct 02, 2015 at 12:29:01PM +0200, Jakub Hrozek wrote: > On Thu, Oct 01, 2015 at 08:44:11PM +0200, Jakub Hrozek wrote: > > On Thu, Oct 01, 2015 at 08:39:15PM +0200, Jakub Hrozek wrote: > > > On Thu, Oct 01, 2015 at 08:31:50PM +0200, Lukas Slebodnik wrote: > > > > On (01/10/15 20:13), Jakub

Re: [SSSD] [PATCH] SDAP: Relax POSIX check

On Thu, Oct 01, 2015 at 08:44:11PM +0200, Jakub Hrozek wrote: > On Thu, Oct 01, 2015 at 08:39:15PM +0200, Jakub Hrozek wrote: > > On Thu, Oct 01, 2015 at 08:31:50PM +0200, Lukas Slebodnik wrote: > > > On (01/10/15 20:13), Jakub Hrozek wrote: > > > >On Fri, Sep 25, 2015 at 07:49:23AM +0200, Lukas

Re: [SSSD] RFC: intg: Add basic user/group/membership change tests

On (02/10/15 11:08), Jakub Hrozek wrote: >On Fri, Oct 02, 2015 at 07:57:52AM +0200, Lukas Slebodnik wrote: >> On (23/09/15 15:42), Nikolai Kondrashov wrote: >> >Hi everyone, >> > >> >I'm working on adding more LDAP integration tests upstream and here are some >> >first results: basic

Re: [SSSD] [PATCH] SDAP: Relax POSIX check

On Fri, Oct 02, 2015 at 09:45:32AM +0200, Pavel Reichl wrote: > > > On 10/01/2015 08:44 PM, Jakub Hrozek wrote: > >On Thu, Oct 01, 2015 at 08:39:15PM +0200, Jakub Hrozek wrote: > >>On Thu, Oct 01, 2015 at 08:31:50PM +0200, Lukas Slebodnik wrote: > >>>On (01/10/15 20:13), Jakub Hrozek wrote: >

Re: [SSSD] [PATCH] Add a client-side hook to prevent pushes without Reviewed-By

On (30/09/15 09:22), Jakub Hrozek wrote: >On Tue, Sep 29, 2015 at 08:28:30AM +0200, Lukas Slebodnik wrote: >> On (28/09/15 14:19), Jakub Hrozek wrote: >> >Hi, >> > >> >to activate this hook, copy it from contrib to .git/hooks and make sure >> >the executable flag is on. Attempting to push a commit

Re: [SSSD] [PATCHES] fix minor memory leaks

On Fri, Oct 02, 2015 at 11:42:49AM +0200, Pavel Březina wrote: > Ack to all. * master: * 8c9ecf0bd04be87a61d5f0e490ab8a7c48f481dd * 3fa03d5816d6a401d8e894b77236d3cfd95dbd96 * a2d6d4db64a7c3b27dea22fe52245925d688bd2d * 12440d2acbeb7ea6e5c0e4182d00377c8d01185b

Re: [SSSD] [PATCH] Add a client-side hook to prevent pushes without Reviewed-By

On (02/10/15 13:02), Lukas Slebodnik wrote: >On (30/09/15 09:22), Jakub Hrozek wrote: >>On Tue, Sep 29, 2015 at 08:28:30AM +0200, Lukas Slebodnik wrote: >>> On (28/09/15 14:19), Jakub Hrozek wrote: >>> >Hi, >>> > >>> >to activate this hook, copy it from contrib to .git/hooks and make sure >>> >the

Re: [SSSD] [PATCH] CI: Exclude whitespace_test from Valgrind checks

On 10/02/2015 05:23 PM, Nikolai Kondrashov wrote: Alright, here's the patch. I also added a slash before dlopen-tests in the pattern to make it slightly more specific. It doesn't break anything. I can make a separate patch, if necessary. CI results:

[SSSD] [PATCH] Don't skip tests not checked with Valgrind + extra

Hi everyone, I've found an embarrassing logic failure in my Valgrind execution design in CI: tests which were excluded from Valgrind checks weren't running at all, instead of just running without Valgrind. The first attached patch fixes that. The second patch makes CI handle test executables

Re: [SSSD] [PATCH] Don't skip tests not checked with Valgrind + extra

On 10/02/2015 07:15 PM, Nikolai Kondrashov wrote: Hi everyone, I've found an embarrassing logic failure in my Valgrind execution design in CI: tests which were excluded from Valgrind checks weren't running at all, instead of just running without Valgrind. The first attached patch fixes that.

Re: [SSSD] [PATCH] CI: Exclude whitespace_test from Valgrind checks

On (02/10/15 17:23), Nikolai Kondrashov wrote: >On 10/02/2015 04:54 PM, Nikolai Kondrashov wrote: >>On 10/02/2015 04:49 PM, Lukas Slebodnik wrote: >>>On (02/10/15 16:09), Nikolai Kondrashov wrote: On 10/02/2015 03:22 PM, Lukas Slebodnik wrote: >attached patch should fix valgrind issues

Re: [SSSD] [PATCH] CI: Exclude whitespace_test from Valgrind checks

On (02/10/15 20:55), Lukas Slebodnik wrote: >On (02/10/15 17:23), Nikolai Kondrashov wrote: >>On 10/02/2015 04:54 PM, Nikolai Kondrashov wrote: >>>On 10/02/2015 04:49 PM, Lukas Slebodnik wrote: On (02/10/15 16:09), Nikolai Kondrashov wrote: >On 10/02/2015 03:22 PM, Lukas Slebodnik wrote:

Re: [SSSD] [PATCH] sbus codegen tests: free ctx

On (01/10/15 15:25), Lukas Slebodnik wrote: >On (01/10/15 14:36), Pavel Březina wrote: >>https://fedorahosted.org/sssd/ticket/2759 > >>From ad00807733ed3150d06615de035c6662af067673 Mon Sep 17 00:00:00 2001 >>From: =?UTF-8?q?Pavel=20B=C5=99ezina?= >>Date: Thu, 1 Oct 2015

Re: [SSSD] [PATCH] sbus codegen tests: free ctx

On (01/10/15 14:36), Pavel Březina wrote: >https://fedorahosted.org/sssd/ticket/2759 >From ad00807733ed3150d06615de035c6662af067673 Mon Sep 17 00:00:00 2001 >From: =?UTF-8?q?Pavel=20B=C5=99ezina?= >Date: Thu, 1 Oct 2015 14:34:51 +0200 >Subject: [PATCH] sbus codegen tests:

Re: [SSSD] [PATCH] GPO: fix memory leak

On (07/09/15 18:56), Jakub Hrozek wrote: >On Mon, Sep 07, 2015 at 05:36:18PM +0200, Michal Židek wrote: >> On 09/03/2015 10:53 AM, Pavel Reichl wrote: >> >Hello, >> > >> >please see simple patch attached. >> > >> >Thanks! >> > >> >> ACK. >> >> CI passed:

Re: [SSSD] [PATCH] util: Include disabled domains in link_forest_roots

On (01/10/15 15:41), Michal Židek wrote: >On 10/01/2015 03:08 PM, Lukas Slebodnik wrote: >>On (01/10/15 13:56), Michal Židek wrote: >>>On 09/16/2015 03:56 PM, Michal Židek wrote: On 09/15/2015 04:03 PM, Jakub Hrozek wrote: >On Tue, Sep 15, 2015 at 03:53:41PM +0200, Michal Židek wrote:

Re: [SSSD] RFC: intg: Add basic user/group/membership change tests

On (23/09/15 15:42), Nikolai Kondrashov wrote: >Hi everyone, > >I'm working on adding more LDAP integration tests upstream and here are some >first results: basic user/group/membership addition/removal tests. > >Admittedly they're very basic, although needed some research first. > >What I'd like

Re: [SSSD] [PATCH] SDAP: Relax POSIX check

On 10/01/2015 08:44 PM, Jakub Hrozek wrote: On Thu, Oct 01, 2015 at 08:39:15PM +0200, Jakub Hrozek wrote: On Thu, Oct 01, 2015 at 08:31:50PM +0200, Lukas Slebodnik wrote: On (01/10/15 20:13), Jakub Hrozek wrote: On Fri, Sep 25, 2015 at 07:49:23AM +0200, Lukas Slebodnik wrote: There is a