Re: [SSSD] [PATCH] CI: Enforce coverage make check failures

On (23/06/15 17:01), Lukas Slebodnik wrote: >On (17/06/15 16:26), Nikolai Kondrashov wrote: >>Hi everyone, >> >>The attached patch enforces make check failures for the CI coverage build, so >>we can catch more test failures. >> >>I think this should also be applied onto sssd-1-12. >> >>NOTE: CI

Re: [SSSD] [PATCH] intg: Add more LDAP tests

On (06/10/15 11:27), Jakub Hrozek wrote: >On Wed, Sep 30, 2015 at 06:15:52PM +0300, Nikolai Kondrashov wrote: >> Hi everyone, >> >> Here is a patch set fixing some things in integration tests and adding more >> LDAP tests: > >(Not a full review, just adding my ideas and impressions) > >I read

Re: [SSSD] More upstream CI tests

On Wed, Oct 07, 2015 at 08:58:32AM +0200, Lukas Slebodnik wrote: > On (31/08/15 12:31), Jakub Hrozek wrote: > >On Fri, Aug 28, 2015 at 03:16:57PM +0200, Lukas Slebodnik wrote: > >> On (19/08/15 23:38), Jakub Hrozek wrote: > >> >Hi, > >> > > >> >as we're stabilizing the 1.13 branch and before we

Re: [SSSD] More upstream CI tests

On Wed, Oct 07, 2015 at 10:28:43AM +0200, Pavel Reichl wrote: > Yes, that's how the test are. I'll send the first version on list today. I > just need to resolve some final glitches. That's nice to hear that the tests will be added, but based on trac priorities I was expecting the PAM responder

Re: [SSSD] More upstream CI tests

On (07/10/15 10:23), Jakub Hrozek wrote: >On Wed, Oct 07, 2015 at 08:58:32AM +0200, Lukas Slebodnik wrote: >> On (31/08/15 12:31), Jakub Hrozek wrote: >> >On Fri, Aug 28, 2015 at 03:16:57PM +0200, Lukas Slebodnik wrote: >> >> On (19/08/15 23:38), Jakub Hrozek wrote: >> >> >Hi, >> >> > >> >> >as

Re: [SSSD] More upstream CI tests

On Wed, Oct 07, 2015 at 10:38:44AM +0200, Lukas Slebodnik wrote: > On (07/10/15 10:23), Jakub Hrozek wrote: > >On Wed, Oct 07, 2015 at 08:58:32AM +0200, Lukas Slebodnik wrote: > >> On (31/08/15 12:31), Jakub Hrozek wrote: > >> >On Fri, Aug 28, 2015 at 03:16:57PM +0200, Lukas Slebodnik wrote: > >>

Re: [SSSD] More upstream CI tests

On 10/07/2015 10:23 AM, Jakub Hrozek wrote: On Wed, Oct 07, 2015 at 08:58:32AM +0200, Lukas Slebodnik wrote: On (31/08/15 12:31), Jakub Hrozek wrote: On Fri, Aug 28, 2015 at 03:16:57PM +0200, Lukas Slebodnik wrote: On (19/08/15 23:38), Jakub Hrozek wrote: Hi, as we're stabilizing the 1.13

Re: [SSSD] [PATCH] IPA: Check connection validity explicitly

On Tue, Oct 06, 2015 at 12:54:41PM +0200, Jakub Hrozek wrote: > On Mon, Oct 05, 2015 at 04:46:55PM +0200, Jakub Hrozek wrote: > > On Mon, Oct 05, 2015 at 12:33:48PM +0200, Sumit Bose wrote: > > > On Mon, Oct 05, 2015 at 12:08:26PM +0200, Jakub Hrozek wrote: > > > > On Fri, Oct 02, 2015 at

Re: [SSSD] [PATCH] IPA: Check connection validity explicitly

On Wed, Oct 07, 2015 at 12:28:33PM +0200, Sumit Bose wrote: > ACK > > bye, > Sumit Thank you for the review: master: 309aa83d16b5919f727af04850bcd0799ba0962f afb21fd06690a0bec288a7970abf74ed2ea7dfdc sssd-1-13: 15a4b34ccfcfbcec2c9ba529d0113adf251abc16

Re: [SSSD] [PATCH] GPO: fix memory leak

On (02/10/15 09:06), Lukas Slebodnik wrote: >On (07/09/15 18:56), Jakub Hrozek wrote: >>On Mon, Sep 07, 2015 at 05:36:18PM +0200, Michal Židek wrote: >>> On 09/03/2015 10:53 AM, Pavel Reichl wrote: >>> >Hello, >>> > >>> >please see simple patch attached. >>> > >>> >Thanks! >>> > >>> >>> ACK. >>>

Re: [SSSD] [PATCH] intg: Add more LDAP tests

On 10/07/2015 10:51 AM, Lukas Slebodnik wrote: On (06/10/15 11:27), Jakub Hrozek wrote: On Wed, Sep 30, 2015 at 06:15:52PM +0300, Nikolai Kondrashov wrote: Remove "_rfc2307" from integration test function names for brevity. Please do not remove sanity_rfc2307 from this test. It was added

Re: [SSSD] [PATCH] sss_override fixes

On 10/07/2015 04:12 PM, Pavel Reichl wrote: On 10/07/2015 02:46 PM, Pavel Březina wrote: Hi, the first two patches are just nitpicks. The last patch fixes a memory violation. ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org

Re: [SSSD] [PATCH] typos in integration tests

On 10/07/2015 02:48 PM, Pavel Březina wrote: No big deal... 0001-intg-fix-typos.patch From 923d5626fd3cefaf0620c64aecacfba26b439250 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pavel=20B=C5=99ezina?= Date: Wed, 7 Oct 2015 14:16:38 +0200 Subject: [PATCH] intg: fix typos

Re: [SSSD] [PATCHSET] intg: sss_override

On (07/10/15 14:25), Pavel Reichl wrote: >Hello, > >please see first version of patch set. Please consider this to be work in >progress. > >The test 'test_local_override_group' fails, there seem to be a bug in >sss_override. Pavel is working on the patch. He kindly provided me with early

Re: [SSSD] [PATCHSET] intg: sss_override

On 10/07/2015 02:55 PM, Lukas Slebodnik wrote: On (07/10/15 14:25), Pavel Reichl wrote: Hello, please see first version of patch set. Please consider this to be work in progress. The test 'test_local_override_group' fails, there seem to be a bug in sss_override. Pavel is working on the

Re: [SSSD] [PATCH] intg: Add more LDAP tests

On 10/06/2015 12:27 PM, Jakub Hrozek wrote: On Wed, Sep 30, 2015 at 06:15:52PM +0300, Nikolai Kondrashov wrote: Hi everyone, Here is a patch set fixing some things in integration tests and adding more LDAP tests: (Not a full review, just adding my ideas and impressions) I read these patches

[SSSD] [PATCH] sss_override fixes

Hi, the first two patches are just nitpicks. The last patch fixes a memory violation. From 179d51316bd9c7f44075b87e71524f5b14b99ded Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pavel=20B=C5=99ezina?= Date: Wed, 7 Oct 2015 11:23:00 +0200 Subject: [PATCH 1/4] sss_override: fix

Re: [SSSD] [PATCH] man: Minor fixes to filter_groups description

On Tue, Oct 06, 2015 at 11:29:58AM +0200, Jakub Hrozek wrote: > On Wed, Sep 30, 2015 at 06:48:44PM +0300, Nikolai Kondrashov wrote: > > Hi everyone, > > > > I noticed one little thing was wrong with the combined > > filter_users/filter_groups description on the sssd.conf(5) manpage and also > >

[SSSD] [PATCHSET] intg: sss_override

Hello, please see first version of patch set. Please consider this to be work in progress. The test 'test_local_override_group' fails, there seem to be a bug in sss_override. Pavel is working on the patch. He kindly provided me with early version of patch and it fixed the test. Currently

[SSSD] [PATCH] typos in integration tests

No big deal... From 923d5626fd3cefaf0620c64aecacfba26b439250 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pavel=20B=C5=99ezina?= Date: Wed, 7 Oct 2015 14:16:38 +0200 Subject: [PATCH] intg: fix typos --- src/tests/intg/sssd_id.py | 6 +++--- 1 file changed, 3 insertions(+), 3

Re: [SSSD] [PATCH] sss_override fixes

On 10/07/2015 02:46 PM, Pavel Březina wrote: Hi, the first two patches are just nitpicks. The last patch fixes a memory violation. ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org

Re: [SSSD] [PATCH] intg: Add more LDAP tests

On Wed, Oct 07, 2015 at 04:02:32PM +0300, Nikolai Kondrashov wrote: > On 10/06/2015 12:27 PM, Jakub Hrozek wrote: > >On Wed, Sep 30, 2015 at 06:15:52PM +0300, Nikolai Kondrashov wrote: > >>Hi everyone, > >> > >>Here is a patch set fixing some things in integration tests and adding more > >>LDAP

Re: [SSSD] Review of umask() in SSSD

On 10/04/2015 09:39 PM, Jakub Hrozek wrote: Finally, because I'm a lazy reviewer, I would prefer: - a patch that converts 0177 to DFL, with a comment around the macro definition that this is the default secure umask - a patch that converts 0077 to DFL_X, with a comment around

Re: [SSSD] [PATCH] cache_req: support UPN

On Wed, Oct 07, 2015 at 04:22:31PM +0200, Sumit Bose wrote: > On Wed, Oct 07, 2015 at 02:42:18PM +0200, Pavel Březina wrote: > > On 10/06/2015 03:16 PM, Pavel Březina wrote: > > >On 10/01/2015 05:06 PM, Sumit Bose wrote: > > >>On Thu, Sep 17, 2015 at 11:06:30AM +0200, Pavel Březina wrote: > >

Re: [SSSD] [PATCH] cache_req: support UPN

On Wed, Oct 07, 2015 at 02:42:18PM +0200, Pavel Březina wrote: > On 10/06/2015 03:16 PM, Pavel Březina wrote: > >On 10/01/2015 05:06 PM, Sumit Bose wrote: > >>On Thu, Sep 17, 2015 at 11:06:30AM +0200, Pavel Březina wrote: > >>>On 09/17/2015 10:32 AM, Petr Cech wrote: > Hi Pavel! > >

Re: [SSSD] [PATCH v2] intg: Add more LDAP tests

On 09/30/2015 06:15 PM, Nikolai Kondrashov wrote: Hi everyone, Here is a patch set fixing some things in integration tests and adding more LDAP tests: * Adding/removing a user/group/membership with rfc2307(bis) schema. * Filtering users/groups with rfc2307(bis) schema. * The

Re: [SSSD] More upstream CI tests

On (31/08/15 12:31), Jakub Hrozek wrote: >On Fri, Aug 28, 2015 at 03:16:57PM +0200, Lukas Slebodnik wrote: >> On (19/08/15 23:38), Jakub Hrozek wrote: >> >Hi, >> > >> >as we're stabilizing the 1.13 branch and before we plan what we want to >> >work on during the 1.14 development, we should use

Re: [SSSD] [PATCHSET] intg: sss_override

On 10/07/2015 03:25 PM, Pavel Reichl wrote: Hello, please see first version of patch set. Please consider this to be work in progress. The test 'test_local_override_group' fails, there seem to be a bug in sss_override. Pavel is working on the patch. He kindly provided me with early version

Re: [SSSD] More upstream CI tests

On 10/07/2015 08:58 AM, Lukas Slebodnik wrote: On (31/08/15 12:31), Jakub Hrozek wrote: On Fri, Aug 28, 2015 at 03:16:57PM +0200, Lukas Slebodnik wrote: On (19/08/15 23:38), Jakub Hrozek wrote: Hi, as we're stabilizing the 1.13 branch and before we plan what we want to work on during the

Re: [SSSD] [PATCHSET] intg: sss_override

On 10/07/2015 07:10 PM, Pavel Reichl wrote: We can use either mine (after modifications) or yours. I suppose yours are closer to be acked so we should probably use yours. I'm not so sure, but alright :) All valid comments, but I will ignore them for now as I suppose this patch will be