Re: [SSSD] [PATCH] sss_override: add -find and -show

Hello, thanks for patches. Please see comments inline. +static errno_t user_export(const char *filename, + struct sss_domain_info *dom, + bool iterate) +{ +TALLOC_CTX *tmp_ctx; +struct sss_colondb *db; +struct override_user *objs;

Re: [SSSD] [PATCH] DEBUG: Preventing chown_debug_file if journald on

On 10/05/2015 10:21 AM, Jakub Hrozek wrote: On Fri, Sep 25, 2015 at 02:05:14PM +0200, Petr Cech wrote: ping I can't start sssd as a service with this patch applied after switching from root to non-root: 1) add user=sssd to the [sssd] section 2) chown root.root /var/log/sssd/*.log

[SSSD] [PATCH] spec: Missing initgroups mmap file

Hi, I noticed there is missing initgroups memory cache file among the memory cache files in the spec file. See the attached patch. Michal >From 921da357ffeb177a6e27ebb424d6e3d54fab5195 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Michal=20=C5=BDidek?= Date: Wed, 21 Oct 2015

Re: [SSSD] [PATCHES] util: Continue if setlocale fails

On 10/21/2015 07:28 PM, Michal Židek wrote: Nick asked me to provide some explanation on the issue so I put it here, please correct me if I say something wrong. The problem seems to be that the nss client code only checks validity of the memcache when the memcache context is created. Long

Re: [SSSD] [PATCHES] util: Continue if setlocale fails

On 10/19/2015 04:21 PM, Lukas Slebodnik wrote: On (19/10/15 16:03), Michal Židek wrote: Hi, attached is patch to fix ticket: https://fedorahosted.org/sssd/ticket/2785 And one additional patch to add DEBUG message. Michal From 3227027c3680b4503477135608969ca904e491c7 Mon Sep 17 00:00:00

Re: [SSSD] [PATCHES] util: Continue if setlocale fails

On 10/21/2015 06:48 PM, Nikolai Kondrashov wrote: On 10/21/2015 07:28 PM, Michal Židek wrote: Nick asked me to provide some explanation on the issue so I put it here, please correct me if I say something wrong. The problem seems to be that the nss client code only checks validity of the

Re: [SSSD] [PATCHES] util: Continue if setlocale fails

On 10/21/2015 06:28 PM, Michal Židek wrote: + +def test_wrong_LC_ALL(local_domain_only): +""" +Regression test for ticket +https://fedorahosted.org/sssd/ticket/2785 + +""" +subprocess.call(["sss_useradd", "foo", "-M"]) +pwd.getpwnam("foo") + +# Change the LC_ALL

Re: [SSSD] [PATCH] util: Include disabled domains in link_forest_roots

On 10/15/2015 04:06 PM, Michal Židek wrote: On 10/13/2015 05:09 PM, Jakub Hrozek wrote: On Tue, Oct 13, 2015 at 04:19:22PM +0200, Jakub Hrozek wrote: On Tue, Oct 13, 2015 at 02:56:35PM +0200, Michal Židek wrote: On 10/12/2015 10:31 AM, Jakub Hrozek wrote: On Fri, Oct 09, 2015 at 03:14:52PM

Re: [SSSD] [PATCHES] util: Continue if setlocale fails

On 10/21/2015 06:40 PM, Pavel Reichl wrote: On 10/21/2015 06:28 PM, Michal Židek wrote: + +def test_wrong_LC_ALL(local_domain_only): +""" +Regression test for ticket +https://fedorahosted.org/sssd/ticket/2785 + +""" +subprocess.call(["sss_useradd", "foo", "-M"]) +

Re: [SSSD] [PATCHES] util: Continue if setlocale fails

On 10/21/2015 07:19 PM, Michal Židek wrote: On 10/21/2015 06:40 PM, Pavel Reichl wrote: On 10/21/2015 06:28 PM, Michal Židek wrote: + +def test_wrong_LC_ALL(local_domain_only): +""" +Regression test for ticket +https://fedorahosted.org/sssd/ticket/2785 + +""" +

Re: [SSSD] [PATCH] sss_override: Add restart requirements to man page

Pavel, Here you go, some minor grammatical edits. --- diff --git a/src/man/sss_override.8.xml b/src/man/sss_override.8.xml index 24c3893..785e264 100644 --- a/src/man/sss_override.8.xml +++ b/src/man/sss_override.8.xml @@ -34,8 +34,13 @@ and groups. This change takes effect only on local

Re: [SSSD] [PATCH] sss_override: Add restart requirements to man page

On 10/21/2015 12:39 PM, Pavel Reichl wrote: Hello, while reviewing integration tests for sss_override Nick noticed that man page does not mention restart requirements. Attached patch (attempts to) address that. Thanks! ___ sssd-devel mailing list

Re: [SSSD] Review of umask() in SSSD

On 10/12/2015 11:37 AM, Jakub Hrozek wrote: > From a15acee2495ee12190e711f3344e14c54fc73062 Mon Sep 17 00:00:00 2001 >From: Petr Cech >Date: Wed, 7 Oct 2015 08:57:15 -0400 >Subject: [PATCH 10/11] KRB5_CHILD: More restrictive umask > >We could use more restrictive umask in

Re: [SSSD] Running tests with different environment

On Tue, Oct 20, 2015 at 10:15:06PM +0200, Jakub Hrozek wrote: > On Tue, Oct 20, 2015 at 05:17:49PM +0300, Nikolai Kondrashov wrote: > > Hi Jakub, > > > > On 10/19/2015 09:43 PM, Jakub Hrozek wrote: > > >I'm working on pam_sss.so tests[1] and I ran into a problem that I don't > > >know how to

Re: [SSSD] [PATCH] sss_override: add -find and -show

On 10/20/2015 10:15 PM, Jakub Hrozek wrote: On Tue, Oct 20, 2015 at 02:21:50PM +0200, Pavel Reichl wrote: On 10/20/2015 02:10 PM, Jakub Hrozek wrote: On Tue, Oct 20, 2015 at 01:02:36PM +0200, Pavel Březina wrote: https://fedorahosted.org/sssd/ticket/2736 The first two patches fix small

[SSSD] [PATCH] sss_override: Remove unused parameter tool_ctx

Hello, please see simple patch attached. Thanks. >From 56acf9d5f01c75408aecbafe679b214d8c57a405 Mon Sep 17 00:00:00 2001 From: Pavel Reichl Date: Wed, 21 Oct 2015 11:15:32 +0200 Subject: [PATCH] sss_override: Remove unused parameter tool_ctx ---

Re: [SSSD] [PATCH] sss_override: Add restart requirements to man page

On 10/21/2015 12:39 PM, Pavel Reichl wrote: Hello, while reviewing integration tests for sss_override Nick noticed that man page does not mention restart requirements. Attached patch (attempts to) address that. Thanks! LGTM ___ sssd-devel mailing

Re: [SSSD] [PATCH] sss_override: Remove unused parameter tool_ctx

On 10/21/2015 11:24 AM, Pavel Reichl wrote: Hello, please see simple patch attached. Thanks. ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/sssd-devel ACk.

Re: [SSSD] [PATCH] Use refcount to keep track of server structures returned from failover

On 10/11/2015 10:00 PM, Jakub Hrozek wrote: Hi, the attached patches are my proposal to fix https://fedorahosted.org/sssd/ticket/2829 I haven't tested them past make check yet, because I'm not sure I like them myself :) but at the same time I can't see a better way to keep track of the servers

Re: [SSSD] [PATCHSET] intg: sss_override

On 10/20/2015 05:15 PM, Pavel Reichl wrote: On 10/20/2015 03:12 PM, Nikolai Kondrashov wrote: Hi Pavel, On 10/13/2015 12:22 AM, Pavel Reichl wrote: Please see updated patchset. Thank you for working on this. Please see my comments below. First of all, we need the test in Makefile.am, so

Re: [SSSD] [PATCHSET] intg: sss_override

On 10/20/2015 08:36 PM, Pavel Reichl wrote: Nick I went ahead and started to reworking the patch in the direction you proposed. Could you check that this wip patch is what you had in mind? Thanks! Sure! Overall, I think the general scheme of separating tests you're doing is great! See below

[SSSD] [PATCH] sss_override: Add restart requirements to man page

Hello, while reviewing integration tests for sss_override Nick noticed that man page does not mention restart requirements. Attached patch (attempts to) address that. Thanks! >From 138dfdfdc5a7f4fac9af335167bdcf4685a53db0 Mon Sep 17 00:00:00 2001 From: Pavel Reichl

Re: [SSSD] [PATCHSET] intg: sss_override

On 10/21/2015 11:31 AM, Nikolai Kondrashov wrote: On 10/20/2015 05:15 PM, Pavel Reichl wrote: On 10/20/2015 03:12 PM, Nikolai Kondrashov wrote: Hi Pavel, On 10/13/2015 12:22 AM, Pavel Reichl wrote: Please see updated patchset. Thank you for working on this. Please see my comments

Re: [SSSD] [PATCH] sss_override: Remove unused parameter tool_ctx

On 10/21/2015 01:17 PM, Lukas Slebodnik wrote: On (21/10/15 11:45), Pavel Březina wrote: On 10/21/2015 11:24 AM, Pavel Reichl wrote: Hello, please see simple patch attached. Thanks. ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org

Re: [SSSD] [PATCH] sss_override: Remove unused parameter tool_ctx

On 10/21/2015 01:17 PM, Lukas Slebodnik wrote: On (21/10/15 11:45), Pavel Březina wrote: On 10/21/2015 11:24 AM, Pavel Reichl wrote: Hello, please see simple patch attached. Thanks. ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org

Re: [SSSD] [PATCH] sss_override: Remove unused parameter tool_ctx

On (21/10/15 13:30), Pavel Reichl wrote: >On 10/21/2015 01:17 PM, Lukas Slebodnik wrote: >>On (21/10/15 11:45), Pavel Březina wrote: >>>On 10/21/2015 11:24 AM, Pavel Reichl wrote: Hello, please see simple patch attached. Thanks.

Re: [SSSD] [PATCH] sss_override: Remove unused parameter tool_ctx

On (21/10/15 11:45), Pavel Březina wrote: >On 10/21/2015 11:24 AM, Pavel Reichl wrote: >>Hello, >> >>please see simple patch attached. >> >>Thanks. >> >> >>___ >>sssd-devel mailing list >>sssd-devel@lists.fedorahosted.org

Re: [SSSD] [PATCH] Use refcount to keep track of server structures returned from failover

On Sun, Oct 11, 2015 at 10:00:52PM +0200, Jakub Hrozek wrote: > Hi, > > the attached patches are my proposal to fix > https://fedorahosted.org/sssd/ticket/2829 > > I haven't tested them past make check yet Now I did; all downstream tests I ran passed. Feel free to ping me for test results.