Re: [SSSD] [PATCH] TEST: recent_valid filter testing

On 10/23/2015 12:57 PM, Jakub Hrozek wrote: Thank you, I think your approach is correct. Your test essentially tests that testuser2 was on the server but was removed, so only testuser1 is returned. It's correct, but because the interface is able to return more users, I would prefer if we tested

Re: [SSSD] [PATCH] DEBUG: Preventing chown_debug_file if journald on

On (14/09/15 16:36), Petr Cech wrote: >On 09/11/2015 11:02 AM, Lukas Slebodnik wrote: >>I do not understand how is the function chown_debug_file related to journald. >>sssd can be compiled with journald support and in the same time can log to the >>files. This is a default for fedora and rehl7. >>

Re: [SSSD] [PATCH] DEBUG: Preventing chown_debug_file if journald on

On (27/10/15 10:39), Lukas Slebodnik wrote: >On (14/09/15 16:36), Petr Cech wrote: >>On 09/11/2015 11:02 AM, Lukas Slebodnik wrote: >>>I do not understand how is the function chown_debug_file related to journald. >>>sssd can be compiled with journald support and in the same time can log to >>>the

Re: [SSSD] [PATCH] Monitor: Show service pings at debug level 8

On 10/27/2015 02:58 PM, Stephen Gallagher wrote: SSSDBG_CONF_SETTINGS is reserved for configuration information. These pings are generally just noise (when they fail, this is logged at SSDBG_FATAL_FAILURE). We should only log these at SSSDBG_TRACE_INTERNAL. Hi Stephen, CI tests are right:

Re: [SSSD] Running tests with different environment

On Fri, Oct 23, 2015 at 01:06:36PM +0200, Lukas Slebodnik wrote: > On (21/10/15 09:20), Sumit Bose wrote: > >On Tue, Oct 20, 2015 at 10:15:06PM +0200, Jakub Hrozek wrote: > >> On Tue, Oct 20, 2015 at 05:17:49PM +0300, Nikolai Kondrashov wrote: > >> > Hi Jakub, > >> > > >> > On 10/19/2015 09:43

Re: [SSSD] [PATCH v2] intg: Add more LDAP tests

Hi Michal, Thanks a lot for the detailed review and testing! Please see my comments below. On 10/23/2015 02:54 PM, Michal Židek wrote: Hi! There is one new pep8 error in the code: ../src/tests/intg/ldap_test.py:819:37: E126 continuation line over-indented for hanging indent Sure, will fix

Re: [SSSD] Running tests with different environment

On Tue, Oct 27, 2015 at 05:42:29PM +0100, Jakub Hrozek wrote: > On Fri, Oct 23, 2015 at 01:06:36PM +0200, Lukas Slebodnik wrote: > > On (21/10/15 09:20), Sumit Bose wrote: > > >On Tue, Oct 20, 2015 at 10:15:06PM +0200, Jakub Hrozek wrote: > > >> On Tue, Oct 20, 2015 at 05:17:49PM +0300, Nikolai

Re: [SSSD] [PATCH] DEBUG: Don't error on chown of nonexistent file

On (27/10/15 09:48), Stephen Gallagher wrote: >We get an error message if we start up SSSD and the debug log does not >yet exist. >From 53592734f73c50029fa573b9bc070437304ea489 Mon Sep 17 00:00:00 2001 >From: Stephen Gallagher >Date: Tue, 27 Oct 2015 09:39:01 -0400 >Subject:

Re: [SSSD] Running tests with different environment

On (27/10/15 17:57), Jakub Hrozek wrote: >On Tue, Oct 27, 2015 at 05:42:29PM +0100, Jakub Hrozek wrote: >> On Fri, Oct 23, 2015 at 01:06:36PM +0200, Lukas Slebodnik wrote: >> > On (21/10/15 09:20), Sumit Bose wrote: >> > >On Tue, Oct 20, 2015 at 10:15:06PM +0200, Jakub Hrozek wrote: >> > >> On

[SSSD] [PATCH] DEBUG: Don't error on chown of nonexistent file

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 We get an error message if we start up SSSD and the debug log does not yet exist. -BEGIN PGP SIGNATURE- Version: GnuPG v2 iEYEARECAAYFAlYvgJsACgkQeiVVYja6o6PsvgCfUj+BFPTavtddwIcT8uoCAVpL 2AwAnirJFDFasy+zTf+mGeNCHDwK2ZtE =g977 -END PGP

[SSSD] [PATCH] Monitor: Show service pings at debug level 8

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 SSSDBG_CONF_SETTINGS is reserved for configuration information. These pings are generally just noise (when they fail, this is logged at SSDBG_FATAL_FAILURE). We should only log these at SSSDBG_TRACE_INTERNAL. -BEGIN PGP SIGNATURE- Version: