[SSSD] [PATCH] sudo: remove unused param name in sdap_sudo_get_usn()

2015-11-02 Thread Pavel Reichl
Hello, please see simple patch attached. Thanks! >From 747ccf2265a7dcf110b1a9b5fa2d0819c2bc5734 Mon Sep 17 00:00:00 2001 From: Pavel Reichl Date: Mon, 2 Nov 2015 14:59:49 +0100 Subject: [PATCH] sudo: remove unused param name in sdap_sudo_get_usn() ---

Re: [SSSD] [PATCH] sudo: remove unused param name in sdap_sudo_get_usn()

2015-11-02 Thread Lukas Slebodnik
On (02/11/15 15:51), Petr Cech wrote: >On 11/02/2015 03:09 PM, Petr Cech wrote: >>On 11/02/2015 03:03 PM, Pavel Reichl wrote: >>>Hello, >>> >>>please see simple patch attached. >>> >>>Thanks! >>> >>LGTM, I am waiting for CI :-) >> >>Petr > >CI tests passed:

Re: [SSSD] [PATCH] PAM: successful authentication sets explicitly PAM_SUCCESSS

2015-11-02 Thread Lukas Slebodnik
On (02/11/15 14:41), Pavel Reichl wrote: >On 11/02/2015 01:02 PM, Sumit Bose wrote: >>On Thu, Oct 29, 2015 at 03:59:40PM +0100, Lukas Slebodnik wrote: >>>On (29/10/15 15:32), Pavel Reichl wrote: Hello, while I worked on tests for PAM responder Sumit proposed to use attached

Re: [SSSD] [PATCH] sudo: remove unused param name in sdap_sudo_get_usn()

2015-11-02 Thread Petr Cech
On 11/02/2015 03:09 PM, Petr Cech wrote: On 11/02/2015 03:03 PM, Pavel Reichl wrote: Hello, please see simple patch attached. Thanks! LGTM, I am waiting for CI :-) Petr CI tests passed: http://sssd-ci.duckdns.org/logs/job/31/85/summary.html => ACK Petr

Re: [SSSD] [PATCH] PAM: successful authentication sets explicitly PAM_SUCCESSS

2015-11-02 Thread Pavel Reichl
On 11/02/2015 01:02 PM, Sumit Bose wrote: On Thu, Oct 29, 2015 at 03:59:40PM +0100, Lukas Slebodnik wrote: On (29/10/15 15:32), Pavel Reichl wrote: Hello, while I worked on tests for PAM responder Sumit proposed to use attached patch. QA have already kindly run their tests (successfully).

Re: [SSSD] [PATCH] SDAP: Remove unused sdap_id_ctx from sdap_id_conn_cache_create

2015-11-02 Thread Lukas Slebodnik
On (02/11/15 13:20), Pavel Reichl wrote: >On 11/02/2015 12:07 PM, Pavel Reichl wrote: >>On 11/02/2015 11:50 AM, Lukas Slebodnik wrote: >>>ehlo, >>> >>>simple patch is attached. >>> >>>LS >>> >> >>LGTM, compiles fine. I'll just postpone acking until CI results arrive... > >ACK ci passed:

Re: [SSSD] [PATCH] sudo: remove unused param name in sdap_sudo_get_usn()

2015-11-02 Thread Petr Cech
On 11/02/2015 03:03 PM, Pavel Reichl wrote: Hello, please see simple patch attached. Thanks! ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/sssd-devel LGTM, I am waiting for CI :-)

Re: [SSSD] [PATCH] PAM: successful authentication sets explicitly PAM_SUCCESSS

2015-11-02 Thread Sumit Bose
On Mon, Nov 02, 2015 at 04:05:33PM +0100, Lukas Slebodnik wrote: > On (02/11/15 14:41), Pavel Reichl wrote: > >On 11/02/2015 01:02 PM, Sumit Bose wrote: > >>On Thu, Oct 29, 2015 at 03:59:40PM +0100, Lukas Slebodnik wrote: > >>>On (29/10/15 15:32), Pavel Reichl wrote: > Hello, > >

Re: [SSSD] [PATCH] LDAP: Fix leak of file descriptors

2015-11-02 Thread Lukas Slebodnik
On (22/10/15 13:47), Lukas Slebodnik wrote: >ehlo, > >Details are in commit message. BTW it would be good to have at least two >reviews. > >Reproducer which I used for https://fedorahosted.org/sssd/ticket/2792: > >Setup: >* two active directories with sites; so sometimes sssd connect to server A >

Re: [SSSD] [PATCH] NSS: fix a use-after-free issue

2015-11-02 Thread Lukas Slebodnik
On (30/10/15 17:35), Sumit Bose wrote: >Hi, > >I found this accidentally because I was still running SSSD with >MALLOC_PERTURB_ set which I used some time ago to hunt a glibc issue. > >This issue wasn't caught before by the unit-tests because >sss_cmd_done() which frees the context is overwritten

Re: [SSSD] [PATCH] NSS: fix a use-after-free issue

2015-11-02 Thread Lukas Slebodnik
On (02/11/15 10:05), Sumit Bose wrote: >On Mon, Nov 02, 2015 at 09:42:51AM +0100, Lukas Slebodnik wrote: >> On (30/10/15 17:35), Sumit Bose wrote: >> >Hi, >> > >> >I found this accidentally because I was still running SSSD with >> >MALLOC_PERTURB_ set which I used some time ago to hunt a glibc

[SSSD] [PATCH] SDAP: Remove unused sdap_id_ctx from sdap_id_conn_cache_create

2015-11-02 Thread Lukas Slebodnik
ehlo, simple patch is attached. LS >From 08cea9235d8b51d0d8174969c73f93a17cf992e8 Mon Sep 17 00:00:00 2001 From: Lukas Slebodnik Date: Sat, 24 Oct 2015 00:02:01 +0200 Subject: [PATCH] SDAP: Remove unused sdap_id_ctx from sdap_id_conn_cache_create ---

Re: [SSSD] [PATCH] SDAP: Remove unused sdap_id_ctx from sdap_id_conn_cache_create

2015-11-02 Thread Pavel Reichl
On 11/02/2015 11:50 AM, Lukas Slebodnik wrote: ehlo, simple patch is attached. LS ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/sssd-devel LGTM, compiles fine. I'll just postpone

Re: [SSSD] [PATCH] SDAP: Remove unused sdap_id_ctx from sdap_id_conn_cache_create

2015-11-02 Thread Pavel Reichl
On 11/02/2015 12:07 PM, Pavel Reichl wrote: On 11/02/2015 11:50 AM, Lukas Slebodnik wrote: ehlo, simple patch is attached. LS ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/sssd-devel

Re: [SSSD] [PATCH] NSS: fix a use-after-free issue

2015-11-02 Thread Sumit Bose
On Mon, Nov 02, 2015 at 10:30:51AM +0100, Lukas Slebodnik wrote: > On (02/11/15 10:05), Sumit Bose wrote: > >On Mon, Nov 02, 2015 at 09:42:51AM +0100, Lukas Slebodnik wrote: > >> On (30/10/15 17:35), Sumit Bose wrote: > >> >Hi, > >> > > >> >I found this accidentally because I was still running

Re: [SSSD] [PATCH] PAM: successful authentication sets explicitly PAM_SUCCESSS

2015-11-02 Thread Sumit Bose
On Thu, Oct 29, 2015 at 03:59:40PM +0100, Lukas Slebodnik wrote: > On (29/10/15 15:32), Pavel Reichl wrote: > >Hello, > > > >while I worked on tests for PAM responder Sumit proposed to use attached > >patch. QA have already kindly run their tests (successfully). > > > >I'll do the review myself