Re: [SSSD] [PATCH] tools: Don't shadow 'exit'

On Mon, Nov 09, 2015 at 10:44:49AM +0100, Lukas Slebodnik wrote: > Obvious ACK While reviewing your patches, I found one more place I forgot to fix, see the attached patch. >From b275e167c4c802c838d8b3d4d2d419e8af6fa99b Mon Sep 17 00:00:00 2001 From: Jakub Hrozek Date: Mon, 9

Re: [SSSD] [PATCH] tools: Don't shadow 'exit'

On Mon, Nov 09, 2015 at 12:05:34PM +0100, Lukas Slebodnik wrote: > On (09/11/15 10:30), Jakub Hrozek wrote: > >Hi, > > > >please see the attached trivial patch. > > >From a27bf8f594a372a4c324b00b7931306b774c Mon Sep 17 00:00:00 2001 > >From: Jakub Hrozek > >Date: Mon, 9

Re: [SSSD] [PATCH] CI: Enforce coverage make check failures

On (09/11/15 14:41), Lukas Slebodnik wrote: >On (07/10/15 08:15), Lukas Slebodnik wrote: >>On (23/06/15 17:01), Lukas Slebodnik wrote: >>>On (17/06/15 16:26), Nikolai Kondrashov wrote: Hi everyone, The attached patch enforces make check failures for the CI coverage build, so

Re: [SSSD] [PATCH] CI: Workaroung for code coverage with old gcc

On (09/11/15 13:52), Nikolai Kondrashov wrote: >On 11/09/2015 11:16 AM, Lukas Slebodnik wrote: >>attached patch is a solution/workaround >>running test in code coverage with old gcc > >Thanks a lot, Lukas! I didn't test it, but it looks good to me. >

Re: [SSSD] [PATCH] CI: Enforce coverage make check failures

On (07/10/15 08:15), Lukas Slebodnik wrote: >On (23/06/15 17:01), Lukas Slebodnik wrote: >>On (17/06/15 16:26), Nikolai Kondrashov wrote: >>>Hi everyone, >>> >>>The attached patch enforces make check failures for the CI coverage build, so >>>we can catch more test failures. >>> >>>I think this

Re: [SSSD] [PATCH] tools: Don't shadow 'exit'

On Mon, Nov 09, 2015 at 12:05:34PM +0100, Lukas Slebodnik wrote: > On (09/11/15 10:30), Jakub Hrozek wrote: > >Hi, > > > >please see the attached trivial patch. > > >From a27bf8f594a372a4c324b00b7931306b774c Mon Sep 17 00:00:00 2001 > >From: Jakub Hrozek > >Date: Mon, 9

Re: [SSSD] [PATCH] Guard against invalid DP messages

On Mon, Nov 09, 2015 at 12:44:17PM +0100, Sumit Bose wrote: > On Fri, Nov 06, 2015 at 09:32:23PM +0100, Jakub Hrozek wrote: > > On Fri, Nov 06, 2015 at 09:13:07PM +0100, Jakub Hrozek wrote: > > > On Fri, Nov 06, 2015 at 04:59:58PM +0100, Sumit Bose wrote: > > > > > @@ -658,11 +678,7 @@ static void

[SSSD] [PATCH] IFP: Skip non-POSIX groups properly

Hi, please review! >From 42572bf05b14c959a938574059694dc04c87e7a1 Mon Sep 17 00:00:00 2001 From: Jakub Hrozek Date: Mon, 9 Nov 2015 22:12:05 +0100 Subject: [PATCH] IFP: Skip non-POSIX groups properly When ifp_users_user_get_groups is called, for example via GetAll and the

[SSSD] [PATCH] IPA_PROVIDER: Explicit no handle of services

Hello, please see first attempt of patch for: https://fedorahosted.org/sssd/ticket/2747 Regards Petr PS: # reproducer getent services -s sss l...@cygnus.dev >From 64d952f188e86a00c26ccbe26ad09231e6b6de2b Mon Sep 17 00:00:00 2001 From: Petr Cech Date: Mon, 9 Nov 2015

Re: [SSSD] [PATCH] SSSD: Add a new command diag_cmd

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 11/09/2015 05:32 AM, Petr Cech wrote: > On 11/04/2015 11:24 AM, Jakub Hrozek wrote: >> Hi, >> >> I created this patch to try to diagnose an issue where sssd >> would randomly restart on any of machines in a VM cluster without >> giving too much

Re: [SSSD] [PATCH] tools: Don't shadow 'exit'

On (09/11/15 15:32), Jakub Hrozek wrote: >On Mon, Nov 09, 2015 at 12:05:34PM +0100, Lukas Slebodnik wrote: >> On (09/11/15 10:30), Jakub Hrozek wrote: >> >Hi, >> > >> >please see the attached trivial patch. >> >> >From a27bf8f594a372a4c324b00b7931306b774c Mon Sep 17 00:00:00 2001 >> >From:

Re: [SSSD] [PATCH] TEST: recent_valid filter testing

On Thu, Nov 05, 2015 at 05:29:25PM +0100, Petr Cech wrote: > On 11/04/2015 11:11 AM, Jakub Hrozek wrote: > >Hi, > > > >Sorry it took so long to get back to the review. I only have some minor > >comments, see inline.. > > > >Because the group patches are more or less equivalent, I'll just comment

Re: [SSSD] [PATCH] tools: Don't shadow 'exit'

On Mon, Nov 09, 2015 at 06:35:05PM +0100, Lukas Slebodnik wrote: > BTW which version do you prefer? > a) signl > b) sig > c) a_signal I don't care :) Feel free to use a_signal since it came first. ___ sssd-devel mailing list

Re: [SSSD] [PATCH] TEST: recent_valid filter testing

On Tue, Nov 10, 2015 at 08:37:13AM +0100, Lukas Slebodnik wrote: > On (10/11/15 08:29), Pavel Reichl wrote: > > > > > >On 11/05/2015 05:29 PM, Petr Cech wrote: > >>+void test_groups_by_recent_filter_valid(void **state) > >>+{ > >>+struct cache_req_test_ctx *test_ctx = NULL; > >>+TALLOC_CTX

Re: [SSSD] [PATCH] TEST: recent_valid filter testing

On (10/11/15 08:29), Pavel Reichl wrote: > > >On 11/05/2015 05:29 PM, Petr Cech wrote: >>+void test_groups_by_recent_filter_valid(void **state) >>+{ >>+struct cache_req_test_ctx *test_ctx = NULL; >>+TALLOC_CTX *req_mem_ctx = NULL; >>+struct tevent_req *req = NULL; >>+const char

Re: [SSSD] [PATCH] tools: Don't shadow 'exit'

On (09/11/15 15:33), Jakub Hrozek wrote: >On Mon, Nov 09, 2015 at 10:44:49AM +0100, Lukas Slebodnik wrote: >> Obvious ACK > >While reviewing your patches, I found one more place I forgot to fix, >see the attached patch. >From b275e167c4c802c838d8b3d4d2d419e8af6fa99b Mon Sep 17 00:00:00 2001

Re: [SSSD] [PATCH] TEST: recent_valid filter testing

On 11/05/2015 05:29 PM, Petr Cech wrote: +void test_groups_by_recent_filter_valid(void **state) +{ +struct cache_req_test_ctx *test_ctx = NULL; +TALLOC_CTX *req_mem_ctx = NULL; +struct tevent_req *req = NULL; +const char **group_names = NULL; +const char **ldb_results =

Re: [SSSD] [PATCH] IFP: Skip non-POSIX groups properly

On Tue, Nov 10, 2015 at 07:31:41AM +0100, Lukas Slebodnik wrote: > On (09/11/15 22:24), Jakub Hrozek wrote: > >Hi, > > > >please review! > > >From 42572bf05b14c959a938574059694dc04c87e7a1 Mon Sep 17 00:00:00 2001 > >From: Jakub Hrozek > >Date: Mon, 9 Nov 2015 22:12:05 +0100 >

Re: [SSSD] [PATCH] IFP: Skip non-POSIX groups properly

On (09/11/15 22:24), Jakub Hrozek wrote: >Hi, > >please review! >From 42572bf05b14c959a938574059694dc04c87e7a1 Mon Sep 17 00:00:00 2001 >From: Jakub Hrozek >Date: Mon, 9 Nov 2015 22:12:05 +0100 >Subject: [PATCH] IFP: Skip non-POSIX groups properly > >When

Re: [SSSD] [PATCH] tools: Don't shadow 'exit'

On (09/11/15 10:30), Jakub Hrozek wrote: >Hi, > >please see the attached trivial patch. >From a27bf8f594a372a4c324b00b7931306b774c Mon Sep 17 00:00:00 2001 >From: Jakub Hrozek >Date: Mon, 9 Nov 2015 10:27:41 +0100 >Subject: [PATCH] tools: Don't shadow 'exit'

Re: [SSSD] [PATCH v2] intg: Add more LDAP tests

On (08/11/15 23:49), Michal Židek wrote: >I am attaching patch that can be applied and squashed into >Nick's patch. I am sending both patches to see what >changes have been made, *please squash them before pushing*. > >This patch just removes the negchace (together with the >asserts that are

Re: [SSSD] [PATCH] SSSD: Add a new command diag_cmd

On 11/04/2015 11:24 AM, Jakub Hrozek wrote: Hi, I created this patch to try to diagnose an issue where sssd would randomly restart on any of machines in a VM cluster without giving too much advise why. I think it might be useful to merge in general. Hi Jakub, I reviewed the patch. Code looks

[SSSD] [PATCH] tools: Don't shadow 'exit'

Hi, please see the attached trivial patch. >From a27bf8f594a372a4c324b00b7931306b774c Mon Sep 17 00:00:00 2001 From: Jakub Hrozek Date: Mon, 9 Nov 2015 10:27:41 +0100 Subject: [PATCH] tools: Don't shadow 'exit' MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8

Re: [SSSD] [PATCH] tools: Don't shadow 'exit'

On (09/11/15 10:30), Jakub Hrozek wrote: >Hi, > >please see the attached trivial patch. >From a27bf8f594a372a4c324b00b7931306b774c Mon Sep 17 00:00:00 2001 >From: Jakub Hrozek >Date: Mon, 9 Nov 2015 10:27:41 +0100 >Subject: [PATCH] tools: Don't shadow 'exit'

Re: [SSSD] [PATCH] Guard against invalid DP messages

On Fri, Nov 06, 2015 at 09:32:23PM +0100, Jakub Hrozek wrote: > On Fri, Nov 06, 2015 at 09:13:07PM +0100, Jakub Hrozek wrote: > > On Fri, Nov 06, 2015 at 04:59:58PM +0100, Sumit Bose wrote: > > > > @@ -658,11 +678,7 @@ static void get_subdomains_callback(struct be_req > > > > *req, > > > >

Re: [SSSD] [PATCH] CI: Workaroung for code coverage with old gcc

On 11/09/2015 11:16 AM, Lukas Slebodnik wrote: attached patch is a solution/workaround running test in code coverage with old gcc Thanks a lot, Lukas! I didn't test it, but it looks good to me. Nick ___ sssd-devel mailing list