Re: [SSSD] [PATCH] TESTS: extend PAM responder unit test

2015-11-12 Thread Lukas Slebodnik
On (11/11/15 18:04), Pavel Reichl wrote: > > >On 11/10/2015 05:00 PM, Lukas Slebodnik wrote: >[snip] >>I tried it and all test passed. >> >>Please fix small issues and you have my ACK. >> >>LS > >Thanks, updated patch set attached. >From 5f43c3ddef195a7a480755306349555e059778a3 Mon Sep 17

Re: [SSSD] CONFIGURE: Bump AM_GNU_GETTEXT_VERSION

2015-11-12 Thread Lukas Slebodnik
On (12/11/15 09:10), Petr Cech wrote: >On 11/10/2015 10:44 AM, Lukas Slebodnik wrote: >>ehlo, >> >>The function gettext was not detected properly with strict >>cflags even thought it was part of glibc. >> >>sh$ CFLAGS="-Werror" ./configure >> >>sh$ grep gt_cv_func_gnugettext config.log

[SSSD] [PATCH] TEST: Fix warning: cast from pointer to integer of different size

2015-11-12 Thread Lukas Slebodnik
ehlo, you can see warnings on 32 bit machine and cmocka tests. So the simplest reproducer is to use mock mock --root fedora-21-i386 --resultdir . --rebuild ./sssd-1.13.90-0.fc23.src.rpm I plan to send patch for cmocka. Therefore there is #ifndef will_return_ptr. I would like to avoid prefixed

Re: [SSSD] CONFIGURE: Bump AM_GNU_GETTEXT_VERSION

2015-11-12 Thread Petr Cech
On 11/10/2015 10:44 AM, Lukas Slebodnik wrote: ehlo, The function gettext was not detected properly with strict cflags even thought it was part of glibc. sh$ CFLAGS="-Werror" ./configure sh$ grep gt_cv_func_gnugettext config.log gt_cv_func_gnugettext1_libc=no gt_cv_func_gnugettext1_libintl=no

Re: [SSSD] [PATCH] SSSD: Add a new command diag_cmd

2015-11-12 Thread Petr Cech
On 11/11/2015 12:25 PM, Jakub Hrozek wrote: On Wed, Nov 11, 2015 at 11:07:46AM +0100, Petr Cech wrote: >On 11/11/2015 09:32 AM, Jakub Hrozek wrote: > >>>Hi Jakub, > >>> > >>>I just sent the patch to the CI tests and they passed > >>>http://sssd-ci.duckdns.org/logs/job/32/63/summary.html > >>>

Re: [SSSD] [PATCH] TESTS: extend PAM responder unit test

2015-11-12 Thread Lukas Slebodnik
On (12/11/15 09:35), Lukas Slebodnik wrote: >On (11/11/15 18:04), Pavel Reichl wrote: >> >> >>On 11/10/2015 05:00 PM, Lukas Slebodnik wrote: >>[snip] >>>I tried it and all test passed. >>> >>>Please fix small issues and you have my ACK. >>> >>>LS >> >>Thanks, updated patch set attached. > >>From

Re: [SSSD] [PATCH] Reduce the code duplication in Data Provider

2015-11-12 Thread Petr Cech
On 11/11/2015 02:28 PM, Jakub Hrozek wrote: Hi, I think one of the prime reasons for #2861 was copy-pasting code. The two attached patches reduce the code duplication and hopefully will make future additions to Data Provider safer. Ideas on different solutions are welcome! Hi Jakub, I am

Re: [SSSD] [PATCH] AD: remove annoying debug message

2015-11-12 Thread Jakub Hrozek
On Thu, Nov 12, 2015 at 12:52:15PM +0100, Pavel Březina wrote: > Simple patch is attached. ACK Thank you very much, this is indeed annoying and it's my fault -- I added this patch when I was writing the GC support and simply forgot to remove it. ___

Re: [SSSD] [PATCH] Reduce the code duplication in Data Provider

2015-11-12 Thread Jakub Hrozek
On Thu, Nov 12, 2015 at 01:03:33PM +0100, Petr Cech wrote: > On 11/11/2015 02:28 PM, Jakub Hrozek wrote: > >Hi, > > > >I think one of the prime reasons for #2861 was copy-pasting code. The > >two attached patches reduce the code duplication and hopefully will make > >future additions to Data

Re: [SSSD] [PATCH] p11: enable ocsp checks

2015-11-12 Thread Sumit Bose
On Tue, Nov 10, 2015 at 12:40:23PM +0100, Lukas Slebodnik wrote: > On (10/11/15 11:36), Sumit Bose wrote: > >Hi, > > > >this patch switches on the Online Certificate Status Protocol (OCSP) > >checks while validation the certificate. This is done by calling > >CERT_EnableOCSPChecking() before doing

[SSSD] [PATCH] AD: remove annoying debug message

2015-11-12 Thread Pavel Březina
Simple patch is attached. From 12ad3ae6c4562bd4dcecdef08b199c0dfa852c75 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pavel=20B=C5=99ezina?= Date: Thu, 12 Nov 2015 12:50:21 +0100 Subject: [PATCH] AD: remove annoying debug message This debug message is mostly a left over from

Re: [SSSD] [PATCHES] sssd_client: Do not use removed memory cache

2015-11-12 Thread Lukas Slebodnik
On (12/11/15 06:48), Lukas Slebodnik wrote: >On (11/11/15 18:13), Jakub Hrozek wrote: >>On Wed, Nov 11, 2015 at 05:53:15PM +0100, Michal Židek wrote: >>> ACK to all. >>> >>> CI link: >>> http://sssd-ci.duckdns.org/logs/job/32/83/summary.html >>> >>> These patches are required before Nick's LDAP

Re: [SSSD] [PATCH] Reduce the code duplication in Data Provider

2015-11-12 Thread Petr Cech
On 11/12/2015 01:08 PM, Jakub Hrozek wrote: On Thu, Nov 12, 2015 at 01:03:33PM +0100, Petr Cech wrote: >On 11/11/2015 02:28 PM, Jakub Hrozek wrote: > >Hi, > > > >I think one of the prime reasons for #2861 was copy-pasting code. The > >two attached patches reduce the code duplication and

[SSSD] [PATCH] CI: Update suppression file for 32bit el6

2015-11-12 Thread Lukas Slebodnik
ehlo, the glibc leak has different stacktrace on 32 bit abd 64bit 64 bit: { Memcheck:Leak fun:memalign fun:posix_memalign obj:/lib64/libglib-2.0.so.0.2800.8 fun:g_slice_alloc fun:g_string_sized_new fun:g_utf8_casefold fun:sss_utf8_case_eq

Re: [SSSD] [PATCH] SSSD: Add a new command diag_cmd

2015-11-12 Thread Petr Cech
On 11/12/2015 06:30 PM, Jakub Hrozek wrote: On Thu, Nov 12, 2015 at 10:49:33AM +0100, Petr Cech wrote: >On 11/11/2015 12:25 PM, Jakub Hrozek wrote: > >On Wed, Nov 11, 2015 at 11:07:46AM +0100, Petr Cech wrote: > >>>On 11/11/2015 09:32 AM, Jakub Hrozek wrote: > >> >>>Hi Jakub, > >>

Re: [SSSD] [PATCH] TEST: recent_valid filter testing

2015-11-12 Thread Petr Cech
bump ___ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/sssd-devel

Re: [SSSD] [PATCH] IPA_PROVIDER: Explicit no handle of services

2015-11-12 Thread Petr Cech
On 11/11/2015 02:42 PM, Jakub Hrozek wrote: Hi, I think it's a good idea to only say we don't handle services for IPA subdomains. But I also think it would be better to shortcut the request sooner, in ipa_subdomain_account_send() to avoid even sending an LDAP query. Hi Jakub, new patch is

Re: [SSSD] [PATCH] IPA_PROVIDER: Explicit no handle of services

2015-11-12 Thread Jakub Hrozek
On Thu, Nov 12, 2015 at 04:54:21PM +0100, Petr Cech wrote: > On 11/11/2015 02:42 PM, Jakub Hrozek wrote: > >Hi, I think it's a good idea to only say we don't handle services for > >IPA subdomains. But I also think it would be better to shortcut the > >request sooner, in

Re: [SSSD] [PATCH] AD: remove annoying debug message

2015-11-12 Thread Jakub Hrozek
On Thu, Nov 12, 2015 at 01:00:36PM +0100, Jakub Hrozek wrote: > On Thu, Nov 12, 2015 at 12:52:15PM +0100, Pavel Březina wrote: > > Simple patch is attached. > > ACK > > Thank you very much, this is indeed annoying and it's my fault -- I > added this patch when I was writing the GC support and

Re: [SSSD] [PATCH] SSSD: Add a new command diag_cmd

2015-11-12 Thread Jakub Hrozek
On Thu, Nov 12, 2015 at 10:49:33AM +0100, Petr Cech wrote: > On 11/11/2015 12:25 PM, Jakub Hrozek wrote: > >On Wed, Nov 11, 2015 at 11:07:46AM +0100, Petr Cech wrote: > >>>On 11/11/2015 09:32 AM, Jakub Hrozek wrote: > >> >>>Hi Jakub, > >> >>> > >> >>>I just sent the patch to the CI