[SSSD] [PATCH] PROVIDERS: Default values in debug

[Petr Cech]

Hi list,

I was debug code very deeply and I found nitpick.
There is simple patch attached.

Regards

--
Petr^4 Čech


>From 15d35c7e0e2171c49746d3a87f9aa2aba07a7bbc Mon Sep 17 00:00:00 2001
From: Petr Cech <pc...@redhat.com>
Date: Sun, 17 Jul 2016 11:36:18 +0200
Subject: [PATCH] PROVIDERS: Default values in debug

It could be usefull to distinguish between deafult and config values
in debug messages.
---
 src/providers/data_provider_opts.c | 21 ++++++++++++++-------
 1 file changed, 14 insertions(+), 7 deletions(-)

diff --git a/src/providers/data_provider_opts.c b/src/providers/data_provider_opts.c
index 9db43fc4077d3b14f2358029c7d532e440930879..d375c779a75ac1103efd8766026ed6604c1ca0f9 100644
--- a/src/providers/data_provider_opts.c
+++ b/src/providers/data_provider_opts.c
@@ -219,9 +219,10 @@ static int dp_copy_options_ex(TALLOC_CTX *memctx,
                        opts[i].opt_name);
                 goto done;
             }
-            DEBUG(SSSDBG_TRACE_FUNC, "Option %s has%s value %s\n",
+            DEBUG(SSSDBG_TRACE_FUNC, "Option %s has%s %svalue %s\n",
                   opts[i].opt_name,
                   opts[i].val.cstring ? "" : " no",
+                  copy_values ? "" : "default ",
                   opts[i].val.cstring ? opts[i].val.cstring : "");
             break;
 
@@ -237,8 +238,10 @@ static int dp_copy_options_ex(TALLOC_CTX *memctx,
                        opts[i].opt_name);
                 goto done;
             }
-            DEBUG(SSSDBG_TRACE_FUNC, "Option %s has %s binary value.\n",
-                  opts[i].opt_name, opts[i].val.blob.length?"a":"no");
+            DEBUG(SSSDBG_TRACE_FUNC, "Option %s has %s %sbinary value.\n",
+                  opts[i].opt_name,
+                  copy_values ? "" : "default ",
+                  opts[i].val.blob.length?"a":"no");
             break;
 
         case DP_OPT_NUMBER:
@@ -253,8 +256,10 @@ static int dp_copy_options_ex(TALLOC_CTX *memctx,
                       opts[i].opt_name);
                 goto done;
             }
-            DEBUG(SSSDBG_TRACE_FUNC, "Option %s has value %d\n",
-                  opts[i].opt_name, opts[i].val.number);
+            DEBUG(SSSDBG_TRACE_FUNC, "Option %s has %svalue %d\n",
+                  opts[i].opt_name,
+                  copy_values ? "" : "default ",
+                  opts[i].val.number);
             break;
 
         case DP_OPT_BOOL:
@@ -269,8 +274,10 @@ static int dp_copy_options_ex(TALLOC_CTX *memctx,
                        opts[i].opt_name);
                 goto done;
             }
-            DEBUG(SSSDBG_TRACE_FUNC, "Option %s is %s\n",
-                  opts[i].opt_name, opts[i].val.boolean?"TRUE":"FALSE");
+            DEBUG(SSSDBG_TRACE_FUNC, "Option %s is %s%s\n",
+                  opts[i].opt_name,
+                  opts[i].val.boolean?"TRUE":"FALSE",
+                  copy_values ? "" : " default");
             break;
         }
     }
-- 
2.7.4


_______________________________________________
sssd-devel mailing list
sssd-devel@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/sssd-devel@lists.fedorahosted.org