[SSSD] [sssd PR#141][synchronized] PAM: Use cache_req to perform initgroups lookups

2017-02-24 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/141 Author: fidencio Title: #141: PAM: Use cache_req to perform initgroups lookups Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/141/head:pr141 git checkout pr141 From

[SSSD] [sssd PR#168][comment] DOC: Deprecate README, add README.md

2017-02-24 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/168 Title: #168: DOC: Deprecate README, add README.md jhrozek commented: """ ok, new patch pushed here """ See the full comment at https://github.com/SSSD/sssd/pull/168#issuecomment-282330721 ___ sssd-devel

[SSSD] [sssd PR#168][synchronized] DOC: Deprecate README, add README.md

2017-02-24 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/168 Author: jhrozek Title: #168: DOC: Deprecate README, add README.md Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/168/head:pr168 git checkout pr168 From

[SSSD] [sssd PR#168][comment] DOC: Deprecate README, add README.md

2017-02-24 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/168 Title: #168: DOC: Deprecate README, add README.md lslebodn commented: """ On (24/02/17 07:42), Jakub Hrozek wrote: >On Fri, Feb 24, 2017 at 06:17:16AM -0800, lslebodn wrote: >> On (24/02/17 02:43), Jakub Hrozek wrote: >> >I'm not sure why the centos CI

[SSSD] [sssd PR#168][comment] DOC: Deprecate README, add README.md

2017-02-24 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/168 Title: #168: DOC: Deprecate README, add README.md jhrozek commented: """ On Fri, Feb 24, 2017 at 06:17:16AM -0800, lslebodn wrote: > On (24/02/17 02:43), Jakub Hrozek wrote: > >I'm not sure why the centos CI reports failure. I ran our internal CI and

[SSSD] [sssd PR#168][synchronized] DOC: Deprecate README, add README.md

2017-02-24 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/168 Author: jhrozek Title: #168: DOC: Deprecate README, add README.md Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/168/head:pr168 git checkout pr168 From

[SSSD] [sssd PR#152][comment] Add a tevent wrapper around libcurl's asynchronous interface

2017-02-24 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/152 Title: #152: Add a tevent wrapper around libcurl's asynchronous interface jhrozek commented: """ On Thu, Feb 23, 2017 at 03:10:12AM -0800, lslebodn wrote: > lslebodn commented on this pull request. > > > > > @@ -3241,6 +3281,7 @@ intgcheck-prepare:

[SSSD] [sssd PR#152][synchronized] Add a tevent wrapper around libcurl's asynchronous interface

2017-02-24 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/152 Author: jhrozek Title: #152: Add a tevent wrapper around libcurl's asynchronous interface Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/152/head:pr152 git checkout pr152

[SSSD] [sssd PR#163][comment] Enable the files domain for all sssd configurations

2017-02-24 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/163 Title: #163: Enable the files domain for all sssd configurations jhrozek commented: """ btw one thing I would like to do more that this auto-magic is for SSSD to have the functionality to enable all domains that are defined even in snippets without

[SSSD] [sssd PR#163][comment] Enable the files domain for all sssd configurations

2017-02-24 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/163 Title: #163: Enable the files domain for all sssd configurations jhrozek commented: """ OK, I added a new option and a test for it. So far (for easier review) I kept the option and the test as separate patches prefixed with SQ. If the patches are

[SSSD] [sssd PR#163][synchronized] Enable the files domain for all sssd configurations

2017-02-24 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/163 Author: jhrozek Title: #163: Enable the files domain for all sssd configurations Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/163/head:pr163 git checkout pr163 From

[SSSD] [sssd PR#167][comment] Add missing dyndns_auth option to AD and IPA provider man pages

2017-02-24 Thread justin-stephenson
URL: https://github.com/SSSD/sssd/pull/167 Title: #167: Add missing dyndns_auth option to AD and IPA provider man pages justin-stephenson commented: """ If that is the case, then I am fine if you would like to go ahead and close this PR. I just saw a customer using this option recently. """

[SSSD] [sssd PR#167][comment] Add missing dyndns_auth option to AD and IPA provider man pages

2017-02-24 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/167 Title: #167: Add missing dyndns_auth option to AD and IPA provider man pages lslebodn commented: """ I thought it was not documented intentionally. The same as other insecure options for tls. @jhrozek should know because he is an author :-) LS """

[SSSD] [sssd PR#168][comment] DOC: Deprecate README, add README.md

2017-02-24 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/168 Title: #168: DOC: Deprecate README, add README.md lslebodn commented: """ On (24/02/17 02:43), Jakub Hrozek wrote: >I'm not sure why the centos CI reports failure. I ran our internal CI and it >passed:

[SSSD] [sssd PR#168][+Changes requested] DOC: Deprecate README, add README.md

2017-02-24 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/168 Title: #168: DOC: Deprecate README, add README.md Label: +Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#168][comment] DOC: Deprecate README, add README.md

2017-02-24 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/168 Title: #168: DOC: Deprecate README, add README.md lslebodn commented: """ On (24/02/17 02:43), Jakub Hrozek wrote: >I'm not sure why the centos CI reports failure. I ran our internal CI and it >passed:

[SSSD] [sssd PR#168][-Accepted] DOC: Deprecate README, add README.md

2017-02-24 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/168 Title: #168: DOC: Deprecate README, add README.md Label: -Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#153][+Accepted] sss_cache: User/groups invalidation in domain cache

2017-02-24 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/153 Title: #153: sss_cache: User/groups invalidation in domain cache Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#153][comment] sss_cache: User/groups invalidation in domain cache

2017-02-24 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/153 Title: #153: sss_cache: User/groups invalidation in domain cache fidencio commented: """ Patch looks good and there's just two really minor coding style issues, IMO. Whoever pushes this patch, please, squash

[SSSD] [sssd PR#128][+Changes requested] Fix group renaming issue when "id_provider = ldap" is set

2017-02-24 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/128 Title: #128: Fix group renaming issue when "id_provider = ldap" is set Label: +Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#128][comment] Fix group renaming issue when "id_provider = ldap" is set

2017-02-24 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/128 Title: #128: Fix group renaming issue when "id_provider = ldap" is set fidencio commented: """ So, as far as I remember, the conclusion about this patch is that we should also have a really loud debug message saying that the group has been renamed.

[SSSD] [sssd PR#163][comment] Enable the files domain for all sssd configurations

2017-02-24 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/163 Title: #163: Enable the files domain for all sssd configurations jhrozek commented: """ On Fri, Feb 24, 2017 at 04:41:48AM -0800, Pavel Březina wrote: > Typo in last commit message: > ``` > This functionality is only enabled in case SSSD is configured

[SSSD] [sssd PR#163][comment] Enable the files domain for all sssd configurations

2017-02-24 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/163 Title: #163: Enable the files domain for all sssd configurations pbrezina commented: """ Typo in last commit message: ``` This functionality is only enabled in case SSSD is configured with with < ``` Otherwise ack. I just wonder if this is really

[SSSD] [sssd PR#141][comment] PAM: Use cache_req to perform initgroups lookups

2017-02-24 Thread spbnick
URL: https://github.com/SSSD/sssd/pull/141 Title: #141: PAM: Use cache_req to perform initgroups lookups spbnick commented: """ All my comments were addressed, ACK on my points. Thanks, @fidencio! """ See the full comment at https://github.com/SSSD/sssd/pull/141#issuecomment-282267591

[SSSD] [sssd PR#168][comment] DOC: Deprecate README, add README.md

2017-02-24 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/168 Title: #168: DOC: Deprecate README, add README.md jhrozek commented: """ I'm not sure why the centos CI reports failure. I ran our internal CI and it passed: http://sssd-ci.duckdns.org/logs/job/63/44/summary.html """ See the full comment at

[SSSD] [sssd PR#168][+Accepted] DOC: Deprecate README, add README.md

2017-02-24 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/168 Title: #168: DOC: Deprecate README, add README.md Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#168][comment] DOC: Deprecate README, add README.md

2017-02-24 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/168 Title: #168: DOC: Deprecate README, add README.md fidencio commented: """ ack! """ See the full comment at https://github.com/SSSD/sssd/pull/168#issuecomment-282236962 ___ sssd-devel mailing list --

[SSSD] [sssd PR#168][synchronized] DOC: Deprecate README, add README.md

2017-02-24 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/168 Author: jhrozek Title: #168: DOC: Deprecate README, add README.md Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/168/head:pr168 git checkout pr168 From

[SSSD] [sssd PR#168][opened] DOC: Deprecate README, add README.md

2017-02-24 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/168 Author: jhrozek Title: #168: DOC: Deprecate README, add README.md Action: opened PR body: """ None """ To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/168/head:pr168 git checkout pr168 From