[SSSD] [sssd PR#450][+Changes requested] sysdb: do not use objectClass for users and groups

2017-11-20 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/450 Title: #450: sysdb: do not use objectClass for users and groups Label: +Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#450][comment] sysdb: do not use objectClass for users and groups

2017-11-20 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/450 Title: #450: sysdb: do not use objectClass for users and groups fidencio commented: """ Covscan is clean with this series. """ See the full comment at https://github.com/SSSD/sssd/pull/450#issuecomment-345935156

[SSSD] [sssd PR#412][comment] Gpo contributed patches

2017-11-20 Thread rdratlos
URL: https://github.com/SSSD/sssd/pull/412 Title: #412: Gpo contributed patches rdratlos commented: """ Following an e-mail exchange with Lukas I have fetched the patches, that have been updated by Michal here, back to Pagure and fixed the minor issues. See:

[SSSD] [sssd PR#412][comment] Gpo contributed patches

2017-11-20 Thread rdratlos
URL: https://github.com/SSSD/sssd/pull/412 Title: #412: Gpo contributed patches rdratlos commented: """ Following an e-mail exchange with Lukas I have moved the patches, that have been updated by Michal here, back to Pagure and fixed the minor issues. See:

[SSSD] [sssd PR#453][comment] Speed up by-ID lookups with the help of the Global Catalog

2017-11-20 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/453 Title: #453: Speed up by-ID lookups with the help of the Global Catalog jhrozek commented: """ I fixed the multidomain bug and another bug in the AD locator request which could have caused a loop in an MPG domain. I still haven't ran any downstream

[SSSD] [sssd PR#424][-Changes requested] TOOLS: Add a new sssctl command access-report

2017-11-20 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/424 Title: #424: TOOLS: Add a new sssctl command access-report Label: -Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#424][comment] TOOLS: Add a new sssctl command access-report

2017-11-20 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/424 Title: #424: TOOLS: Add a new sssctl command access-report jhrozek commented: """ removed the changes requested label since new patches were pushed """ See the full comment at https://github.com/SSSD/sssd/pull/424#issuecomment-345812922

[SSSD] [sssd PR#454][-Changes requested] TESTS: Order list of entries in some lists

2017-11-20 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/454 Title: #454: TESTS: Order list of entries in some lists Label: -Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#455][+Changes requested] mmap_cache: make checks independent of input size

2017-11-20 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/455 Title: #455: mmap_cache: make checks independent of input size Label: +Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#455][comment] mmap_cache: make checks independent of input size

2017-11-20 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/455 Title: #455: mmap_cache: make checks independent of input size mzidek-rh commented: """ Just two really minor nitpicks (typo in word 'relative' and missing space around '+'): ``` diff --git a/src/responder/nss/nsssrv_mmap_cache.c

[SSSD] [sssd PR#450][comment] sysdb: do not use objectClass for users and groups

2017-11-20 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/450 Title: #450: sysdb: do not use objectClass for users and groups jhrozek commented: """ I submitted some beaker jobs and so far they seem to be passing: - 2153779: local_provider - 2153777: Tests-for-LDAP-ID-and-LDAP-AUTH - 2153776:

[SSSD] [sssd PR#454][comment] TESTS: Order list of entries in some lists

2017-11-20 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/454 Title: #454: TESTS: Order list of entries in some lists mzidek-rh commented: """ Updated. There should be no valgrind issues now. """ See the full comment at https://github.com/SSSD/sssd/pull/454#issuecomment-345769249

[SSSD] [sssd PR#454][+Changes requested] TESTS: Order list of entries in some lists

2017-11-20 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/454 Title: #454: TESTS: Order list of entries in some lists Label: +Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#454][comment] TESTS: Order list of entries in some lists

2017-11-20 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/454 Title: #454: TESTS: Order list of entries in some lists lslebodn commented: """ `./test_sysdb_views` passed with valgrind """ See the full comment at https://github.com/SSSD/sssd/pull/454#issuecomment-345763411

[SSSD] [sssd PR#454][-Changes requested] TESTS: Order list of entries in some lists

2017-11-20 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/454 Title: #454: TESTS: Order list of entries in some lists Label: -Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#454][comment] TESTS: Order list of entries in some lists

2017-11-20 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/454 Title: #454: TESTS: Order list of entries in some lists mzidek-rh commented: """ I rewrote it to use the qsort. Also added the revert patch for the patch that disables the tests. """ See the full comment at

[SSSD] [sssd PR#399][comment] Backport of PR#57 to SSSD-1.13

2017-11-20 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/399 Title: #399: Backport of PR#57 to SSSD-1.13 lslebodn commented: """ >@lslebodn, yes, they are identical. Thank you very much for checking. BTW I wanted to push PR and I wanted to add comments to related upstream tickets. And it seems that there was

[SSSD] [sssd PR#399][comment] Backport of PR#57 to SSSD-1.13

2017-11-20 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/399 Title: #399: Backport of PR#57 to SSSD-1.13 sumit-bose commented: """ @lslebodn, yes, they are identical. """ See the full comment at https://github.com/SSSD/sssd/pull/399#issuecomment-345692208 ___

[SSSD] [sssd PR#412][comment] Gpo contributed patches

2017-11-20 Thread mzidek-rh
URL: https://github.com/SSSD/sssd/pull/412 Title: #412: Gpo contributed patches mzidek-rh commented: """ Hi, I think it is OK if this PR is closed and a new one is opened here on GH by @rdratlos . It is also OK if he updates the PR on Pagure. Whatever works better for @rdratlos . I think

[SSSD] Re: SSSD Virtual Test Suite

2017-11-20 Thread Pavel Březina
On 11/14/2017 12:41 PM, Fabiano Fidêncio wrote: On Tue, Nov 14, 2017 at 11:17 AM, Pavel Březina wrote: On 11/13/2017 05:43 PM, Fabiano Fidêncio wrote: On Mon, Nov 13, 2017 at 11:16 AM, Pavel Březina wrote: Hello, It took me a lot longer than I

[SSSD] [sssd PR#412][comment] Gpo contributed patches

2017-11-20 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/412 Title: #412: Gpo contributed patches lslebodn commented: """ On (20/11/17 08:55), Martin Kosek wrote: >I do not see a problem in doing this PR here on SSSD GitHub space, it is where >all the other PRs are being run and what we use in our infra. I see

[SSSD] [sssd PR#412][comment] Gpo contributed patches

2017-11-20 Thread mkosek
URL: https://github.com/SSSD/sssd/pull/412 Title: #412: Gpo contributed patches mkosek commented: """ I do not see a problem in doing this PR here on SSSD GitHub space, it is where all the other PRs are being run and what we use in our infra. I see that Pagure is also apparently unable to

[SSSD] [sssd PR#412][comment] Gpo contributed patches

2017-11-20 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/412 Title: #412: Gpo contributed patches lslebodn commented: """ On (19/11/17 17:33), rdratlos wrote: >When reviewing the changes I identified two minor issues (typo, wrong debug >level reference in man page). What is the best way to fix this before you