[SSSD] [sssd PR#497][+Pushed] sysdb: sanitize search filter input - backport sssd-1-14

2018-02-21 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/497 Title: #497: sysdb: sanitize search filter input - backport sssd-1-14 Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#516][-Accepted] DESKPROFILE: Document it doesn't work when run as unprivileged user

2018-02-21 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/516 Title: #516: DESKPROFILE: Document it doesn't work when run as unprivileged user Label: -Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#516][comment] DESKPROFILE: Document it doesn't work when run as unprivileged user

2018-02-21 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/516 Title: #516: DESKPROFILE: Document it doesn't work when run as unprivileged user lslebodn commented: """ Justin, thank you for review """ See the full comment at https://github.com/SSSD/sssd/pull/516#issuecomment-367457190

[SSSD] [sssd PR#515][comment] sssctl: Showing help even when sssd not configured

2018-02-21 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/515 Title: #515: sssctl: Showing help even when sssd not configured jhrozek commented: """ Just by looking at the diff I'm not sure comparing argv with --help is the best approach, but I wonder if @pbrezina has a better idea? """ See the full comment at

[SSSD] [sssd PR#516][comment] DESKPROFILE: Document it doesn't work when run as unprivileged user

2018-02-21 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/516 Title: #516: DESKPROFILE: Document it doesn't work when run as unprivileged user lslebodn commented: """ I tried to figure out why centos CI is failing and I noticed that xml element `note` is not allowed in DTD ``` /usr/bin/xmllint --catalogs

[SSSD] [sssd PR#516][synchronized] DESKPROFILE: Document it doesn't work when run as unprivileged user

2018-02-21 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/516 Author: fidencio Title: #516: DESKPROFILE: Document it doesn't work when run as unprivileged user Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/516/head:pr516 git checkout

[SSSD] [sssd PR#516][synchronized] DESKPROFILE: Document it doesn't work when run as unprivileged user

2018-02-21 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/516 Author: fidencio Title: #516: DESKPROFILE: Document it doesn't work when run as unprivileged user Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/516/head:pr516 git checkout

[SSSD] [sssd PR#496][-Changes requested] sysdb: sanitize search filter input - backport sssd-1-13

2018-02-21 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/496 Title: #496: sysdb: sanitize search filter input - backport sssd-1-13 Label: -Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#516][-Changes requested] DESKPROFILE: Document it doesn't work when run as unprivileged user

2018-02-21 Thread fidencio
URL: https://github.com/SSSD/sssd/pull/516 Title: #516: DESKPROFILE: Document it doesn't work when run as unprivileged user Label: -Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#516][+Changes requested] DESKPROFILE: Document it doesn't work when run as unprivileged user

2018-02-21 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/516 Title: #516: DESKPROFILE: Document it doesn't work when run as unprivileged user Label: +Changes requested ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#496][comment] sysdb: sanitize search filter input - backport sssd-1-13

2018-02-21 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/496 Title: #496: sysdb: sanitize search filter input - backport sssd-1-13 lslebodn commented: """ And here are patches for 1.13 https://github.com/lslebodn/sssd/tree/cve_backport_1.13 @sumit-bose could you check them? """ See the full comment at

[SSSD] [sssd PR#497][closed] sysdb: sanitize search filter input - backport sssd-1-14

2018-02-21 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/497 Author: sumit-bose Title: #497: sysdb: sanitize search filter input - backport sssd-1-14 Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/497/head:pr497 git checkout pr497

[SSSD] [sssd PR#497][comment] sysdb: sanitize search filter input - backport sssd-1-14

2018-02-21 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/497 Title: #497: sysdb: sanitize search filter input - backport sssd-1-14 lslebodn commented: """ sssd-1-14: * e45e50e4523e36f310d7ff0b052500c024c434bf * e358dd7b4992da4c4aa7b7f769bd597222715127 * 353853d479225ba7a625658e58a3af989de909a5 *

[SSSD] [sssd PR#497][comment] sysdb: sanitize search filter input - backport sssd-1-14

2018-02-21 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/497 Title: #497: sysdb: sanitize search filter input - backport sssd-1-14 lslebodn commented: """ >@lslebodn, thank you for backporting. The selected patches are looking good. Thank you for checking. I'll push patches + create backport for 1.13 > Can you

[SSSD] [sssd PR#514][comment] Backport several UPN related patches to sssd-1-13

2018-02-21 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/514 Title: #514: Backport several UPN related patches to sssd-1-13 lslebodn commented: """ As part of backporting patches for sanitizing sysdb filters, we found out that we might consider backporting also afadeb1a530ff010a2f9a7552562576b843c874b. You

[SSSD] [sssd PR#497][comment] sysdb: sanitize search filter input - backport sssd-1-14

2018-02-21 Thread sumit-bose
URL: https://github.com/SSSD/sssd/pull/497 Title: #497: sysdb: sanitize search filter input - backport sssd-1-14 sumit-bose commented: """ @lslebodn, thank you for backporting. The selected patches are looking good. Can you add a comment to the related UPN PRs about afadeb1? """ See the full

[SSSD] [sssd PR#516][comment] DESKPROFILE: Document it doesn't work when run as unprivileged user

2018-02-21 Thread justin-stephenson
URL: https://github.com/SSSD/sssd/pull/516 Title: #516: DESKPROFILE: Document it doesn't work when run as unprivileged user justin-stephenson commented: """ Okay from my side. """ See the full comment at https://github.com/SSSD/sssd/pull/516#issuecomment-367351699

[SSSD] [sssd PR#517][+Pushed] Fix two memory leaks in the AD provider

2018-02-21 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/517 Title: #517: Fix two memory leaks in the AD provider Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#517][closed] Fix two memory leaks in the AD provider

2018-02-21 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/517 Author: sumit-bose Title: #517: Fix two memory leaks in the AD provider Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/517/head:pr517 git checkout pr517

[SSSD] [sssd PR#517][comment] Fix two memory leaks in the AD provider

2018-02-21 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/517 Title: #517: Fix two memory leaks in the AD provider jhrozek commented: """ * master: * e6ad16e05f42a1678a8c6cd14eb54ca75b8d775e

[SSSD] [sssd PR#517][comment] Fix two memory leaks in the AD provider

2018-02-21 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/517 Title: #517: Fix two memory leaks in the AD provider jhrozek commented: """ The internal CI is still down, but honestly I see no reason to wait for it, there's nothing that could work here but wouldn't work on other distros. ACK """ See the full

[SSSD] [sssd PR#517][+Accepted] Fix two memory leaks in the AD provider

2018-02-21 Thread jhrozek
URL: https://github.com/SSSD/sssd/pull/517 Title: #517: Fix two memory leaks in the AD provider Label: +Accepted ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#497][comment] sysdb: sanitize search filter input - backport sssd-1-14

2018-02-21 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/497 Title: #497: sysdb: sanitize search filter input - backport sssd-1-14 lslebodn commented: """ I know we started discussion as part of #496 but I firstly backported patches + sysdb unit tests to 1.14 branch.

[SSSD] [sssd PR#516][comment] DESKPROFILE: Document it doesn't work when run as unprivileged user

2018-02-21 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/516 Title: #516: DESKPROFILE: Document it doesn't work when run as unprivileged user lslebodn commented: """ LGTM from content point of view. @justin-stephenson could you check this PR as well? """ See the full comment at

[SSSD] [sssd PR#488][comment] Two fixes for certificates in idoverrides

2018-02-21 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/488 Title: #488: Two fixes for certificates in idoverrides lslebodn commented: """ This PR is also required for stable branch (1.13) #494. Please do not forget to push it also to older branches after pushing to master """ See the full comment at

[SSSD] [sssd PR#494][+Pushed] Backport support for certificates in idoverrides to sssd-1.13

2018-02-21 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/494 Title: #494: Backport support for certificates in idoverrides to sssd-1.13 Label: +Pushed ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#494][closed] Backport support for certificates in idoverrides to sssd-1.13

2018-02-21 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/494 Author: sumit-bose Title: #494: Backport support for certificates in idoverrides to sssd-1.13 Action: closed To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/494/head:pr494 git checkout pr494

[SSSD] [sssd PR#494][comment] Backport support for certificates in idoverrides to sssd-1.13

2018-02-21 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/494 Title: #494: Backport support for certificates in idoverrides to sssd-1.13 lslebodn commented: """ sssd-1-13: * 9d1397219374531e7f2a3188ea6aa9f86ca35f9e * 81f9af96065eb94ed0a9e6ef2b759761406b4b81 * f13505ce5632822e093982ca3bbf94f327d59a34 *

[SSSD] [sssd PR#494][comment] Backport support for certificates in idoverrides to sssd-1.13

2018-02-21 Thread lslebodn
URL: https://github.com/SSSD/sssd/pull/494 Title: #494: Backport support for certificates in idoverrides to sssd-1.13 lslebodn commented: """ > I added '(cherry picked from ...)' to the commit messages with a hint if > fixes where needed or not. thank you and ACK >Only the last patch does