URL: https://github.com/SSSD/sssd/pull/515
Title: #515: sssctl: Showing help even when sssd not configured
amitkumar50 commented:
"""
@pbrezina Thanks for review.
As I understood I need to add `poptGetOptArg(poptContext context)` function
inside `poptGetNextOpt()` to parse --help option.
But
URL: https://github.com/SSSD/sssd/pull/488
Title: #488: Two fixes for certificates in idoverrides
fidencio commented:
"""
@lslebodn, could you give your opinion/review here on the backported patches as
per https://github.com/SSSD/sssd/pull/488#issuecomment-367286098 ?
"""
See the full comment
URL: https://github.com/SSSD/sssd/pull/511
Title: #511: Do not shutdown KCM/Secrets responders when activities are
happening ...
jhrozek commented:
"""
sorry for the delay, the patches look OK now code-wise, I just need a bit more
time to do more careful testing (aka I'd like to run the code
URL: https://github.com/SSSD/sssd/pull/522
Title: #522: Prepare SSSD to support IPA in trust to Samba AD
jhrozek commented:
"""
I only scrolled through the patches, I must admit I didn't do any testing yet.
For the search bases, I would just appreciate a more descriptive variable names
than
URL: https://github.com/SSSD/sssd/pull/488
Title: #488: Two fixes for certificates in idoverrides
jhrozek commented:
"""
btw since I'll be afk tomorrow for most of the day and I don't dare to push the
patches myself at 10 PM my time without a discussion I created a backport here:
URL: https://github.com/SSSD/sssd/pull/488
Title: #488: Two fixes for certificates in idoverrides
jhrozek commented:
"""
I'm actually wondering whether we need to backport the patches or whether we
need to backport them both. I wonder if it enough to backport "ipa: remove
SYSDB_USER_CERT from
URL: https://github.com/SSSD/sssd/pull/488
Title: #488: Two fixes for certificates in idoverrides
jhrozek commented:
"""
I'm actually wondering whether we need to backport the patches or whether we
need to backport them both. I wonder if it enough to backport "ipa: remove
SYSDB_USER_CERT from
URL: https://github.com/SSSD/sssd/pull/488
Title: #488: Two fixes for certificates in idoverrides
jhrozek commented:
"""
I'm looking at what needs to be backported to sssd-1-13 before these two
patches before closing.
"""
See the full comment at
URL: https://github.com/SSSD/sssd/pull/488
Title: #488: Two fixes for certificates in idoverrides
jhrozek commented:
"""
* master:
* 5e04cbb8b6a10a794b698184fc84f9d359350253
URL: https://github.com/SSSD/sssd/pull/488
Title: #488: Two fixes for certificates in idoverrides
Label: +Accepted
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org
URL: https://github.com/SSSD/sssd/pull/488
Title: #488: Two fixes for certificates in idoverrides
jhrozek commented:
"""
I don't really have any other comments, ACK
"""
See the full comment at
https://github.com/SSSD/sssd/pull/488#issuecomment-368555947
URL: https://github.com/SSSD/sssd/pull/524
Author: lslebodn
Title: #524: CI: Add dbus into debian dependencies
Action: opened
PR body:
"""
There is just weak dependency (recommends) between dbus
libraries and dbus daemon. It is installed by default but we should
not rely in integration tests
URL: https://github.com/SSSD/sssd/pull/523
Author: lslebodn
Title: #523: IPA: Drop unused ifdef HAVE_SELINUX_LOGIN_DIR
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/523/head:pr523
git checkout pr523
From
URL: https://github.com/SSSD/sssd/pull/523
Title: #523: IPA: Drop unused ifdef HAVE_SELINUX_LOGIN_DIR
lslebodn commented:
"""
On (26/02/18 11:30), Pavel Březina wrote:
>When touching `sssm_ipa_selinux_init` can you also fix this typo:
Sure. Nice catch.
"""
See the full comment at
URL: https://github.com/SSSD/sssd/pull/523
Title: #523: IPA: Drop unused ifdef HAVE_SELINUX_LOGIN_DIR
pbrezina commented:
"""
When touching `sssm_ipa_selinux_init` can you also fix this typo:
```
#else
DEBUG(SSSDBG_MINOR_FAILURE, "SELinux init handler called but SSSD is "
URL: https://github.com/SSSD/sssd/pull/523
Author: lslebodn
Title: #523: IPA: Drop unused ifdef HAVE_SELINUX_LOGIN_DIR
Action: opened
PR body:
"""
Macros ALL_SERVICES and selogin_path were conditionally defined
in case of existing selinux login directory at configure time
(defined macro
URL: https://github.com/SSSD/sssd/pull/410
Title: #410: IPA: sanitize name in override search filter - Backport to
SSSD-1.13
Label: +Changes requested
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to
17 matches
Mail list logo
