[SSSD] [sssd PR#556][comment] COVERITY: Add coverity support

2018-04-27 Thread pbrezina 
  URL: https://github.com/SSSD/sssd/pull/556
Title: #556: COVERITY: Add coverity support

pbrezina commented:
"""
How can we access coverity result? I don't see any link.
"""

See the full comment at 
https://github.com/SSSD/sssd/pull/556#issuecomment-384975200
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#556][comment] COVERITY: Add coverity support

2018-04-27 Thread fidencio 
  URL: https://github.com/SSSD/sssd/pull/556
Title: #556: COVERITY: Add coverity support

fidencio commented:
"""
Actually no: Coverity Scan upload failed: Build successfully submitted ... same 
error.
"""

See the full comment at 
https://github.com/SSSD/sssd/pull/556#issuecomment-384962889
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#556][comment] COVERITY: Add coverity support

2018-04-27 Thread fidencio 
  URL: https://github.com/SSSD/sssd/pull/556
Title: #556: COVERITY: Add coverity support

fidencio commented:
"""
https://travis-ci.org/SSSD/sssd/builds/372008660

The error may happen if you're updating the very same build twice (which was 
the case).
"""

See the full comment at 
https://github.com/SSSD/sssd/pull/556#issuecomment-384962016
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#558][comment] WIP: Add a test for sss_nss_getgrouplist_timeout and fix invalidating the initgroups cache

2018-04-27 Thread sumit-bose 
  URL: https://github.com/SSSD/sssd/pull/558
Title: #558: WIP: Add a test for sss_nss_getgrouplist_timeout and fix 
invalidating the initgroups cache

sumit-bose commented:
"""
@pbrezina, maybe 
https://docs.pagure.org/SSSD.sssd/developers/mmap_cache_1.15.html#the-initgr-data
 can help to explain the peculiars of the name handling of the memory cache 
with initgroups requests.
"""

See the full comment at 
https://github.com/SSSD/sssd/pull/558#issuecomment-384958801
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#556][comment] COVERITY: Add coverity support

2018-04-27 Thread fidencio 
  URL: https://github.com/SSSD/sssd/pull/556
Title: #556: COVERITY: Add coverity support

fidencio commented:
"""
I have rebased my branch and fired a new build, let's see what happens.
"""

See the full comment at 
https://github.com/SSSD/sssd/pull/556#issuecomment-384955545
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#556][comment] COVERITY: Add coverity support

2018-04-27 Thread fidencio 
  URL: https://github.com/SSSD/sssd/pull/556
Title: #556: COVERITY: Add coverity support

fidencio commented:
"""
Yep, we don't push more than once a day anyways.

About the error, I didn't notice it before. Not sure what it means.
"""

See the full comment at 
https://github.com/SSSD/sssd/pull/556#issuecomment-384952672
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#560][comment] NSS: close files after mmap

2018-04-27 Thread ChrisKowalczyk 
  URL: https://github.com/SSSD/sssd/pull/560
Title: #560: NSS: close files after mmap

ChrisKowalczyk commented:
"""
Thanks for all the comments and quick feedback! Sorry for sharing a closed bug 
report, I will prepare some better description of this scenario. I will also 
make sure that the tests are not failing.
@mzidek-rh , yes, I think your first comment was true for the second place we 
use mmap in sssd. I will follow @simo5 advice.
@jhrozek , I think that sss_cache was not the case, and this happened just 
after starting sssd. But as I mentioned, I will double check everything, update 
PR and provide better description and logs.
"""

See the full comment at 
https://github.com/SSSD/sssd/pull/560#issuecomment-384952061
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#554][+Pushed] Several fixes for the files provider

2018-04-27 Thread fidencio 
  URL: https://github.com/SSSD/sssd/pull/554
Title: #554: Several fixes for the files provider

Label: +Pushed
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#554][-Accepted] Several fixes for the files provider

2018-04-27 Thread fidencio 
  URL: https://github.com/SSSD/sssd/pull/554
Title: #554: Several fixes for the files provider

Label: -Accepted
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#554][closed] Several fixes for the files provider

2018-04-27 Thread fidencio 
   URL: https://github.com/SSSD/sssd/pull/554
Author: jhrozek
 Title: #554: Several fixes for the files provider
Action: closed

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/554/head:pr554
git checkout pr554
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#554][comment] Several fixes for the files provider

2018-04-27 Thread fidencio 
  URL: https://github.com/SSSD/sssd/pull/554
Title: #554: Several fixes for the files provider

fidencio commented:
"""
master:
 d69e1da
 1f8bfb6
 81f1699
 c1bce7d
 77d63f5
"""

See the full comment at 
https://github.com/SSSD/sssd/pull/554#issuecomment-384950049
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#559][+Pushed] TESTS: Fix typo in test_sysdb_domain_resolution_order_ops()

2018-04-27 Thread fidencio 
  URL: https://github.com/SSSD/sssd/pull/559
Title: #559: TESTS: Fix typo in test_sysdb_domain_resolution_order_ops()

Label: +Pushed
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#559][-Accepted] TESTS: Fix typo in test_sysdb_domain_resolution_order_ops()

2018-04-27 Thread fidencio 
  URL: https://github.com/SSSD/sssd/pull/559
Title: #559: TESTS: Fix typo in test_sysdb_domain_resolution_order_ops()

Label: -Accepted
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#559][closed] TESTS: Fix typo in test_sysdb_domain_resolution_order_ops()

2018-04-27 Thread fidencio 
   URL: https://github.com/SSSD/sssd/pull/559
Author: fidencio
 Title: #559: TESTS: Fix typo in test_sysdb_domain_resolution_order_ops()
Action: closed

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/559/head:pr559
git checkout pr559
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#511][+Pushed] Do not shutdown KCM/Secrets responders when activities are happening ...

2018-04-27 Thread fidencio 
  URL: https://github.com/SSSD/sssd/pull/511
Title: #511: Do not shutdown KCM/Secrets responders when activities are 
happening ...

Label: +Pushed
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#511][-Accepted] Do not shutdown KCM/Secrets responders when activities are happening ...

2018-04-27 Thread fidencio 
  URL: https://github.com/SSSD/sssd/pull/511
Title: #511: Do not shutdown KCM/Secrets responders when activities are 
happening ...

Label: -Accepted
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#511][closed] Do not shutdown KCM/Secrets responders when activities are happening ...

2018-04-27 Thread fidencio 
   URL: https://github.com/SSSD/sssd/pull/511
Author: fidencio
 Title: #511: Do not shutdown KCM/Secrets responders when activities are 
happening ...
Action: closed

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/511/head:pr511
git checkout pr511
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#556][comment] COVERITY: Add coverity support

2018-04-27 Thread pbrezina 
  URL: https://github.com/SSSD/sssd/pull/556
Title: #556: COVERITY: Add coverity support

pbrezina commented:
"""
Also I  see failure at https://travis-ci.org/SSSD/sssd/builds/368726074#L7056 
what does it mean?
"""

See the full comment at 
https://github.com/SSSD/sssd/pull/556#issuecomment-384948776
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#511][comment] Do not shutdown KCM/Secrets responders when activities are happening ...

2018-04-27 Thread fidencio 
  URL: https://github.com/SSSD/sssd/pull/511
Title: #511: Do not shutdown KCM/Secrets responders when activities are 
happening ...

fidencio commented:
"""
master:
 8655dd0
 cefadc6
 26592d1
 2f70065
 04c236c
 01ef93a
 1ab24b3
 ac9c3ad
"""

See the full comment at 
https://github.com/SSSD/sssd/pull/511#issuecomment-384948849
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#556][comment] COVERITY: Add coverity support

2018-04-27 Thread pbrezina 
  URL: https://github.com/SSSD/sssd/pull/556
Title: #556: COVERITY: Add coverity support

pbrezina commented:
"""
We talked about this with Jakub few weeks ago. Your patches looks nice, thank 
you for this initiation. There is just one thing we must keep in mind, as you 
can see at https://scan.coverity.com there are limits for free scans:
> **Updated Build Limits**
> Effective immediately, the build limits have been increased across all 
> project sizes.
> The number of weekly builds per project are as follows:
> * Up to 28 builds per week, with a maximum of 4 builds per day, for projects 
> with fewer than 100K lines of code
> * Up to 21 builds per week, with a maximum of 3 builds per day, for projects 
> with 100K to 500K lines of code
> * Up to 14 builds per week, with a maximum of 2 build per day, for projects 
> with 500K to 1 million lines of code
> * Up to 7 builds per week, with a maximum of 1 build per day, for projects 
> with more than 1 million lines of code
>
> As before, once a project reaches the maximum builds per week, additional 
> build requests will be rejected. 

Therefore, we should not run it per pull request, but rather run it daily on 
master and manually per-pr when needed urgently.
"""

See the full comment at 
https://github.com/SSSD/sssd/pull/556#issuecomment-384948464
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#551][comment] GPO: Fix bug with empty GPO rules

2018-04-27 Thread fidencio 
  URL: https://github.com/SSSD/sssd/pull/551
Title: #551: GPO: Fix bug with empty GPO rules

fidencio commented:
"""
master:
 e6e5fe3
"""

See the full comment at 
https://github.com/SSSD/sssd/pull/551#issuecomment-384948486
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#551][+Pushed] GPO: Fix bug with empty GPO rules

2018-04-27 Thread fidencio 
  URL: https://github.com/SSSD/sssd/pull/551
Title: #551: GPO: Fix bug with empty GPO rules

Label: +Pushed
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#551][closed] GPO: Fix bug with empty GPO rules

2018-04-27 Thread fidencio 
   URL: https://github.com/SSSD/sssd/pull/551
Author: mzidek-rh
 Title: #551: GPO: Fix bug with empty GPO rules
Action: closed

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/551/head:pr551
git checkout pr551
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#551][-Accepted] GPO: Fix bug with empty GPO rules

2018-04-27 Thread fidencio 
  URL: https://github.com/SSSD/sssd/pull/551
Title: #551: GPO: Fix bug with empty GPO rules

Label: -Accepted
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#558][comment] WIP: Add a test for sss_nss_getgrouplist_timeout and fix invalidating the initgroups cache

2018-04-27 Thread pbrezina 
  URL: https://github.com/SSSD/sssd/pull/558
Title: #558: WIP: Add a test for sss_nss_getgrouplist_timeout and fix 
invalidating the initgroups cache

pbrezina commented:
"""
Test looks good, but I will need better explanation of the issue in the first 
patch. Even pagure ticket is not verbose enough for me :-)
"""

See the full comment at 
https://github.com/SSSD/sssd/pull/558#issuecomment-384946429
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#511][+Accepted] Do not shutdown KCM/Secrets responders when activities are happening ...

2018-04-27 Thread jhrozek 
  URL: https://github.com/SSSD/sssd/pull/511
Title: #511: Do not shutdown KCM/Secrets responders when activities are 
happening ...

Label: +Accepted
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#551][+Accepted] GPO: Fix bug with empty GPO rules

2018-04-27 Thread jhrozek 
  URL: https://github.com/SSSD/sssd/pull/551
Title: #551: GPO: Fix bug with empty GPO rules

Label: +Accepted
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#511][comment] Do not shutdown KCM/Secrets responders when activities are happening ...

2018-04-27 Thread fidencio 
  URL: https://github.com/SSSD/sssd/pull/511
Title: #511: Do not shutdown KCM/Secrets responders when activities are 
happening ...

fidencio commented:
"""
CI: http://vm-031.${abc}/logs/job/88/20/summary.html
"""

See the full comment at 
https://github.com/SSSD/sssd/pull/511#issuecomment-384928060
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#511][synchronized] Do not shutdown KCM/Secrets responders when activities are happening ...

2018-04-27 Thread fidencio 
   URL: https://github.com/SSSD/sssd/pull/511
Author: fidencio
 Title: #511: Do not shutdown KCM/Secrets responders when activities are 
happening ...
Action: synchronized

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/511/head:pr511
git checkout pr511
From 1196a2dd39edeb432a62cf82a0d43e1f8eb3e0be Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Fabiano=20Fid=C3=AAncio?= 
Date: Wed, 7 Feb 2018 13:20:31 +0100
Subject: [PATCH 1/8] SECRETS: reset last_request_time on any activity
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

As all the activities are being handled by the secrets responder itself
and not by responder's common code, we have to take care of re-setting
the last_request_time by ourselves here.

Without this patch, the responder would be shot down after reaching the
idle_timeout with activities happening or not.

Resolves:
https://pagure.io/SSSD/sssd/issue/3633

Signed-off-by: Fabiano Fidêncio 
---
 src/responder/secrets/secsrv_cmd.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/src/responder/secrets/secsrv_cmd.c b/src/responder/secrets/secsrv_cmd.c
index fa5970504..1b405a23e 100644
--- a/src/responder/secrets/secsrv_cmd.c
+++ b/src/responder/secrets/secsrv_cmd.c
@@ -588,6 +588,9 @@ static void sec_fd_handler(struct tevent_context *ev,
 errno_t ret;
 struct cli_ctx *cctx = talloc_get_type(ptr, struct cli_ctx);
 
+/* Always reset the responder idle timer on any activity */
+cctx->rctx->last_request_time = time(NULL);
+
 /* Always reset the idle timer on any activity */
 ret = reset_client_idle_timer(cctx);
 if (ret != EOK) {

From eeefb4889403f338d44716eceb2617319ce55e13 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Fabiano=20Fid=C3=AAncio?= 
Date: Wed, 7 Feb 2018 13:24:05 +0100
Subject: [PATCH 2/8] KCM: reset last_request_time on any activity
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

As all the activities are being handled by the kcm responder itself and
not by responder's common code, we have to take care of re-setting the
last_request_time by ourselves here.

Without this patch, the responder would be shot down after reaching the
idle_timeout with activities happening or not.

Resolves:
https://pagure.io/SSSD/sssd/issue/3633

Signed-off-by: Fabiano Fidêncio 
---
 src/responder/kcm/kcmsrv_cmd.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/src/responder/kcm/kcmsrv_cmd.c b/src/responder/kcm/kcmsrv_cmd.c
index 728979da9..9061ff186 100644
--- a/src/responder/kcm/kcmsrv_cmd.c
+++ b/src/responder/kcm/kcmsrv_cmd.c
@@ -615,6 +615,9 @@ static void kcm_fd_handler(struct tevent_context *ev,
 errno_t ret;
 struct cli_ctx *cctx = talloc_get_type(ptr, struct cli_ctx);
 
+/* Always reset the responder idle timer on any activity */
+cctx->rctx->last_request_time = time(NULL);
+
 /* Always reset the idle timer on any activity */
 ret = reset_client_idle_timer(cctx);
 if (ret != EOK) {

From d899224d7e43a246b94ff930ac7da175d6a3bd42 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Fabiano=20Fid=C3=AAncio?= 
Date: Wed, 7 Feb 2018 17:06:39 +0100
Subject: [PATCH 3/8] RESPONDER: Add sss_client_fd_handler()
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Currently we have 3 functions to handle client fds:
- sec_fd_handler(): for secrets responder
- kcm_fd_handler(): for kcm responder
- client_fd_handler(): for all the others reponders

As those functions only differ by the functions used to handle sending
and receiving data to the fds, let's create a generic function that
receives the specific send_fn() and recv_fn() functions.

With this newly introduced function we'll be able to simply remove
duplicated code from those 3 handlers and just call
sss_client_fd_handler() from all of those.

Resolves:
https://pagure.io/SSSD/sssd/issue/3633

Signed-off-by: Fabiano Fidêncio 
---
 src/responder/common/responder.h|  5 +
 src/responder/common/responder_common.c | 31 +++
 2 files changed, 36 insertions(+)

diff --git a/src/responder/common/responder.h b/src/responder/common/responder.h
index 9400e4b60..987a5d17d 100644
--- a/src/responder/common/responder.h
+++ b/src/responder/common/responder.h
@@ -197,6 +197,11 @@ typedef int (*connection_setup_t)(struct cli_ctx *cctx);
 
 int sss_connection_setup(struct cli_ctx *cctx);
 
+void sss_client_fd_handler(void *ptr,
+   void (*recv_fn) (struct cli_ctx *cctx),
+   void (*send_fn) (struct cli_ctx *cctx),
+   uint16_t flags);
+
 int sss_process_init(TALLOC_CTX *mem_ctx,
  struct tevent_context *ev,
  struct confdb_ctx *cdb,
diff --git

[SSSD] [sssd PR#547][+Rejected] Tests for #511

2018-04-27 Thread fidencio 
  URL: https://github.com/SSSD/sssd/pull/547
Title: #547: Tests for #511

Label: +Rejected
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#547][-Blocked] Tests for #511

2018-04-27 Thread fidencio 
  URL: https://github.com/SSSD/sssd/pull/547
Title: #547: Tests for #511

Label: -Blocked
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#547][closed] Tests for #511

2018-04-27 Thread fidencio 
   URL: https://github.com/SSSD/sssd/pull/547
Author: fidencio
 Title: #547: Tests for #511
Action: closed

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/547/head:pr547
git checkout pr547
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#547][comment] Tests for #511

2018-04-27 Thread fidencio 
  URL: https://github.com/SSSD/sssd/pull/547
Title: #547: Tests for #511

fidencio commented:
"""
In the end the tests will be reviewed together with the code. So, I'm closing 
this PR.
"""

See the full comment at 
https://github.com/SSSD/sssd/pull/547#issuecomment-384891548
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org

[SSSD] [sssd PR#511][comment] Do not shutdown KCM/Secrets responders when activities are happening ...

2018-04-27 Thread fidencio 
  URL: https://github.com/SSSD/sssd/pull/511
Title: #511: Do not shutdown KCM/Secrets responders when activities are 
happening ...

fidencio commented:
"""
I've updated the patch set following @jhrozek's suggestion.
Here is the output of a run with and without passing the "-m 'not slow'" to the 
tests:
```
[ffidenci@pessoa x86_64]$ make intgcheck-run INTGCHECK_PYTEST_ARGS="-k 
test_secrets.py"
set -e; \
if [ ! -d intg/pfx ]; then make intgcheck-prepare; fi; \
cd intg/bld; \
make  -C src/tests/intg intgcheck-installed; \
cd ../..
make[1]: Entering directory 
'/home/brq/ffidenci/src/upstream/sssd/x86_64/intg/bld/src/tests/intg'
pipepath="/tmp/sssd-intg.hls5nvgr/var/lib/sss/pipes"; \
if test ${#pipepath} -gt 80; then \
echo "error: Pipe directory path too long," \
 "D-Bus won't be able to open sockets" >&2; \
exit 1; \
fi
set -e; \
cd "/home/brq/ffidenci/src/upstream/sssd/x86_64/../src/tests/intg"; \
nss_wrapper=$(pkg-config --libs nss_wrapper); \
uid_wrapper=$(pkg-config --libs uid_wrapper); \
unset HOME; \
PATH="$(dirname -- /usr/sbin/slapd):$PATH" \
PATH="/tmp/sssd-intg.hls5nvgr/sbin:/tmp/sssd-intg.hls5nvgr/bin:$PATH" \
PATH="$PATH:/home/brq/ffidenci/src/upstream/sssd/x86_64/intg/bld/src/tests/intg:/home/brq/ffidenci/src/upstream/sssd/x86_64/../src/tests/intg"
 \
PYTHONPATH="/home/brq/ffidenci/src/upstream/sssd/x86_64/intg/bld/src/tests/intg:/home/brq/ffidenci/src/upstream/sssd/x86_64/../src/tests/intg"
 \
LDB_MODULES_PATH="/tmp/sssd-intg.hls5nvgr/lib/ldb" \
NON_WRAPPED_UID=$(id -u) \
LD_PRELOAD="/tmp/sssd-intg.hls5nvgr/lib/getsockopt_wrapper.so:$nss_wrapper:$uid_wrapper"
 \
NSS_WRAPPER_PASSWD="/home/brq/ffidenci/src/upstream/sssd/x86_64/intg/bld/src/tests/intg/passwd"
 \
NSS_WRAPPER_GROUP="/home/brq/ffidenci/src/upstream/sssd/x86_64/intg/bld/src/tests/intg/group"
 \
NSS_WRAPPER_MODULE_SO_PATH="/tmp/sssd-intg.hls5nvgr/lib/libnss_sss.so.2" \
NSS_WRAPPER_MODULE_FN_PREFIX="sss" \
UID_WRAPPER=1 \
UID_WRAPPER_ROOT=1 \
DBUS_SOCK_DIR="/tmp/sssd-intg.hls5nvgr/var/run/dbus/" \
DBUS_SESSION_BUS_ADDRESS="unix:path=$DBUS_SOCK_DIR/fake_socket" \
DBUS_SYSTEM_BUS_ADDRESS="unix:path=$DBUS_SOCK_DIR/system_bus_socket" \
DBUS_SYSTEM_BUS_DEFAULT_ADDRESS="$DBUS_SYSTEM_BUS_ADDRESS" \
fakeroot /usr/bin/python2 /usr/bin/py.test -v --tb=native -k 
test_secrets.py .
= test session starts 
==
platform linux2 -- Python 2.7.14, pytest-3.2.3, py-1.4.34, pluggy-0.4.0 -- 
/usr/bin/python2
cachedir: .cache
rootdir: /home/brq/ffidenci/src/upstream/sssd/src/tests/intg, inifile:
collected 261 items 


test_secrets.py::test_crd_ops PASSED
test_secrets.py::test_curlwrap_crd_ops PASSED
test_secrets.py::test_curlwrap_parallel PASSED
test_secrets.py::test_containers PASSED
test_secrets.py::test_cli_idle_timeout PASSED
test_secrets.py::test_global_quota PASSED
test_secrets.py::test_sec_quota PASSED
test_secrets.py::test_per_uid_limit PASSED
test_secrets.py::test_unlimited_quotas PASSED
test_secrets.py::test_resp_idle_timeout_shutdown_slow PASSED
test_secrets.py::test_resp_idle_timeout_postpone_shutdown_slow PASSED

= 250 tests deselected 
=
= 11 passed, 250 deselected in 
267.31 seconds ==
rm -f /tmp/sssd-intg.hls5nvgr/var/log/sssd/*
make[1]: Leaving directory 
'/home/brq/ffidenci/src/upstream/sssd/x86_64/intg/bld/src/tests/intg'



[ffidenci@pessoa x86_64]$ make intgcheck-run INTGCHECK_PYTEST_ARGS="-k 
test_secrets.py -m 'not slow'"
set -e; \
if [ ! -d intg/pfx ]; then make intgcheck-prepare; fi; \
cd intg/bld; \
make  -C src/tests/intg intgcheck-installed; \
cd ../..
make[1]: Entering directory 
'/home/brq/ffidenci/src/upstream/sssd/x86_64/intg/bld/src/tests/intg'
pipepath="/tmp/sssd-intg.hls5nvgr/var/lib/sss/pipes"; \
if test ${#pipepath} -gt 80; then \
echo "error: Pipe directory path too long," \
 "D-Bus won't be able to open sockets" >&2; \
exit 1; \
fi
set -e; \
cd "/home/brq/ffidenci/src/upstream/sssd/x86_64/../src/tests/intg"; \
nss_wrapper=$(pkg-config --libs nss_wrapper); \
uid_wrapper=$(pkg-config --libs uid_wrapper); \
unset HOME; \
PATH="$(dirname -- /usr/sbin/slapd):$PATH" \
PATH="/tmp/sssd-intg.hls5nvgr/sbin:/tmp/sssd-intg.hls5nvgr/bin:$PATH" \
PATH="$PATH:/home/brq/ffidenci/src/upstream/sssd/x86_64/intg/bld/src/tests/intg:/home/brq/ffidenci/src/upstream/sssd/x86_64/../src/tests/intg"
 \
PYTHONPATH="/home/brq/ffidenci/src/upstream/sssd/x86_64/intg/bld/src/tests/intg:/home/brq/ffidenci/src/upstream/sssd/x86_64/../src/tests/intg"
 \
LDB_MODULES_PATH="/tmp/sssd-intg.hls5nvgr/lib/ldb" \
NON_WRAPPED_UID=$(id -u) \

[SSSD] [sssd PR#511][synchronized] Do not shutdown KCM/Secrets responders when activities are happening ...

2018-04-27 Thread fidencio 
   URL: https://github.com/SSSD/sssd/pull/511
Author: fidencio
 Title: #511: Do not shutdown KCM/Secrets responders when activities are 
happening ...
Action: synchronized

To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/511/head:pr511
git checkout pr511
From 1196a2dd39edeb432a62cf82a0d43e1f8eb3e0be Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Fabiano=20Fid=C3=AAncio?= 
Date: Wed, 7 Feb 2018 13:20:31 +0100
Subject: [PATCH 1/8] SECRETS: reset last_request_time on any activity
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

As all the activities are being handled by the secrets responder itself
and not by responder's common code, we have to take care of re-setting
the last_request_time by ourselves here.

Without this patch, the responder would be shot down after reaching the
idle_timeout with activities happening or not.

Resolves:
https://pagure.io/SSSD/sssd/issue/3633

Signed-off-by: Fabiano Fidêncio 
---
 src/responder/secrets/secsrv_cmd.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/src/responder/secrets/secsrv_cmd.c b/src/responder/secrets/secsrv_cmd.c
index fa5970504..1b405a23e 100644
--- a/src/responder/secrets/secsrv_cmd.c
+++ b/src/responder/secrets/secsrv_cmd.c
@@ -588,6 +588,9 @@ static void sec_fd_handler(struct tevent_context *ev,
 errno_t ret;
 struct cli_ctx *cctx = talloc_get_type(ptr, struct cli_ctx);
 
+/* Always reset the responder idle timer on any activity */
+cctx->rctx->last_request_time = time(NULL);
+
 /* Always reset the idle timer on any activity */
 ret = reset_client_idle_timer(cctx);
 if (ret != EOK) {

From eeefb4889403f338d44716eceb2617319ce55e13 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Fabiano=20Fid=C3=AAncio?= 
Date: Wed, 7 Feb 2018 13:24:05 +0100
Subject: [PATCH 2/8] KCM: reset last_request_time on any activity
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

As all the activities are being handled by the kcm responder itself and
not by responder's common code, we have to take care of re-setting the
last_request_time by ourselves here.

Without this patch, the responder would be shot down after reaching the
idle_timeout with activities happening or not.

Resolves:
https://pagure.io/SSSD/sssd/issue/3633

Signed-off-by: Fabiano Fidêncio 
---
 src/responder/kcm/kcmsrv_cmd.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/src/responder/kcm/kcmsrv_cmd.c b/src/responder/kcm/kcmsrv_cmd.c
index 728979da9..9061ff186 100644
--- a/src/responder/kcm/kcmsrv_cmd.c
+++ b/src/responder/kcm/kcmsrv_cmd.c
@@ -615,6 +615,9 @@ static void kcm_fd_handler(struct tevent_context *ev,
 errno_t ret;
 struct cli_ctx *cctx = talloc_get_type(ptr, struct cli_ctx);
 
+/* Always reset the responder idle timer on any activity */
+cctx->rctx->last_request_time = time(NULL);
+
 /* Always reset the idle timer on any activity */
 ret = reset_client_idle_timer(cctx);
 if (ret != EOK) {

From d899224d7e43a246b94ff930ac7da175d6a3bd42 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Fabiano=20Fid=C3=AAncio?= 
Date: Wed, 7 Feb 2018 17:06:39 +0100
Subject: [PATCH 3/8] RESPONDER: Add sss_client_fd_handler()
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Currently we have 3 functions to handle client fds:
- sec_fd_handler(): for secrets responder
- kcm_fd_handler(): for kcm responder
- client_fd_handler(): for all the others reponders

As those functions only differ by the functions used to handle sending
and receiving data to the fds, let's create a generic function that
receives the specific send_fn() and recv_fn() functions.

With this newly introduced function we'll be able to simply remove
duplicated code from those 3 handlers and just call
sss_client_fd_handler() from all of those.

Resolves:
https://pagure.io/SSSD/sssd/issue/3633

Signed-off-by: Fabiano Fidêncio 
---
 src/responder/common/responder.h|  5 +
 src/responder/common/responder_common.c | 31 +++
 2 files changed, 36 insertions(+)

diff --git a/src/responder/common/responder.h b/src/responder/common/responder.h
index 9400e4b60..987a5d17d 100644
--- a/src/responder/common/responder.h
+++ b/src/responder/common/responder.h
@@ -197,6 +197,11 @@ typedef int (*connection_setup_t)(struct cli_ctx *cctx);
 
 int sss_connection_setup(struct cli_ctx *cctx);
 
+void sss_client_fd_handler(void *ptr,
+   void (*recv_fn) (struct cli_ctx *cctx),
+   void (*send_fn) (struct cli_ctx *cctx),
+   uint16_t flags);
+
 int sss_process_init(TALLOC_CTX *mem_ctx,
  struct tevent_context *ev,
  struct confdb_ctx *cdb,
diff --git

[SSSD] [sssd PR#546][comment] TESTS: Re-add tests for `kdestroy -A`

2018-04-27 Thread jhrozek 
  URL: https://github.com/SSSD/sssd/pull/546
Title: #546: TESTS: Re-add tests for `kdestroy -A`

jhrozek commented:
"""
We can mark the test as expected failure. I'm not sure myself if it's better or 
not, but tl;dr marking the test as expected failure would still print "failed" 
when you run the tests from the command line, but not fail the whole testsuite.

Personally, I would be OK with that because I run the test on Fedora where the 
bug is fixed.
"""

See the full comment at 
https://github.com/SSSD/sssd/pull/546#issuecomment-384888704
___
sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org
To unsubscribe send an email to sssd-devel-le...@lists.fedorahosted.org