[SSSD] [sssd PR#5812][+Ready to push] Tests: Modify ported AD tests marker to tier1_2 and fix a restore error

2021-11-23 Thread jakub-vavra-cz
URL: https://github.com/SSSD/sssd/pull/5812 Title: #5812: Tests: Modify ported AD tests marker to tier1_2 and fix a restore error Label: +Ready to push ___ sssd-devel mailing list -- sssd-devel@lists.fedorahosted.org To unsubscribe send an email to

[SSSD] [sssd PR#5835][comment] Tests: Add test for bz1636002.

2021-11-23 Thread jakub-vavra-cz
URL: https://github.com/SSSD/sssd/pull/5835 Title: #5835: Tests: Add test for bz1636002. jakub-vavra-cz commented: """ Ready for review a possibly merging. """ See the full comment at https://github.com/SSSD/sssd/pull/5835#issuecomment-977582886 ___

[SSSD] [sssd PR#5886][comment] install python files conditionally

2021-11-23 Thread SoapGentoo
URL: https://github.com/SSSD/sssd/pull/5886 Title: #5886: install python files conditionally SoapGentoo commented: """ I'm fine either way, I just want a clear statement. Currently, it's required at build-time, and implicitly required at run-time if you don't prune the python files. Hence I

[SSSD] [sssd PR#5886][comment] install python files conditionally

2021-11-23 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/5886 Title: #5886: install python files conditionally pbrezina commented: """ Lets ask first - is the analyzer optional? Currently not, is is always part of the build. In Fedora, we package it inside sssd-tools which is optional for the user. So, for

[SSSD] [sssd PR#5845][comment] sss-analyze: Fix self imports

2021-11-23 Thread stanislavlevin
URL: https://github.com/SSSD/sssd/pull/5845 Title: #5845: sss-analyze: Fix self imports stanislavlevin commented: """ > Thank you for the update. In general, I agree with the patches. But I think > the proper location require a team discussion about our future plans with > python tools so we

[SSSD] [sssd PR#5886][comment] install python files conditionally

2021-11-23 Thread SoapGentoo
URL: https://github.com/SSSD/sssd/pull/5886 Title: #5886: install python files conditionally SoapGentoo commented: """ this goes back to my second question: is python optional or not? If it's optional, these files shouldn't be installed. If it's non-optional, we always know to depend on

[SSSD] [sssd PR#5886][comment] install python files conditionally

2021-11-23 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/5886 Title: #5886: install python files conditionally pbrezina commented: """ @SoapGentoo And why is that, if I may ask? """ See the full comment at https://github.com/SSSD/sssd/pull/5886#issuecomment-976756688

[SSSD] [sssd PR#5845][comment] sss-analyze: Fix self imports

2021-11-23 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/5845 Title: #5845: sss-analyze: Fix self imports pbrezina commented: """ Thank you for the update. In general, I agree with the patches. But I think the proper location require a team discussion about our future plans with python tools so we don't end up

[SSSD] [sssd PR#5886][comment] install python files conditionally

2021-11-23 Thread SoapGentoo
URL: https://github.com/SSSD/sssd/pull/5886 Title: #5886: install python files conditionally SoapGentoo commented: """ @pbrezina correct, that is the intention """ See the full comment at https://github.com/SSSD/sssd/pull/5886#issuecomment-976703742

[SSSD] [sssd PR#5845][comment] sss-analyze: Fix self imports

2021-11-23 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/5845 Title: #5845: sss-analyze: Fix self imports pbrezina commented: """ Kind of related: https://github.com/SSSD/sssd/pull/5886 """ See the full comment at https://github.com/SSSD/sssd/pull/5845#issuecomment-976703369

[SSSD] [sssd PR#5886][comment] install python files conditionally

2021-11-23 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/5886 Title: #5886: install python files conditionally pbrezina commented: """ I think we should talk about our plans for future extensions to python tools/conversion of sssctl to python and decide where to put the analyzer files based on that so we don't

[SSSD] [sssd PR#5886][comment] install python files conditionally

2021-11-23 Thread pbrezina
URL: https://github.com/SSSD/sssd/pull/5886 Title: #5886: install python files conditionally pbrezina commented: """ Maybe we can provide a switch that would install python tools (since we may add more tools in the future) so add something like --with-python3-tools (enabled by default)

[SSSD] [sssd PR#5887][opened] Tests: proxy provider, user's removed secondary group remains in sssd cache

2021-11-23 Thread shridhargadekar
URL: https://github.com/SSSD/sssd/pull/5887 Author: shridhargadekar Title: #5887: Tests: proxy provider, user's removed secondary group remains in sssd cache Action: opened PR body: """ Verifies: #5783 Bug: https://bugzilla.redhat.com/show_bug.cgi?id=1917970 """ To pull the PR as Git

[SSSD] [sssd PR#5886][comment] install python files conditionally

2021-11-23 Thread SoapGentoo
URL: https://github.com/SSSD/sssd/pull/5886 Title: #5886: install python files conditionally SoapGentoo commented: """ I agree, in that case, another option is the better path. In general, we currently disable passing `PYTHON` to `./configure` when the bindings are disabled, leading to an

[SSSD] [sssd PR#5886][comment] install python files conditionally

2021-11-23 Thread justin-stephenson
URL: https://github.com/SSSD/sssd/pull/5886 Title: #5886: install python files conditionally justin-stephenson commented: """ > Let me ask the question differently: does sssd require python > unconditionally? That is, even without python bindings, python is still > required for scripts such

[SSSD] [sssd PR#5883][comment] Various fixes related forest and site name discovery

2021-11-23 Thread elkoniu
URL: https://github.com/SSSD/sssd/pull/5883 Title: #5883: Various fixes related forest and site name discovery elkoniu commented: """ Hi @sumit-bose , if there is any test scenario to follow for this PR verification? """ See the full comment at